From: Ian Campbell <Ian.Campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
Subject: Re: [OSSTEST PATCH v4 3/9] ts-xen-build: build with XSM support if requested
Date: Mon, 2 Feb 2015 14:51:58 +0000 [thread overview]
Message-ID: <1422888718.19293.44.camel@citrix.com> (raw)
In-Reply-To: <20150202143048.GA2743@zion.uk.xensource.com>
On Mon, 2015-02-02 at 14:30 +0000, Wei Liu wrote:
> On Mon, Feb 02, 2015 at 01:14:34PM +0000, Ian Campbell wrote:
> > On Wed, 2014-12-10 at 22:21 +0000, Wei Liu wrote:
> > > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> >
> > Inconsistent whitespace in the final hunk, but:
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> >
> > This will override the default XSM_ENABLE always, even if no runvar is
> > present, I guess we think that is correct?
> >
>
> I'm not sure what's correct. I originally treated it as the same as
> debug=. But now since there is doubt about what is the correct behaviour
> I will make it only set XSM_ENABLE when runvar is set in next version.
That's probably going to have the least potential to be problematic in
the future.
Ian.
next prev parent reply other threads:[~2015-02-02 14:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 22:21 [OSSTEST PATCH v4 0/9] XSM test case for OSSTest Wei Liu
2014-12-10 22:21 ` [OSSTEST PATCH v4 1/9] overlay: update overlay/etc/grub.d/20_linux_xen Wei Liu
2015-02-02 13:10 ` Ian Campbell
2014-12-10 22:21 ` [OSSTEST PATCH v4 2/9] ts-xen-build-prep: install checkpolicy Wei Liu
2014-12-10 22:21 ` [OSSTEST PATCH v4 3/9] ts-xen-build: build with XSM support if requested Wei Liu
2015-02-02 13:14 ` Ian Campbell
2015-02-02 14:30 ` Wei Liu
2015-02-02 14:51 ` Ian Campbell [this message]
2014-12-10 22:21 ` [OSSTEST PATCH v4 4/9] mfi-common: create build-$arch-xsm job Wei Liu
2015-02-02 13:16 ` Ian Campbell
2014-12-10 22:21 ` [OSSTEST PATCH v4 5/9] Debian.pm: pass in XSM configuration to bootloader setup routines Wei Liu
2014-12-10 22:21 ` [OSSTEST PATCH v4 6/9] Debian.pm: load flask policy in uboot Wei Liu
2014-12-10 22:21 ` [OSSTEST PATCH v4 7/9] ts-xen-install: install Xen with XSM support if requested Wei Liu
2015-02-02 13:17 ` Ian Campbell
2014-12-10 22:21 ` [OSSTEST PATCH v4 8/9] make-flight: factor out do_pv_debian_tests Wei Liu
2015-02-02 13:18 ` Ian Campbell
2015-02-02 13:23 ` Ian Campbell
2015-02-02 16:14 ` Wei Liu
2014-12-10 22:21 ` [OSSTEST PATCH v4 9/9] mfi-common, make-flight: create XSM test jobs Wei Liu
2015-02-02 13:20 ` Ian Campbell
2015-02-02 13:22 ` [OSSTEST PATCH v4 0/9] XSM test case for OSSTest Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422888718.19293.44.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.