From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Kukjin Kim <kgene@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH] ARM: EXYNOS: Add missing static to file-scope declarations
Date: Tue, 03 Feb 2015 09:06:13 +0100 [thread overview]
Message-ID: <1422950773.10086.1.camel@AMDC1943> (raw)
In-Reply-To: <06c201d03f67$48da45b0$da8ed110$@kernel.org>
On wto, 2015-02-03 at 13:10 +0900, Kukjin Kim wrote:
> Krzysztof Kozlowski wrote:
> >
> > The 'pm_data', 'exynos_release_ret_regs' and
> > 'exynos5420_release_ret_regs' are not exported nor used outside of
> > suspend.c file. Make them static.
> >
> > This fixes following sparse warnings:
> > arch/arm/mach-exynos/suspend.c:83:23: warning: symbol 'pm_data' was not declared. Should it be static?
> > arch/arm/mach-exynos/suspend.c:106:14: warning: symbol 'exynos_release_ret_regs' was not declared.
> > Should it be static?
> > arch/arm/mach-exynos/suspend.c:117:14: warning: symbol 'exynos5420_release_ret_regs' was not declared.
> > Should it be static?
> >
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > ---
> > arch/arm/mach-exynos/suspend.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/arm/mach-exynos/suspend.c b/arch/arm/mach-exynos/suspend.c
> > index 342797b9bf3b..fef091f8e59f 100644
> > --- a/arch/arm/mach-exynos/suspend.c
> > +++ b/arch/arm/mach-exynos/suspend.c
> > @@ -75,7 +75,7 @@ struct exynos_pm_data {
> > int (*cpu_suspend)(unsigned long);
> > };
> >
> > -struct exynos_pm_data *pm_data;
> > +static struct exynos_pm_data *pm_data;
> >
> > static int exynos5420_cpu_state;
> > static unsigned int exynos_pmu_spare3;
> > @@ -98,7 +98,7 @@ static const struct exynos_wkup_irq exynos5250_wkup_irq[] = {
> > { /* sentinel */ },
> > };
> >
> > -unsigned int exynos_release_ret_regs[] = {
> > +static unsigned int exynos_release_ret_regs[] = {
> > S5P_PAD_RET_MAUDIO_OPTION,
> > S5P_PAD_RET_GPIO_OPTION,
> > S5P_PAD_RET_UART_OPTION,
> > @@ -109,7 +109,7 @@ unsigned int exynos_release_ret_regs[] = {
> > REG_TABLE_END,
> > };
> >
> > -unsigned int exynos5420_release_ret_regs[] = {
> > +static unsigned int exynos5420_release_ret_regs[] = {
> > EXYNOS_PAD_RET_DRAM_OPTION,
> > EXYNOS_PAD_RET_MAUDIO_OPTION,
> > EXYNOS_PAD_RET_JTAG_OPTION,
> > --
>
> Looks ok to me, how about re-spin this patch including following?
>
> ...
> +static unsigned int exynos3250_release_ret_regs[] = {
Sure, I'll resend extended version.
Best regards,
Krzysztof
> ...
>
> Thanks,
> Kukjin
WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH] ARM: EXYNOS: Add missing static to file-scope declarations
Date: Tue, 03 Feb 2015 09:06:13 +0100 [thread overview]
Message-ID: <1422950773.10086.1.camel@AMDC1943> (raw)
In-Reply-To: <06c201d03f67$48da45b0$da8ed110$@kernel.org>
On wto, 2015-02-03 at 13:10 +0900, Kukjin Kim wrote:
> Krzysztof Kozlowski wrote:
> >
> > The 'pm_data', 'exynos_release_ret_regs' and
> > 'exynos5420_release_ret_regs' are not exported nor used outside of
> > suspend.c file. Make them static.
> >
> > This fixes following sparse warnings:
> > arch/arm/mach-exynos/suspend.c:83:23: warning: symbol 'pm_data' was not declared. Should it be static?
> > arch/arm/mach-exynos/suspend.c:106:14: warning: symbol 'exynos_release_ret_regs' was not declared.
> > Should it be static?
> > arch/arm/mach-exynos/suspend.c:117:14: warning: symbol 'exynos5420_release_ret_regs' was not declared.
> > Should it be static?
> >
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > ---
> > arch/arm/mach-exynos/suspend.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/arm/mach-exynos/suspend.c b/arch/arm/mach-exynos/suspend.c
> > index 342797b9bf3b..fef091f8e59f 100644
> > --- a/arch/arm/mach-exynos/suspend.c
> > +++ b/arch/arm/mach-exynos/suspend.c
> > @@ -75,7 +75,7 @@ struct exynos_pm_data {
> > int (*cpu_suspend)(unsigned long);
> > };
> >
> > -struct exynos_pm_data *pm_data;
> > +static struct exynos_pm_data *pm_data;
> >
> > static int exynos5420_cpu_state;
> > static unsigned int exynos_pmu_spare3;
> > @@ -98,7 +98,7 @@ static const struct exynos_wkup_irq exynos5250_wkup_irq[] = {
> > { /* sentinel */ },
> > };
> >
> > -unsigned int exynos_release_ret_regs[] = {
> > +static unsigned int exynos_release_ret_regs[] = {
> > S5P_PAD_RET_MAUDIO_OPTION,
> > S5P_PAD_RET_GPIO_OPTION,
> > S5P_PAD_RET_UART_OPTION,
> > @@ -109,7 +109,7 @@ unsigned int exynos_release_ret_regs[] = {
> > REG_TABLE_END,
> > };
> >
> > -unsigned int exynos5420_release_ret_regs[] = {
> > +static unsigned int exynos5420_release_ret_regs[] = {
> > EXYNOS_PAD_RET_DRAM_OPTION,
> > EXYNOS_PAD_RET_MAUDIO_OPTION,
> > EXYNOS_PAD_RET_JTAG_OPTION,
> > --
>
> Looks ok to me, how about re-spin this patch including following?
>
> ...
> +static unsigned int exynos3250_release_ret_regs[] = {
Sure, I'll resend extended version.
Best regards,
Krzysztof
> ...
>
> Thanks,
> Kukjin
next prev parent reply other threads:[~2015-02-03 8:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-09 16:04 [RESEND PATCH] ARM: EXYNOS: Add missing static to file-scope declarations Krzysztof Kozlowski
2015-01-09 16:04 ` Krzysztof Kozlowski
2015-02-03 4:10 ` Kukjin Kim
2015-02-03 4:10 ` Kukjin Kim
2015-02-03 8:06 ` Krzysztof Kozlowski [this message]
2015-02-03 8:06 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422950773.10086.1.camel@AMDC1943 \
--to=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.