From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Pankaj Dubey <pankaj.dubey@samsung.com>
Cc: Russell King <linux@arm.linux.org.uk>,
Kukjin Kim <kgene@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [v2,3/3] ARM: EXYNOS: Remove left over 'extra_save'
Date: Thu, 05 Feb 2015 08:14:46 +0100 [thread overview]
Message-ID: <1423120486.29408.2.camel@AMDC1943> (raw)
In-Reply-To: <54D2F646.3090306@samsung.com>
On czw, 2015-02-05 at 10:19 +0530, Pankaj Dubey wrote:
> Hi Krzysztof,
>
> On Tuesday 03 February 2015 04:36 PM, Krzysztof Kozlowski wrote:
> > Since 32b0aa9aaeb4 ("ARM: EXYNOS: Remove i2c sys configuration related
> > code") the Exynos 5250 no longer saves additional registers under
> > 'exynos_pm_data.extra_save' field.
> >
> > No one else uses this code so get rid of it making also 'exynos_pm_data'
> > const everywhere.
> >
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> >
> > ---
> > Changes since v1:
> > 1. New patch.
> > ---
> > arch/arm/mach-exynos/suspend.c | 13 ++-----------
> > 1 file changed, 2 insertions(+), 11 deletions(-)
> >
> > diff --git a/arch/arm/mach-exynos/suspend.c b/arch/arm/mach-exynos/suspend.c
> > index e6c961126087..d56bd6ca5e86 100644
> > --- a/arch/arm/mach-exynos/suspend.c
> > +++ b/arch/arm/mach-exynos/suspend.c
> > @@ -63,7 +63,6 @@ static struct sleep_save exynos_core_save[] = {
> >
> > struct exynos_pm_data {
> > const struct exynos_wkup_irq *wkup_irq;
> > - struct sleep_save *extra_save;
> > int num_extra_save;
>
> 'num_extra_save' can be removed at the same time.
>
> Rest changes looks ok.
Right, thanks for pointing this out. I'll resend the patchset.
Best regards,
Krzysztof
>
> Thanks,
> Pankaj Dubey
WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [v2,3/3] ARM: EXYNOS: Remove left over 'extra_save'
Date: Thu, 05 Feb 2015 08:14:46 +0100 [thread overview]
Message-ID: <1423120486.29408.2.camel@AMDC1943> (raw)
In-Reply-To: <54D2F646.3090306@samsung.com>
On czw, 2015-02-05 at 10:19 +0530, Pankaj Dubey wrote:
> Hi Krzysztof,
>
> On Tuesday 03 February 2015 04:36 PM, Krzysztof Kozlowski wrote:
> > Since 32b0aa9aaeb4 ("ARM: EXYNOS: Remove i2c sys configuration related
> > code") the Exynos 5250 no longer saves additional registers under
> > 'exynos_pm_data.extra_save' field.
> >
> > No one else uses this code so get rid of it making also 'exynos_pm_data'
> > const everywhere.
> >
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> >
> > ---
> > Changes since v1:
> > 1. New patch.
> > ---
> > arch/arm/mach-exynos/suspend.c | 13 ++-----------
> > 1 file changed, 2 insertions(+), 11 deletions(-)
> >
> > diff --git a/arch/arm/mach-exynos/suspend.c b/arch/arm/mach-exynos/suspend.c
> > index e6c961126087..d56bd6ca5e86 100644
> > --- a/arch/arm/mach-exynos/suspend.c
> > +++ b/arch/arm/mach-exynos/suspend.c
> > @@ -63,7 +63,6 @@ static struct sleep_save exynos_core_save[] = {
> >
> > struct exynos_pm_data {
> > const struct exynos_wkup_irq *wkup_irq;
> > - struct sleep_save *extra_save;
> > int num_extra_save;
>
> 'num_extra_save' can be removed at the same time.
>
> Rest changes looks ok.
Right, thanks for pointing this out. I'll resend the patchset.
Best regards,
Krzysztof
>
> Thanks,
> Pankaj Dubey
next prev parent reply other threads:[~2015-02-05 7:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-03 11:06 [PATCH v2 1/3] ARM: EXYNOS: Add missing static to file-scope declarations Krzysztof Kozlowski
2015-02-03 11:06 ` Krzysztof Kozlowski
2015-02-03 11:06 ` [PATCH v2 2/3] ARM: EXYNOS: Constify exynos_pm_data and of_device_id array Krzysztof Kozlowski
2015-02-03 11:06 ` Krzysztof Kozlowski
2015-02-05 4:56 ` [v2,2/3] " Pankaj Dubey
2015-02-05 4:56 ` Pankaj Dubey
2015-02-03 11:06 ` [PATCH v2 3/3] ARM: EXYNOS: Remove left over 'extra_save' Krzysztof Kozlowski
2015-02-03 11:06 ` Krzysztof Kozlowski
2015-02-05 4:49 ` [v2,3/3] " Pankaj Dubey
2015-02-05 4:49 ` Pankaj Dubey
2015-02-05 7:14 ` Krzysztof Kozlowski [this message]
2015-02-05 7:14 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423120486.29408.2.camel@AMDC1943 \
--to=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=pankaj.dubey@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.