From: Ian Campbell <Ian.Campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Jan Beulich <JBeulich@suse.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH] libvchan: address compiler warnings
Date: Thu, 5 Feb 2015 12:47:40 +0000 [thread overview]
Message-ID: <1423140460.24924.107.camel@citrix.com> (raw)
In-Reply-To: <20150204162636.GA4311@zion.uk.xensource.com>
On Wed, 2015-02-04 at 16:26 +0000, Wei Liu wrote:
> On Wed, Feb 04, 2015 at 04:07:48PM +0000, Jan Beulich wrote:
> > Both vchan_wr() and stdout_wr() should be defined with a non-empty
> > argument list (i.e. void). Additionally both of them as well as usage()
> > should be static to make clear that no other code is referencing them.
> >
> > Further, statements should follow declarations.
> >
> > Signed-off-by: Jan Beulich <jbeulich@suse.com>
> >
>
> Acked-by: Wei Liu <wei.liu2@citrix.com>
Me too, plus applied. Thanks.
Ian.
prev parent reply other threads:[~2015-02-05 12:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-04 16:07 [PATCH] libvchan: address compiler warnings Jan Beulich
2015-02-04 16:26 ` Wei Liu
2015-02-05 12:47 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423140460.24924.107.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.