All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Stewart Smith <stewart@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/18] powerpc/powernv: s/OPAL_PCI_SET_PHB_CXL_MODE/OPAL_PCI_SET_PHB_CAPI_MODE/ to match firmware
Date: Tue, 10 Feb 2015 14:39:32 +1100	[thread overview]
Message-ID: <1423539572.4924.80.camel@kernel.crashing.org> (raw)
In-Reply-To: <1423535220-6322-4-git-send-email-stewart@linux.vnet.ibm.com>

On Tue, 2015-02-10 at 13:26 +1100, Stewart Smith wrote:
> --- a/arch/powerpc/platforms/powernv/pci-ioda.c
> +++ b/arch/powerpc/platforms/powernv/pci-ioda.c
> @@ -1481,9 +1481,9 @@ int pnv_phb_to_cxl(struct pci_dev *dev)
>  
>         pe_info(pe, "Switching PHB to CXL\n");
>  
> -       rc = opal_pci_set_phb_cxl_mode(phb->opal_id, 1, pe->pe_number);
> +       rc = opal_pci_set_phb_capi_mode(phb->opal_id, 1, pe->pe_number);
>         if (rc)
> -               dev_err(&dev->dev, "opal_pci_set_phb_cxl_mode failed: %i\n", rc);
> +               dev_err(&dev->dev, "opal_pci_set_phb_capi_mode failed: %i\n", rc);
>  
>         return rc;
>  }

Add a comment above the call: /* CAPI is the IBM/Firmware name for "CXL" */

Cheers,
Ben.

WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Stewart Smith <stewart@linux.vnet.ibm.com>
Cc: mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/18] powerpc/powernv: s/OPAL_PCI_SET_PHB_CXL_MODE/OPAL_PCI_SET_PHB_CAPI_MODE/ to match firmware
Date: Tue, 10 Feb 2015 14:39:32 +1100	[thread overview]
Message-ID: <1423539572.4924.80.camel@kernel.crashing.org> (raw)
In-Reply-To: <1423535220-6322-4-git-send-email-stewart@linux.vnet.ibm.com>

On Tue, 2015-02-10 at 13:26 +1100, Stewart Smith wrote:
> --- a/arch/powerpc/platforms/powernv/pci-ioda.c
> +++ b/arch/powerpc/platforms/powernv/pci-ioda.c
> @@ -1481,9 +1481,9 @@ int pnv_phb_to_cxl(struct pci_dev *dev)
>  
>         pe_info(pe, "Switching PHB to CXL\n");
>  
> -       rc = opal_pci_set_phb_cxl_mode(phb->opal_id, 1, pe->pe_number);
> +       rc = opal_pci_set_phb_capi_mode(phb->opal_id, 1, pe->pe_number);
>         if (rc)
> -               dev_err(&dev->dev, "opal_pci_set_phb_cxl_mode failed: %i\n", rc);
> +               dev_err(&dev->dev, "opal_pci_set_phb_capi_mode failed: %i\n", rc);
>  
>         return rc;
>  }

Add a comment above the call: /* CAPI is the IBM/Firmware name for "CXL" */

Cheers,
Ben.



  reply	other threads:[~2015-02-10  3:39 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-10  2:26 [PATCH 00/18] sync opal.h with firmware Stewart Smith
2015-02-10  2:26 ` Stewart Smith
2015-02-10  2:26 ` [PATCH 01/18] powerpc/powernv: sync OPAL API tokens with skiboot Stewart Smith
2015-02-10  2:26   ` Stewart Smith
2015-02-10  2:26 ` [PATCH 02/18] powerpc/powernv: synchronize OPAL calls and return codes with firmware Stewart Smith
2015-02-10  2:26   ` Stewart Smith
2015-02-10  2:26 ` [PATCH 03/18] powerpc/powernv: s/OPAL_PCI_SET_PHB_CXL_MODE/OPAL_PCI_SET_PHB_CAPI_MODE/ to match firmware Stewart Smith
2015-02-10  2:26   ` Stewart Smith
2015-02-10  3:39   ` Benjamin Herrenschmidt [this message]
2015-02-10  3:39     ` Benjamin Herrenschmidt
2015-02-10  2:26 ` [PATCH 04/18] powerpc/powernv: relocate struct opal_sg_entry in opal.h to same place it is in firmware Stewart Smith
2015-02-10  2:26   ` Stewart Smith
2015-02-10  2:26 ` [PATCH 05/18] powerpc/powernv: synchronize opal.h whitespace with firmware Stewart Smith
2015-02-10  2:26   ` Stewart Smith
2015-02-10  2:26 ` [PATCH 06/18] powerpc/powernv: move OPAL_DUMP_REGION defines in opal.h to same place as in firmware opal.h Stewart Smith
2015-02-10  2:26   ` Stewart Smith
2015-02-10  2:26 ` [PATCH 07/18] powerpc/powernv: make whitespace for OPAL_PM_* defines match firmware Stewart Smith
2015-02-10  2:26   ` Stewart Smith
2015-02-10  2:26 ` [PATCH 08/18] powerpc/powernv: Move OpalSysparamPerm, OpalMessageType in opal.h to " Stewart Smith
2015-02-10  2:26   ` [PATCH 08/18] powerpc/powernv: Move OpalSysparamPerm,OpalMessageType " Stewart Smith
2015-02-10  2:26 ` [PATCH 09/18] powerpc/powernv: match enum OpalMessageType with firmware Stewart Smith
2015-02-10  2:26   ` Stewart Smith
2015-02-10  2:26 ` [PATCH 10/18] powerpc/powernv: move OPAL API prototypes to opal-api.h Stewart Smith
2015-02-10  2:26   ` Stewart Smith
2015-02-10  2:26 ` [PATCH 11/18] powerpc/powernv: make whitespace in enum OpalSysparamPerm match firmware Stewart Smith
2015-02-10  2:26   ` Stewart Smith
2015-02-10  2:26 ` [PATCH 12/18] powerpc/powernv: add CAPI and EPOW parts to opal.h Stewart Smith
2015-02-10  2:26   ` Stewart Smith
2015-02-10  2:26 ` [PATCH 13/18] powerpc/powernv: add remaining missing enums " Stewart Smith
2015-02-10  2:26   ` Stewart Smith
2015-02-10  2:26 ` [PATCH 14/18] powerpc/powernv: sync comments and whitespace in opal.h with firmware Stewart Smith
2015-02-10  2:26   ` Stewart Smith
2015-02-10  2:26 ` [PATCH 15/18] powerpc/powernv: sync #includes " Stewart Smith
2015-02-10  2:26   ` Stewart Smith
2015-02-10  2:26 ` [PATCH 16/18] powerpc/powernv: move SG_ENTRIES_PER_NODE to linux-specific opal-api.h Stewart Smith
2015-02-10  2:26   ` Stewart Smith
2015-02-10  2:26 ` [PATCH 17/18] powerpc/powernv: s/u8/uint8_t/ to match firmware in opal.h Stewart Smith
2015-02-10  2:26   ` Stewart Smith
2015-02-10  2:27 ` [PATCH 18/18] powerpc/powernv: s/OpalM64EnableAction/OpalM64Action/ and __be64 annotation Stewart Smith
2015-02-10  2:27   ` Stewart Smith
2015-02-10  3:59 ` [PATCH 00/18] sync opal.h with firmware Michael Ellerman
2015-02-10  3:59   ` Michael Ellerman
2015-02-10  5:10   ` Stewart Smith
2015-02-10  5:10     ` Stewart Smith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1423539572.4924.80.camel@kernel.crashing.org \
    --to=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=stewart@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.