All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Julien Grall <julien.grall@linaro.org>
Cc: stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org
Subject: Re: [PATCH v2 3/9] xen: arm: Handle 32-bit EL0 on 64-bit EL1 when advancing PC after trap
Date: Tue, 10 Feb 2015 06:20:06 +0000	[thread overview]
Message-ID: <1423549206.5851.12.camel@citrix.com> (raw)
In-Reply-To: <54D99AA8.4050608@linaro.org>

On Tue, 2015-02-10 at 13:44 +0800, Julien Grall wrote:
> >           /* The cond for this instruction works out as the top 4 bits. */
> > -        cond =  ( it >> 4 );
> > +        cond = ( it >> 4 );
> 
> I haven't spot it in the previous review. This seems to be only a coding 
> change. Could you specify it in the commit message?

Sigh, this level of pedantry isn't really helpful IMHO.

Ian.

  reply	other threads:[~2015-02-10  6:20 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-10  4:35 [PATCH v2 0/9] xen: arm: reenable support for 32-bit userspace running in 64-bit guest Ian Campbell
2015-02-10  4:45 ` [PATCH v2 1/9] xen: arm: Correct PMXEV cp register definitions Ian Campbell
2015-02-10  4:45 ` [PATCH v2 2/9] xen: arm: Factor out psr_mode_is_user Ian Campbell
2015-02-10  4:45 ` [PATCH v2 3/9] xen: arm: Handle 32-bit EL0 on 64-bit EL1 when advancing PC after trap Ian Campbell
2015-02-10  5:44   ` Julien Grall
2015-02-10  6:20     ` Ian Campbell [this message]
2015-02-10  4:45 ` [PATCH v2 4/9] xen: arm: correctly handle vtimer traps from userspace Ian Campbell
2015-02-10  6:41   ` Julien Grall
2015-02-19 12:10     ` Ian Campbell
2015-02-19 14:42       ` Julien Grall
2015-02-19 15:13         ` Ian Campbell
2015-02-25 14:32           ` Ian Campbell
2015-02-25 14:37             ` Julien Grall
2015-02-10  4:45 ` [PATCH v2 5/9] xen: arm: Handle CP15 register " Ian Campbell
2015-02-17 15:07   ` Julien Grall
2015-02-19 12:15     ` Ian Campbell
2015-02-19 14:53       ` Julien Grall
2015-02-19 15:07         ` Ian Campbell
2015-02-10  4:45 ` [PATCH v2 6/9] xen: arm: Handle CP14 32-bit register accesses " Ian Campbell
2015-02-17 15:20   ` Julien Grall
2015-02-10  4:45 ` [PATCH v2 7/9] xen: arm: correctly handle sysreg " Ian Campbell
2015-02-17 15:25   ` Julien Grall
2015-02-19 12:23     ` Ian Campbell
2015-02-19 14:55       ` Julien Grall
2015-02-10  4:45 ` [PATCH v2 8/9] xen: arm: handle remaining traps " Ian Campbell
2015-02-17 15:28   ` Julien Grall
2015-02-19 12:25     ` Ian Campbell
2015-02-10  4:45 ` [PATCH v2 9/9] xen: arm: Allow traps from 32 bit userspace on 64 bit hypervisors again Ian Campbell
2015-02-17 15:29   ` Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1423549206.5851.12.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=julien.grall@linaro.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.