All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
To: Stefan Wahren <stefan.wahren-eS4NqCHxEME@public.gmane.org>
Cc: "H. Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>,
	Linus Walleij
	<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Dmitry Eremin-Solenikov
	<dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Support Opensource
	<support.opensource-WBD+wuPFNBhBDgjK7y7TUQ@public.gmane.org>,
	Darren Hart <dvhart-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
	Robert Jarzmik <robert.jarzmik-GANU6spQydw@public.gmane.org>,
	linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	ac100-oU9gvf+ajcQ97yFScArB1dHuzzzSOjJt@public.gmane.org,
	Cezary Jackiewicz
	<cezary.jackiewicz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
	patches-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org,
	Milo Kim <milo.kim-l0cyMroinI0@public.gmane.org>,
	David Herrmann
	<dh.herrmann-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>,
	devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org,
	Len Brown <lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Ingo Molnar <mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"Rafael J. Wysocki" <rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org>,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Daniel Mack <daniel-cYrQPVfZoowdnm+yROfE0A@public.gmane.org>,
	platform-driver-x86-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Sebastian
Subject: Re: [PATCH v3 04/20] power_supply: sysfs: Use power_supply_*() API for accessing function attrs
Date: Tue, 10 Feb 2015 08:39:19 +0100	[thread overview]
Message-ID: <1423553959.1327.1.camel@AMDC1943> (raw)
In-Reply-To: <70066540.345820.1423508541546.JavaMail.open-xchange-h4m1HHXQYNHZ78VGacPtK8gmgJlYmuWJ@public.gmane.org>

On pon, 2015-02-09 at 20:02 +0100, Stefan Wahren wrote:
> Hi Krzysztof,
> 
> > Krzysztof Kozlowski <k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> hat am 30. Januar 2015 um 15:47
> > geschrieben:
> >
> >
> > Replace direct calls to power supply function attributes with wrappers.
> > Wrappers provide safe access in case of unregistering the power
> > supply (e.g. by removing the driver). Replace:
> > - get_property -> power_supply_get_property
> > - set_property -> power_supply_set_property
> > - property_is_writeable -> power_supply_property_is_writeable
> >
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> > Acked-by: Jonghwa Lee <jonghwa3.lee-Ns6yrYG9TJBBDgjK7y7TUQ@public.gmane.org>
> 
> just a nit. It looks like a typo in the mail address which is also in patch 5 -
> 10.

Right, I copied it directly from Jonghwa's response. Thank you for
noticing it.

> 
> I applied patch 1 - 14 to my repo with a upcoming power driver (mxs_power) and
> didn't see any problems with your patches.

Great, thanks!

Best regards,
Krzysztof

WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 04/20] power_supply: sysfs: Use power_supply_*() API for accessing function attrs
Date: Tue, 10 Feb 2015 08:39:19 +0100	[thread overview]
Message-ID: <1423553959.1327.1.camel@AMDC1943> (raw)
In-Reply-To: <70066540.345820.1423508541546.JavaMail.open-xchange@oxbaltgw00.schlund.de>

On pon, 2015-02-09 at 20:02 +0100, Stefan Wahren wrote:
> Hi Krzysztof,
> 
> > Krzysztof Kozlowski <k.kozlowski@samsung.com> hat am 30. Januar 2015 um 15:47
> > geschrieben:
> >
> >
> > Replace direct calls to power supply function attributes with wrappers.
> > Wrappers provide safe access in case of unregistering the power
> > supply (e.g. by removing the driver). Replace:
> > - get_property -> power_supply_get_property
> > - set_property -> power_supply_set_property
> > - property_is_writeable -> power_supply_property_is_writeable
> >
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > Acked-by: Jonghwa Lee <jonghwa3.lee@samusng.com>
> 
> just a nit. It looks like a typo in the mail address which is also in patch 5 -
> 10.

Right, I copied it directly from Jonghwa's response. Thank you for
noticing it.

> 
> I applied patch 1 - 14 to my repo with a upcoming power driver (mxs_power) and
> didn't see any problems with your patches.

Great, thanks!

Best regards,
Krzysztof

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Stefan Wahren <stefan.wahren@i2se.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
	Support Opensource <support.opensource@diasemi.com>,
	Darren Hart <dvhart@infradead.org>,
	Robert Jarzmik <robert.jarzmik@free.fr>,
	linux-pm@vger.kernel.org, Samuel Ortiz <sameo@linux.intel.com>,
	Lee Jones <lee.jones@linaro.org>,
	ac100@lists.launchpad.net,
	Cezary Jackiewicz <cezary.jackiewicz@gmail.com>,
	Russell King <linux@arm.linux.org.uk>,
	patches@opensource.wolfsonmicro.com, Milo Kim <milo.kim@ti.com>,
	David Herrmann <dh.herrmann@googlemail.com>,
	devel@driverdev.osuosl.org, Len Brown <lenb@kernel.org>,
	linux-acpi@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
	linux-input@vger.kernel.org,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	linux-tegra@vger.kernel.org, Daniel Mack <daniel@zonque.org>,
	platform-driver-x86@vger.kernel.org,
	Sebastian Reichel <sre@kernel.org>,
	Julian Andres Klode <jak@jak-linux.org>,
	linux-arm-kernel@lists.infradead.org,
	Marc Dietrich <marvin24@gmx.de>,
	David Woodhouse <dwmw2@infradead.org>,
	Jiri Kosina <jkosina@suse.cz>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, x86@kernel.org,
	Haojian Zhuang <haojian.zhuang@gmail.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Pavel Machek <pavel@ucw.cz>, Thomas Gleixner <tglx@linutronix.de>,
	Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH v3 04/20] power_supply: sysfs: Use power_supply_*() API for accessing function attrs
Date: Tue, 10 Feb 2015 08:39:19 +0100	[thread overview]
Message-ID: <1423553959.1327.1.camel@AMDC1943> (raw)
In-Reply-To: <70066540.345820.1423508541546.JavaMail.open-xchange@oxbaltgw00.schlund.de>

On pon, 2015-02-09 at 20:02 +0100, Stefan Wahren wrote:
> Hi Krzysztof,
> 
> > Krzysztof Kozlowski <k.kozlowski@samsung.com> hat am 30. Januar 2015 um 15:47
> > geschrieben:
> >
> >
> > Replace direct calls to power supply function attributes with wrappers.
> > Wrappers provide safe access in case of unregistering the power
> > supply (e.g. by removing the driver). Replace:
> > - get_property -> power_supply_get_property
> > - set_property -> power_supply_set_property
> > - property_is_writeable -> power_supply_property_is_writeable
> >
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > Acked-by: Jonghwa Lee <jonghwa3.lee@samusng.com>
> 
> just a nit. It looks like a typo in the mail address which is also in patch 5 -
> 10.

Right, I copied it directly from Jonghwa's response. Thank you for
noticing it.

> 
> I applied patch 1 - 14 to my repo with a upcoming power driver (mxs_power) and
> didn't see any problems with your patches.

Great, thanks!

Best regards,
Krzysztof



  parent reply	other threads:[~2015-02-10  7:39 UTC|newest]

Thread overview: 95+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-30 14:47 [PATCH v3 00/20] power_supply: Allow safe usage of power supply Krzysztof Kozlowski
2015-01-30 14:47 ` Krzysztof Kozlowski
2015-01-30 14:47 ` Krzysztof Kozlowski
2015-01-30 14:47 ` [PATCH v3 01/20] power_supply: Add driver private data Krzysztof Kozlowski
2015-01-30 14:47   ` Krzysztof Kozlowski
2015-01-30 14:47   ` Krzysztof Kozlowski
2015-01-30 14:47 ` [PATCH v3 03/20] power_supply: Add API for safe access of power supply function attrs Krzysztof Kozlowski
2015-01-30 14:47   ` Krzysztof Kozlowski
2015-01-30 14:47   ` Krzysztof Kozlowski
2015-02-04 13:44   ` Pavel Machek
2015-02-04 13:44     ` Pavel Machek
2015-02-04 13:44     ` Pavel Machek
2015-01-30 14:47 ` [PATCH v3 04/20] power_supply: sysfs: Use power_supply_*() API for accessing " Krzysztof Kozlowski
2015-01-30 14:47   ` Krzysztof Kozlowski
2015-01-30 14:47   ` Krzysztof Kozlowski
2015-02-09 19:02   ` Stefan Wahren
2015-02-09 19:02     ` Stefan Wahren
2015-02-09 19:02     ` Stefan Wahren
     [not found]     ` <70066540.345820.1423508541546.JavaMail.open-xchange-h4m1HHXQYNHZ78VGacPtK8gmgJlYmuWJ@public.gmane.org>
2015-02-10  7:39       ` Krzysztof Kozlowski [this message]
2015-02-10  7:39         ` Krzysztof Kozlowski
2015-02-10  7:39         ` Krzysztof Kozlowski
2015-01-30 14:47 ` [PATCH v3 05/20] power_supply: 88pm860x_charger: " Krzysztof Kozlowski
2015-01-30 14:47   ` Krzysztof Kozlowski
2015-01-30 14:47   ` Krzysztof Kozlowski
2015-01-30 14:47 ` [PATCH v3 06/20] power_supply: ab8500: " Krzysztof Kozlowski
2015-01-30 14:47   ` Krzysztof Kozlowski
2015-01-30 14:47   ` Krzysztof Kozlowski
2015-01-30 14:47 ` [PATCH v3 07/20] mfd: " Krzysztof Kozlowski
2015-01-30 14:47   ` Krzysztof Kozlowski
2015-01-30 14:47   ` Krzysztof Kozlowski
2015-01-30 14:47 ` [PATCH v3 08/20] power_supply: apm_power: " Krzysztof Kozlowski
2015-01-30 14:47   ` Krzysztof Kozlowski
2015-01-30 14:47   ` Krzysztof Kozlowski
2015-01-30 14:47 ` [PATCH v3 09/20] power_supply: bq2415x_charger: " Krzysztof Kozlowski
2015-01-30 14:47   ` Krzysztof Kozlowski
2015-01-30 14:47   ` Krzysztof Kozlowski
2015-01-30 14:47 ` [PATCH v3 10/20] power_supply: charger-manager: " Krzysztof Kozlowski
2015-01-30 14:47   ` Krzysztof Kozlowski
2015-01-30 14:47   ` Krzysztof Kozlowski
2015-01-30 14:47 ` [PATCH v3 11/20] power_supply: Change ownership from driver to core Krzysztof Kozlowski
2015-01-30 14:47   ` Krzysztof Kozlowski
2015-01-30 14:47 ` [PATCH v3 12/20] power_supply: Add power_supply_put for decrementing device reference counter Krzysztof Kozlowski
2015-01-30 14:47   ` Krzysztof Kozlowski
2015-01-30 14:47   ` Krzysztof Kozlowski
2015-01-30 14:47 ` [PATCH v3 13/20] power_supply: Increment power supply use counter when obtaining references Krzysztof Kozlowski
2015-01-30 14:47   ` Krzysztof Kozlowski
2015-01-30 14:47   ` Krzysztof Kozlowski
2015-01-30 14:47 ` [PATCH v3 14/20] power_supply: charger-manager: Decrement the power supply's device reference counter Krzysztof Kozlowski
2015-01-30 14:47   ` Krzysztof Kozlowski
2015-01-30 14:47   ` Krzysztof Kozlowski
2015-01-30 14:47 ` [PATCH v3 15/20] x86/olpc/xo1/sci: Use newly added power_supply_put API Krzysztof Kozlowski
2015-01-30 14:47   ` Krzysztof Kozlowski
2015-01-30 14:47   ` Krzysztof Kozlowski
2015-01-30 14:47 ` [PATCH v3 16/20] x86/olpc/xo15/sci: " Krzysztof Kozlowski
2015-01-30 14:47   ` Krzysztof Kozlowski
2015-01-30 14:47   ` Krzysztof Kozlowski
     [not found] ` <1422629278-12202-1-git-send-email-k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-01-30 14:47   ` [PATCH v3 02/20] power_supply: Move run-time configuration to separate structure Krzysztof Kozlowski
2015-01-30 14:47     ` Krzysztof Kozlowski
2015-01-30 14:47     ` Krzysztof Kozlowski
2015-02-07  2:19     ` Darren Hart
2015-02-07  2:19       ` Darren Hart
2015-02-07  2:19       ` Darren Hart
2015-01-30 14:47   ` [PATCH v3 17/20] power_supply: 88pm860x_charger: Decrement the power supply's device reference counter Krzysztof Kozlowski
2015-01-30 14:47     ` Krzysztof Kozlowski
2015-01-30 14:47     ` Krzysztof Kozlowski
2015-02-02  8:58   ` [PATCH v3 00/20] power_supply: Allow safe usage of power supply Marc Dietrich
2015-02-02  8:58     ` Marc Dietrich
2015-02-02  8:58     ` Marc Dietrich
2015-01-30 14:47 ` [PATCH v3 18/20] power_supply: bq2415x_charger: Decrement the power supply's device reference counter Krzysztof Kozlowski
2015-01-30 14:47   ` Krzysztof Kozlowski
2015-01-30 14:47   ` Krzysztof Kozlowski
2015-01-30 14:47 ` [PATCH v3 19/20] mfd: ab8500: " Krzysztof Kozlowski
2015-01-30 14:47   ` Krzysztof Kozlowski
2015-01-30 14:47   ` Krzysztof Kozlowski
2015-01-30 14:47 ` [PATCH v3 20/20] arm: mach-pxa: " Krzysztof Kozlowski
2015-01-30 14:47   ` Krzysztof Kozlowski
2015-01-30 14:47   ` Krzysztof Kozlowski
2015-02-06 13:49   ` Pavel Machek
2015-02-06 13:49     ` Pavel Machek
2015-02-06 13:49     ` Pavel Machek
2015-02-06 14:43     ` Krzysztof Kozlowski
2015-02-06 14:43       ` Krzysztof Kozlowski
2015-02-06 14:43       ` Krzysztof Kozlowski
2015-02-06 14:59       ` Pavel Machek
2015-02-06 14:59         ` Pavel Machek
2015-02-06 14:59         ` Pavel Machek
2015-02-09 10:07         ` Krzysztof Kozlowski
2015-02-09 10:07           ` Krzysztof Kozlowski
2015-02-09 10:07           ` Krzysztof Kozlowski
2015-02-11 22:12           ` Pavel Machek
2015-02-11 22:12             ` Pavel Machek
2015-02-11 22:12             ` Pavel Machek
2015-02-07 12:54   ` Robert Jarzmik
2015-02-07 12:54     ` Robert Jarzmik
2015-02-07 12:54     ` Robert Jarzmik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1423553959.1327.1.camel@AMDC1943 \
    --to=k.kozlowski-sze3o3uu22jbdgjk7y7tuq@public.gmane.org \
    --cc=ac100-oU9gvf+ajcQ97yFScArB1dHuzzzSOjJt@public.gmane.org \
    --cc=cezary.jackiewicz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=daniel-cYrQPVfZoowdnm+yROfE0A@public.gmane.org \
    --cc=dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org \
    --cc=dh.herrmann-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org \
    --cc=dvhart-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
    --cc=lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
    --cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=milo.kim-l0cyMroinI0@public.gmane.org \
    --cc=mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=patches-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
    --cc=platform-driver-x86-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org \
    --cc=robert.jarzmik-GANU6spQydw@public.gmane.org \
    --cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=stefan.wahren-eS4NqCHxEME@public.gmane.org \
    --cc=support.opensource-WBD+wuPFNBhBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.