From: Trond Myklebust <trond.myklebust@primarydata.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Anna Schumaker <anna.schumaker@netapp.com>,
linux-nfs@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] pnfs: delete an unintended goto
Date: Tue, 10 Feb 2015 13:42:36 +0000 [thread overview]
Message-ID: <1423575756.4226.0.camel@primarydata.com> (raw)
In-Reply-To: <20150210080322.GA8762@mwanda>
On Tue, 2015-02-10 at 11:03 +0300, Dan Carpenter wrote:
> There was an extra goto here where it shouldn't be, because of a merge
> error.
>
> Fixes: e2c63e091e29 ('Merge branch 'flexfiles'')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/fs/nfs/pnfs.c b/fs/nfs/pnfs.c
> index 107b321..4f802b02 100644
> --- a/fs/nfs/pnfs.c
> +++ b/fs/nfs/pnfs.c
> @@ -1078,7 +1078,6 @@ bool pnfs_roc(struct inode *ino)
> goto out_noroc;
> }
>
> - goto out_noroc;
> pnfs_clear_retry_layoutget(lo);
> list_for_each_entry_safe(lseg, tmp, &lo->plh_segs, pls_list)
> if (test_bit(NFS_LSEG_ROC, &lseg->pls_flags)) {
Thanks Dan! Applied to linux-next.
Cheers
Trond
--
Trond Myklebust
Linux NFS client maintainer, PrimaryData
trond.myklebust@primarydata.com
WARNING: multiple messages have this Message-ID (diff)
From: Trond Myklebust <trond.myklebust@primarydata.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Anna Schumaker <anna.schumaker@netapp.com>,
linux-nfs@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] pnfs: delete an unintended goto
Date: Tue, 10 Feb 2015 08:42:36 -0500 [thread overview]
Message-ID: <1423575756.4226.0.camel@primarydata.com> (raw)
In-Reply-To: <20150210080322.GA8762@mwanda>
On Tue, 2015-02-10 at 11:03 +0300, Dan Carpenter wrote:
> There was an extra goto here where it shouldn't be, because of a merge
> error.
>
> Fixes: e2c63e091e29 ('Merge branch 'flexfiles'')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/fs/nfs/pnfs.c b/fs/nfs/pnfs.c
> index 107b321..4f802b02 100644
> --- a/fs/nfs/pnfs.c
> +++ b/fs/nfs/pnfs.c
> @@ -1078,7 +1078,6 @@ bool pnfs_roc(struct inode *ino)
> goto out_noroc;
> }
>
> - goto out_noroc;
> pnfs_clear_retry_layoutget(lo);
> list_for_each_entry_safe(lseg, tmp, &lo->plh_segs, pls_list)
> if (test_bit(NFS_LSEG_ROC, &lseg->pls_flags)) {
Thanks Dan! Applied to linux-next.
Cheers
Trond
--
Trond Myklebust
Linux NFS client maintainer, PrimaryData
trond.myklebust@primarydata.com
next prev parent reply other threads:[~2015-02-10 13:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-10 8:03 [patch] pnfs: delete an unintended goto Dan Carpenter
2015-02-10 8:03 ` Dan Carpenter
2015-02-10 13:42 ` Trond Myklebust [this message]
2015-02-10 13:42 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423575756.4226.0.camel@primarydata.com \
--to=trond.myklebust@primarydata.com \
--cc=anna.schumaker@netapp.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.