All of lore.kernel.org
 help / color / mirror / Atom feed
From: florian@openwrt.org (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: Overriding/concatenating kernel command-line with bootargs from dtb?
Date: Mon, 11 Jun 2012 19:51:30 +0200	[thread overview]
Message-ID: <1424241.AIpjaKT9XL@bender> (raw)
In-Reply-To: <4FD601F9.8020201@gmail.com>

Hi Rob,

On Monday 11 June 2012 09:34:33 Rob Herring wrote:
> On 06/08/2012 02:55 AM, Florian Fainelli wrote:
> > Hi all,
> > 
> > I have a specific use case, where two boards using the same SoC have 
different 
> > UART speeds, which is something that I have specified in their 
corresponding 
> > dts files. In order to make sure people don't mess up the configuration, I 
> > prefer not to rely on the bootloader-supplied kernel-command line.
> > 
> > I was kind of expecting that ARM_ATAG_DTB_COMPAT + CMDLINE_EXTEND would 
> > actually concatenate the kernel command-line with the bootargs provided 
from 
> > dtb.
> > 
> > Is this something someone else would need? If so, shall we just make that 
> > happen when the two config symbols mentionned above are enabled, or shall 
we 
> > introduce a 4th kernel command line handling strategy?
> > 
> > Thank you for your answers.
> 
> There was a patch to do this:
> 
> http://www.mail-archive.com/devicetree-
discuss at lists.ozlabs.org/msg10448.html
> 
> Please comment if this works for you.

This patch indeeds work fine for me when I disable ARM_ATAG_DTB_COMPAT. If I 
let it turned on the chosen node is correctly scanned, but its value, is the 
one coming from tag_cmdline() which is actually the bootloader supplied 
commad-line. I will cook up a patch for this, because I expect the 3 command-
lines to be concatened in the end (built-in, atag and dtb).

I don't see any comments from Ben or anyone after Doug sent his version 2 of 
the patch, is there any reason not to merge it?
-- 
Florian

WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <florian@openwrt.org>
To: Rob Herring <robherring2@gmail.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	device-tree <devicetree-discuss@lists.ozlabs.org>,
	linux-arm <linux-arm-kernel@lists.infradead.org>
Subject: Re: Overriding/concatenating kernel command-line with bootargs from dtb?
Date: Mon, 11 Jun 2012 19:51:30 +0200	[thread overview]
Message-ID: <1424241.AIpjaKT9XL@bender> (raw)
In-Reply-To: <4FD601F9.8020201@gmail.com>

Hi Rob,

On Monday 11 June 2012 09:34:33 Rob Herring wrote:
> On 06/08/2012 02:55 AM, Florian Fainelli wrote:
> > Hi all,
> > 
> > I have a specific use case, where two boards using the same SoC have 
different 
> > UART speeds, which is something that I have specified in their 
corresponding 
> > dts files. In order to make sure people don't mess up the configuration, I 
> > prefer not to rely on the bootloader-supplied kernel-command line.
> > 
> > I was kind of expecting that ARM_ATAG_DTB_COMPAT + CMDLINE_EXTEND would 
> > actually concatenate the kernel command-line with the bootargs provided 
from 
> > dtb.
> > 
> > Is this something someone else would need? If so, shall we just make that 
> > happen when the two config symbols mentionned above are enabled, or shall 
we 
> > introduce a 4th kernel command line handling strategy?
> > 
> > Thank you for your answers.
> 
> There was a patch to do this:
> 
> http://www.mail-archive.com/devicetree-
discuss@lists.ozlabs.org/msg10448.html
> 
> Please comment if this works for you.

This patch indeeds work fine for me when I disable ARM_ATAG_DTB_COMPAT. If I 
let it turned on the chosen node is correctly scanned, but its value, is the 
one coming from tag_cmdline() which is actually the bootloader supplied 
commad-line. I will cook up a patch for this, because I expect the 3 command-
lines to be concatened in the end (built-in, atag and dtb).

I don't see any comments from Ben or anyone after Doug sent his version 2 of 
the patch, is there any reason not to merge it?
-- 
Florian

  reply	other threads:[~2012-06-11 17:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-08  7:55 Overriding/concatenating kernel command-line with bootargs from dtb? Florian Fainelli
2012-06-08  7:55 ` Florian Fainelli
2012-06-08 21:49 ` Nicolas Pitre
2012-06-08 21:49   ` Nicolas Pitre
2012-06-11 14:34 ` Rob Herring
2012-06-11 14:34   ` Rob Herring
2012-06-11 17:51   ` Florian Fainelli [this message]
2012-06-11 17:51     ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1424241.AIpjaKT9XL@bender \
    --to=florian@openwrt.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.