* [PATCH] libxc: arm: use INVALID_P2M_ENTRY
@ 2015-02-06 12:37 Wei Liu
2015-02-06 15:18 ` Stefano Stabellini
0 siblings, 1 reply; 3+ messages in thread
From: Wei Liu @ 2015-02-06 12:37 UTC (permalink / raw)
To: xen-devel
Cc: Julien Grall, Ian Jackson, Wei Liu, Ian Campbell,
Stefano Stabellini
Albeit INVALID_P2M_ENTRY and INVALID_MFN are both ~0UL, conceptually
speaking we should use INVALID_P2M_ENTRY for setting P2M values.
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Cc: Ian Campbell <ian.campbell@citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
CC: Julien Grall <julien.grall@citrix.com>
---
tools/libxc/xc_dom_arm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/libxc/xc_dom_arm.c b/tools/libxc/xc_dom_arm.c
index 9b31b1f..c7feca7 100644
--- a/tools/libxc/xc_dom_arm.c
+++ b/tools/libxc/xc_dom_arm.c
@@ -453,7 +453,7 @@ int arch_setup_meminit(struct xc_dom_image *dom)
if ( dom->p2m_host == NULL )
return -EINVAL;
for ( pfn = 0; pfn < p2m_size; pfn++ )
- dom->p2m_host[pfn] = INVALID_MFN;
+ dom->p2m_host[pfn] = INVALID_P2M_ENTRY;
/* setup initial p2m and allocate guest memory */
for ( i = 0; dom->rambank_size[i] && i < GUEST_RAM_BANKS; i++ )
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] libxc: arm: use INVALID_P2M_ENTRY
2015-02-06 12:37 [PATCH] libxc: arm: use INVALID_P2M_ENTRY Wei Liu
@ 2015-02-06 15:18 ` Stefano Stabellini
2015-02-19 17:19 ` Ian Campbell
0 siblings, 1 reply; 3+ messages in thread
From: Stefano Stabellini @ 2015-02-06 15:18 UTC (permalink / raw)
To: Wei Liu
Cc: Julien Grall, Stefano Stabellini, Ian Jackson, Ian Campbell,
xen-devel
On Fri, 6 Feb 2015, Wei Liu wrote:
> Albeit INVALID_P2M_ENTRY and INVALID_MFN are both ~0UL, conceptually
> speaking we should use INVALID_P2M_ENTRY for setting P2M values.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> CC: Julien Grall <julien.grall@citrix.com>
Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> tools/libxc/xc_dom_arm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/libxc/xc_dom_arm.c b/tools/libxc/xc_dom_arm.c
> index 9b31b1f..c7feca7 100644
> --- a/tools/libxc/xc_dom_arm.c
> +++ b/tools/libxc/xc_dom_arm.c
> @@ -453,7 +453,7 @@ int arch_setup_meminit(struct xc_dom_image *dom)
> if ( dom->p2m_host == NULL )
> return -EINVAL;
> for ( pfn = 0; pfn < p2m_size; pfn++ )
> - dom->p2m_host[pfn] = INVALID_MFN;
> + dom->p2m_host[pfn] = INVALID_P2M_ENTRY;
>
> /* setup initial p2m and allocate guest memory */
> for ( i = 0; dom->rambank_size[i] && i < GUEST_RAM_BANKS; i++ )
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] libxc: arm: use INVALID_P2M_ENTRY
2015-02-06 15:18 ` Stefano Stabellini
@ 2015-02-19 17:19 ` Ian Campbell
0 siblings, 0 replies; 3+ messages in thread
From: Ian Campbell @ 2015-02-19 17:19 UTC (permalink / raw)
To: Stefano Stabellini; +Cc: Julien Grall, Ian Jackson, Wei Liu, xen-devel
On Fri, 2015-02-06 at 15:18 +0000, Stefano Stabellini wrote:
> On Fri, 6 Feb 2015, Wei Liu wrote:
> > Albeit INVALID_P2M_ENTRY and INVALID_MFN are both ~0UL, conceptually
> > speaking we should use INVALID_P2M_ENTRY for setting P2M values.
> >
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > Cc: Ian Campbell <ian.campbell@citrix.com>
> > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> > CC: Julien Grall <julien.grall@citrix.com>
>
> Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-02-19 17:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-06 12:37 [PATCH] libxc: arm: use INVALID_P2M_ENTRY Wei Liu
2015-02-06 15:18 ` Stefano Stabellini
2015-02-19 17:19 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.