Re: [PATCH v3 00/15] xen/arm: Bug fixes for the vGIC

[Ian Campbell <ian.campbell@citrix.com>]

On Mon, 2015-02-16 at 14:50 +0000, Julien Grall wrote:

All applied, thanks.

> Most of this patches should be backported to Xen 4.5/Xen 4.5 (see each patch).
> Although, the one in GICv2 are not critical.

Do you have a handy index of which ones do/don't need backporting to
save me trawling through the mails?

Given the lack of GICv3 hardware on the market today I'm in two minds
about the backports to the gicv3 functionality, especially given the
number of patches involved and the amount of stuff they change. In
practical terms GICv2 support isn't much more than tech-preview in 4.5
anyway.

> 
> Changes since v2:
>     - Sort re-distributor message
>     - Typoes
>     - Update/re-work commit messages
> 
> Changes since v1:
>     - 2 patches of the series turn into an XSA 118 [1]
>     - Correctly implement the re-distributor
>     - Drop the documentation patch as I succedeed to quickly implement the
>     re-distributor emulation
>     - Replace " Don't check the size when we ignore the write/read as
>     zero" patches by a new version to handle correctly RAZ/WI registers
>     - Bunch of new patch to fix registers emulation
> 
> For each changes see in each patch.
> 
> A branch has been pushed for all the patches:
> git://xenbits.xen.org/people/julieng/xen-unstable.git branch vgic-fixes-v3
> 
> Sincerely yours,
> 
> [1] http://xenbits.xen.org/xsa/advisory-118.html
> 
> Cc: Chen Baozi <baozich@gmail.com>
> 
> Julien Grall (15):
>   xen/arm: vgic-v3: Correctly set GICD_TYPER.IDbits
>   xen/arm: vgic-v3: Correctly set GICD_TYPER.CPUNumber
>   xen/arm: vgic-v3: Correctly handle GICD_CTLR
>   xen/arm: vgic-v3: Correctly handle RAZ/WI registers
>   xen/arm: vgic-v3: Correctly implement read into GICR_NSACR
>   xen/arm: vgic-v3: Set stride during domain initialization
>   xen/arm: vgic-v3: Use a struct to describe contiguous rdist regions
>   xen/arm: vgic-v3: Emulate correctly the re-distributor
>   xen/arm: vgic-v3: Clarify which distributor is used in the common
>     emulation
>   xen/arm: vgic-v2: Correctly set GICD_TYPER.CPUNumber
>   xen/arm: vgic-v2: Correctly handle RAZ/WI registers
>   xen/arm: vgic-v2: Take the lock when writing into GICD_CTLR
>   xen/arm: vgic-v2: GICD_I{S,C}PENDR* are only word-accessible
>   xen/arm: vgic: Drop iactive, ipend, pendsgi field
>   xen/arm: gic-v3: Update some comments in the code
> 
>  xen/arch/arm/gic-v3.c             |  56 +++--
>  xen/arch/arm/vgic-v2.c            | 112 ++++------
>  xen/arch/arm/vgic-v3.c            | 416 +++++++++++++++++++++++---------------
>  xen/include/asm-arm/domain.h      |  17 +-
>  xen/include/asm-arm/gic.h         |   1 +
>  xen/include/asm-arm/gic_v3_defs.h |   3 +
>  xen/include/asm-arm/vgic.h        |   2 +-
>  7 files changed, 349 insertions(+), 258 deletions(-)
>