Re: [PATCH v3 14/15] xen/arm: vgic: Drop iactive, ipend, pendsgi field

[Julien Grall <julien.grall@linaro.org>]

Hi Ian,

On 19/02/15 16:09, Ian Campbell wrote:
> On Mon, 2015-02-16 at 14:50 +0000, Julien Grall wrote:
>> The current VGIC code doesn't support to change the pending and active status
>> of an IRQ via the (re-)distributor.
>>
>> Futhermore, all the access size wasn't support correctly and some
>> registers was implemented as write-ignore. The latter make very
>> difficult for a kernel developer to find that we don't support R/W to
>> those registers.
>>
>> Make the support consistent:
>>     - read will return 0 (RAZ)
>>     - write will print an error and inject a data abort to the guest
>>
>> Also, those fields was never set and field such as ipend and pendsgi was
>> doing the same jobs.
>>
>> Rather than wasting memory, we should better drop it. We could re-introduce
>> them if we need it when the support will be made.
>>
>> Signed-off-by: Julien Grall <julien.grall@linaro.org>
>>
>>  
>>      case GICD_ICACTIVER ... GICD_ICACTIVERN:
>>          if ( dabt.size != DABT_WORD ) goto bad_width;
>> -        rank = vgic_rank_offset(v, 1, gicd_reg - GICD_ICACTIVER, DABT_WORD);
>> -        if ( rank == NULL) goto write_ignore;
>> -        vgic_lock_rank(v, rank, flags);
>> -        rank->iactive &= ~*r;
>> -        vgic_unlock_rank(v, rank, flags);
>> -        return 1;
>> +        printk(XENLOG_ERR
> 
> I think you meant XENLOG_G_ERR here?

Whoops yes. I re-introduced XSA-118 by inadvertence.

> If that's the case then I can fix + ack as I commit.

Thanks,

-- 
Julien Grall