From: Ian Campbell <ian.campbell@citrix.com>
To: Julien Grall <julien.grall@linaro.org>
Cc: xen-devel@lists.xenproject.org, tim@xen.org,
stefano.stabellini@citrix.com
Subject: Re: [PATCH v3 08/13] xen/arm: Describe device supported by a driver with dt_match_node
Date: Fri, 20 Feb 2015 12:30:13 +0000 [thread overview]
Message-ID: <1424435413.30924.207.camel@citrix.com> (raw)
In-Reply-To: <1422643768-23614-9-git-send-email-julien.grall@linaro.org>
On Fri, 2015-01-30 at 18:49 +0000, Julien Grall wrote:
Subject: "devices"
> Xen is currently using list a compatible string to know if the driver
"using a list of compatible strings"
rather than "if the driver can use device node" I'd say something like
"to match drivers against device nodes".
> can use device node. This leads to have double definition in the GIC
> code.
"having double definitions".
(aside: can we eventually get rid of that duplication somehow?)
> Futhermore Linux drivers is using dt_match_node (actually called of_device_id
"Furthermore" and "are using"
> in Linux) to list device supported by the drivers.
"devices"
I'd append one more sentence, something like "Remove the existing
compatible field and replace with a dt_match field". Just to make it
clear what the change here is.
>
> Signed-off-by: Julien Grall <julien.grall@linaro.org>
> Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
The actual code looks fine, with the commit message fixed up as
described:
Acked-by: Ian Campbell <ian.campbell@citrix.com>
next prev parent reply other threads:[~2015-02-20 12:30 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-30 18:49 [PATCH v3 00/13] xen/arm: Resync the SMMU driver with the Linux one Julien Grall
2015-01-30 18:49 ` [PATCH v3 01/13] xen/arm: gic-v2: Change the device name in DT_DEVICE_START Julien Grall
2015-02-20 12:16 ` Ian Campbell
2015-01-30 18:49 ` [PATCH v3 02/13] xen/arm: vgic: Drop unecessary include asm/device.h Julien Grall
2015-02-20 12:16 ` Ian Campbell
2015-01-30 18:49 ` [PATCH v3 03/13] xen/dt: Extend dt_device_match to possibly store data Julien Grall
2015-02-06 12:37 ` Stefano Stabellini
2015-02-20 12:16 ` Ian Campbell
2015-01-30 18:49 ` [PATCH v3 04/13] xen/arm: device: Rename device_type into device_class Julien Grall
2015-02-06 12:38 ` Stefano Stabellini
2015-02-20 12:17 ` Ian Campbell
2015-01-30 18:49 ` [PATCH v3 05/13] xen/iommu: arm: Remove temporary the SMMU driver Julien Grall
2015-02-20 12:18 ` Ian Campbell
2015-02-20 12:53 ` Julien Grall
2015-02-20 13:47 ` Ian Campbell
2015-02-20 13:53 ` Julien Grall
2015-02-20 14:06 ` Ian Campbell
2015-02-20 14:07 ` Julien Grall
2015-01-30 18:49 ` [PATCH v3 06/13] xen/arm: Introduce a generic way to describe device Julien Grall
2015-02-02 8:04 ` Jan Beulich
2015-02-06 12:39 ` Stefano Stabellini
2015-02-20 12:22 ` Ian Campbell
2015-02-24 14:26 ` Julien Grall
2015-02-24 14:45 ` Ian Campbell
2015-01-30 18:49 ` [PATCH v3 07/13] xen/iommu: Consolidate device assignment ops into a single set Julien Grall
2015-02-20 12:25 ` Ian Campbell
2015-01-30 18:49 ` [PATCH v3 08/13] xen/arm: Describe device supported by a driver with dt_match_node Julien Grall
2015-02-20 12:30 ` Ian Campbell [this message]
2015-02-24 14:42 ` Julien Grall
2015-01-30 18:49 ` [PATCH v3 09/13] xen/iommu: arm: Import the SMMU driver from Linux Julien Grall
2015-02-20 12:31 ` Ian Campbell
2015-02-20 13:33 ` Julien Grall
2015-02-20 13:48 ` Ian Campbell
2015-01-30 18:49 ` [PATCH v3 10/13] xen/iommu: smmu: Check for duplicate stream IDs when registering master devices Julien Grall
2015-02-20 12:35 ` Ian Campbell
2015-02-20 13:34 ` Julien Grall
2015-02-20 13:48 ` Ian Campbell
2015-02-20 14:47 ` Andreas Herrmann
2015-01-30 18:49 ` [PATCH v3 11/13] xen/iommu: smmu: Introduce automatic stream-id-masking Julien Grall
2015-02-20 13:15 ` Ian Campbell
2015-02-20 13:42 ` Julien Grall
2015-02-20 13:55 ` Ian Campbell
2015-02-20 15:07 ` Julien Grall
2015-02-23 10:42 ` Ian Campbell
2015-02-23 10:52 ` Julien Grall
2015-02-23 12:48 ` Ian Campbell
2015-01-30 18:49 ` [PATCH v3 12/13] xen/iommu: smmu: Add Xen specific code to be able to use the driver Julien Grall
2015-02-02 18:55 ` Manish
2015-02-02 23:01 ` Julien Grall
2015-02-06 13:20 ` Stefano Stabellini
2015-02-09 15:40 ` Julien Grall
2015-02-19 17:17 ` Julien Grall
2015-02-20 13:29 ` Ian Campbell
2015-02-20 14:01 ` Julien Grall
2015-02-20 13:23 ` Ian Campbell
2015-02-20 13:50 ` Julien Grall
2015-01-30 18:49 ` [PATCH v3 13/13] xen/iommu: smmu: Advertise when the SMMU support coherent table walk Julien Grall
2015-02-06 14:06 ` Stefano Stabellini
2015-02-10 1:36 ` Julien Grall
2015-02-10 1:37 ` Julien Grall
2015-02-20 13:34 ` Ian Campbell
2015-02-20 14:07 ` Julien Grall
2015-02-20 14:13 ` Ian Campbell
2015-02-20 14:15 ` Julien Grall
2015-02-20 14:28 ` Ian Campbell
2015-02-20 14:15 ` [PATCH v3 00/13] xen/arm: Resync the SMMU driver with the Linux one Ian Campbell
2015-02-20 14:19 ` Julien Grall
2015-02-20 14:27 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424435413.30924.207.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=julien.grall@linaro.org \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.