From: Ian Campbell <ian.campbell@citrix.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: xen-devel@lists.xenproject.org
Subject: Re: [OSSTEST PATCH 5/8] standalone: Always set OSSTEST_NO_BASELINE
Date: Wed, 25 Feb 2015 13:26:35 +0000 [thread overview]
Message-ID: <1424870795.20243.101.camel@citrix.com> (raw)
In-Reply-To: <1424869277-16764-6-git-send-email-ian.jackson@eu.citrix.com>
On Wed, 2015-02-25 at 13:01 +0000, Ian Jackson wrote:
> OSSTEST_NO_BASELINE disables the thing where cr-daily-branch decides
> (based on information from sg-check-tested) that the baseline is
> untested and therefore that it ought to do a baseline test instead of
> testing the tip.
>
> This whole feature is never correct in standalone mode, where there is
> no useful test history database for sg-check-tested to work on.
>
> In the case where the branch was osstest, not specifying --baseline
> and therefore not having OSSTEST_NO_BASELINE didn't make all that much
> difference because we also have OSSTEST_USE_HEAD=y and currently
> ap-fetch-version-old (wrongfully) honours that, so the `baseline' test
> would use the head anyway.
>
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
Although:
> - --baseline)nobaseline=n; shift 1;;
> + --baseline) echo >&2 'warning: --baseline is obsolete'; shift 1;;
TBH I think you could just nuke it from a tool like this. I rather
suspect noone is using it... I can't even remember why I wanted it.
next prev parent reply other threads:[~2015-02-25 13:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 13:01 [OSSTEST PATCH 0/8] improvements related to adhoc testing Ian Jackson
2015-02-25 13:01 ` [OSSTEST PATCH 1/8] emails: cr*: Defer setting of OSSTEST_EMAIL_HEADER Ian Jackson
2015-02-25 13:25 ` Ian Campbell
2015-02-25 13:01 ` [OSSTEST PATCH 2/8] emails: branch-settings.osstest: Permit caller to specify OSSTEST_EMAIL_HEADER Ian Jackson
2015-02-25 13:25 ` Ian Campbell
2015-02-25 13:01 ` [OSSTEST PATCH 3/8] emails: honour OSSTEST_EMAIL_SUBJECT_PREFIX Ian Jackson
2015-02-25 13:24 ` Ian Campbell
2015-02-26 17:44 ` Ian Jackson
2015-02-27 9:31 ` Ian Campbell
2015-02-25 13:01 ` [OSSTEST PATCH 4/8] emails: Set OSSTEST_EMAIL_SUBJECT_PREFIX if not --real Ian Jackson
2015-02-25 13:01 ` [OSSTEST PATCH 5/8] standalone: Always set OSSTEST_NO_BASELINE Ian Jackson
2015-02-25 13:26 ` Ian Campbell [this message]
2015-02-26 17:49 ` Ian Jackson
2015-02-25 13:01 ` [OSSTEST PATCH 6/8] standalone: Always pass OLD_REVISION=NONE to cr-daily-branch Ian Jackson
2015-02-25 13:28 ` Ian Campbell
2015-02-25 13:01 ` [OSSTEST PATCH 7/8] ap-fetch-version-old: Do not honour OSSTEST_USE_HEAD Ian Jackson
2015-02-25 13:28 ` Ian Campbell
2015-02-25 13:01 ` [OSSTEST PATCH 8/8] ap-fetch-version: Use osstest's home to find master tree Ian Jackson
2015-02-25 13:29 ` Ian Campbell
2015-02-26 17:52 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424870795.20243.101.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.