From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Kevin Hao <haokexin@gmail.com>
Cc: linux-fbdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Paul Mackerras <paulus@samba.org>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Subject: Re: [PATCH 03/15] fbdev: aty128fb: replace PPC_OF with PPC
Date: Fri, 27 Feb 2015 00:11:15 +0000 [thread overview]
Message-ID: <1424995875.4645.42.camel@kernel.crashing.org> (raw)
In-Reply-To: <1422712065-9403-4-git-send-email-haokexin@gmail.com>
On Sat, 2015-01-31 at 21:47 +0800, Kevin Hao wrote:
> The PPC_OF is a ppc specific option which is used to mean that the
> firmware device tree access functions are available. Since all the
> ppc platforms have a device tree, it is aways set to 'y' for ppc.
> So it makes no sense to keep a such option in the current kernel.
> Replace it with PPC.
>
> Signed-off-by: Kevin Hao <haokexin@gmail.com>
For this and generally the whole series,
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Which tree do we expect this to go through ?
Cheers,
Ben.
> ---
> drivers/video/fbdev/aty/aty128fb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/aty/aty128fb.c b/drivers/video/fbdev/aty/aty128fb.c
> index aedf2fbf9bf6..0156954bf340 100644
> --- a/drivers/video/fbdev/aty/aty128fb.c
> +++ b/drivers/video/fbdev/aty/aty128fb.c
> @@ -965,7 +965,7 @@ static void __iomem *aty128_find_mem_vbios(struct aty128fb_par *par)
> /* fill in known card constants if pll_block is not available */
> static void aty128_timings(struct aty128fb_par *par)
> {
> -#ifdef CONFIG_PPC_OF
> +#ifdef CONFIG_PPC
> /* instead of a table lookup, assume OF has properly
> * setup the PLL registers and use their values
> * to set the XCLK values and reference divider values */
> @@ -979,7 +979,7 @@ static void aty128_timings(struct aty128fb_par *par)
> if (!par->constants.ref_clk)
> par->constants.ref_clk = 2950;
>
> -#ifdef CONFIG_PPC_OF
> +#ifdef CONFIG_PPC
> x_mpll_ref_fb_div = aty_ld_pll(X_MPLL_REF_FB_DIV);
> xclk_cntl = aty_ld_pll(XCLK_CNTL) & 0x7;
> Nx = (x_mpll_ref_fb_div & 0x00ff00) >> 8;
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Kevin Hao <haokexin@gmail.com>
Cc: linux-fbdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Paul Mackerras <paulus@samba.org>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Subject: Re: [PATCH 03/15] fbdev: aty128fb: replace PPC_OF with PPC
Date: Fri, 27 Feb 2015 11:11:15 +1100 [thread overview]
Message-ID: <1424995875.4645.42.camel@kernel.crashing.org> (raw)
In-Reply-To: <1422712065-9403-4-git-send-email-haokexin@gmail.com>
On Sat, 2015-01-31 at 21:47 +0800, Kevin Hao wrote:
> The PPC_OF is a ppc specific option which is used to mean that the
> firmware device tree access functions are available. Since all the
> ppc platforms have a device tree, it is aways set to 'y' for ppc.
> So it makes no sense to keep a such option in the current kernel.
> Replace it with PPC.
>
> Signed-off-by: Kevin Hao <haokexin@gmail.com>
For this and generally the whole series,
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Which tree do we expect this to go through ?
Cheers,
Ben.
> ---
> drivers/video/fbdev/aty/aty128fb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/aty/aty128fb.c b/drivers/video/fbdev/aty/aty128fb.c
> index aedf2fbf9bf6..0156954bf340 100644
> --- a/drivers/video/fbdev/aty/aty128fb.c
> +++ b/drivers/video/fbdev/aty/aty128fb.c
> @@ -965,7 +965,7 @@ static void __iomem *aty128_find_mem_vbios(struct aty128fb_par *par)
> /* fill in known card constants if pll_block is not available */
> static void aty128_timings(struct aty128fb_par *par)
> {
> -#ifdef CONFIG_PPC_OF
> +#ifdef CONFIG_PPC
> /* instead of a table lookup, assume OF has properly
> * setup the PLL registers and use their values
> * to set the XCLK values and reference divider values */
> @@ -979,7 +979,7 @@ static void aty128_timings(struct aty128fb_par *par)
> if (!par->constants.ref_clk)
> par->constants.ref_clk = 2950;
>
> -#ifdef CONFIG_PPC_OF
> +#ifdef CONFIG_PPC
> x_mpll_ref_fb_div = aty_ld_pll(X_MPLL_REF_FB_DIV);
> xclk_cntl = aty_ld_pll(XCLK_CNTL) & 0x7;
> Nx = (x_mpll_ref_fb_div & 0x00ff00) >> 8;
next prev parent reply other threads:[~2015-02-27 0:11 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-31 13:47 [PATCH 00/15] powerpc: kill PPC_OF Kevin Hao
2015-01-31 13:47 ` [PATCH 01/15] PCI: introduce pci_device_to_OF_node() for !CONFIG_OF Kevin Hao
2015-01-31 13:47 ` Kevin Hao
2015-02-02 2:28 ` Michael Ellerman
2015-02-02 2:28 ` Michael Ellerman
2015-02-02 15:47 ` Bjorn Helgaas
2015-02-02 15:47 ` Bjorn Helgaas
2015-02-03 0:25 ` Michael Ellerman
2015-02-03 0:25 ` Michael Ellerman
2015-02-03 1:37 ` [PATCH v2 01/15] PCI: Add pci_device_to_OF_node() stub " Kevin Hao
2015-02-03 1:37 ` Kevin Hao
2015-02-03 15:31 ` Bjorn Helgaas
2015-02-03 15:31 ` Bjorn Helgaas
2015-02-03 15:29 ` [PATCH 01/15] PCI: introduce pci_device_to_OF_node() " Bjorn Helgaas
2015-02-03 15:29 ` Bjorn Helgaas
2015-02-03 1:02 ` Kevin Hao
2015-02-03 1:02 ` Kevin Hao
2015-01-31 13:47 ` [PATCH 02/15] sata_svw: remove the dependency on PPC_OF Kevin Hao
2015-01-31 13:47 ` Kevin Hao
2015-01-31 15:43 ` Tejun Heo
2015-01-31 15:43 ` Tejun Heo
2015-01-31 13:47 ` [PATCH 03/15] fbdev: aty128fb: replace PPC_OF with PPC Kevin Hao
2015-01-31 13:47 ` Kevin Hao
2015-02-27 0:11 ` Benjamin Herrenschmidt [this message]
2015-02-27 0:11 ` Benjamin Herrenschmidt
2015-02-27 1:05 ` Kevin Hao
2015-02-27 1:05 ` Kevin Hao
2015-02-27 2:05 ` Benjamin Herrenschmidt
2015-02-27 2:05 ` Benjamin Herrenschmidt
2015-03-10 12:23 ` Tomi Valkeinen
2015-03-10 12:23 ` Tomi Valkeinen
2015-03-11 4:38 ` Kevin Hao
2015-03-11 4:38 ` Kevin Hao
2015-03-11 7:51 ` Tomi Valkeinen
2015-03-11 7:51 ` Tomi Valkeinen
2015-01-31 13:47 ` [PATCH 04/15] fbdev: radeon: " Kevin Hao
2015-01-31 13:47 ` Kevin Hao
2015-01-31 13:47 ` [PATCH 05/15] fbdev: imsttfb: remove the dependency on PPC_OF Kevin Hao
2015-01-31 13:47 ` Kevin Hao
2015-02-01 2:44 ` Stephen Rothwell
2015-02-01 2:44 ` Stephen Rothwell
2015-02-01 5:51 ` Kevin Hao
2015-02-01 5:51 ` Kevin Hao
2015-02-03 2:20 ` Kevin Hao
2015-02-03 2:20 ` Kevin Hao
2015-02-03 2:34 ` Stephen Rothwell
2015-02-03 2:34 ` Stephen Rothwell
2015-02-03 2:34 ` Stephen Rothwell
2015-02-03 2:34 ` Stephen Rothwell
2015-01-31 13:47 ` [PATCH 06/15] fbdev: nvidia: " Kevin Hao
2015-01-31 13:47 ` Kevin Hao
2015-01-31 13:47 ` [PATCH 07/15] fbdev: riva: " Kevin Hao
2015-01-31 13:47 ` Kevin Hao
2015-01-31 13:47 ` [PATCH 08/15] fbdev: remove the unnecessary includes of ppc specific header files Kevin Hao
2015-01-31 13:47 ` Kevin Hao
2015-01-31 13:47 ` [PATCH 09/15] fbdev: kconfig: replace PPC_OF with PPC Kevin Hao
2015-01-31 13:47 ` Kevin Hao
2015-01-31 13:47 ` [PATCH 10/15] gpio: " Kevin Hao
2015-01-31 13:47 ` Kevin Hao
2015-02-04 10:07 ` Linus Walleij
2015-02-04 10:07 ` Linus Walleij
2015-01-31 13:47 ` [PATCH 11/15] mmc: " Kevin Hao
2015-01-31 13:47 ` Kevin Hao
2015-01-31 13:47 ` [PATCH 12/15] mtd: " Kevin Hao
2015-01-31 13:47 ` Kevin Hao
2015-02-06 4:08 ` Brian Norris
2015-02-06 4:08 ` Brian Norris
2015-01-31 13:47 ` [PATCH 13/15] tty: kconfig: remove the superfluous dependency on PPC_OF Kevin Hao
2015-01-31 13:47 ` Kevin Hao
2015-01-31 13:47 ` [PATCH 14/15] usb: kconfig: replace PPC_OF with PPC Kevin Hao
2015-01-31 13:47 ` [PATCH 15/15] powerpc: kill PPC_OF Kevin Hao
2015-02-02 2:25 ` [PATCH 00/15] " Michael Ellerman
2015-02-02 2:42 ` Kevin Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424995875.4645.42.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=haokexin@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=plagnioj@jcrosoft.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.