All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Norris <computersforpeace@gmail.com>
To: Richard Weinberger <richard@nod.at>,
	Artem Bityutskiy <dedekind1@gmail.com>
Cc: kernel-janitors@vger.kernel.org,
	Brian Norris <computersforpeace@gmail.com>,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/5] UBI: fix out of bounds write
Date: Sat, 28 Feb 2015 10:23:26 +0000	[thread overview]
Message-ID: <1425119009-28634-3-git-send-email-computersforpeace@gmail.com> (raw)
In-Reply-To: <1425119009-28634-1-git-send-email-computersforpeace@gmail.com>

If aeb->len >= vol->reserved_pebs, we should not be writing aeb into the
PEB->LEB mapping.

Caught by Coverity, CID #711212.

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
---
 drivers/mtd/ubi/eba.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/mtd/ubi/eba.c b/drivers/mtd/ubi/eba.c
index da4c79259f67..6442d3fbcb73 100644
--- a/drivers/mtd/ubi/eba.c
+++ b/drivers/mtd/ubi/eba.c
@@ -1418,7 +1418,8 @@ int ubi_eba_init(struct ubi_device *ubi, struct ubi_attach_info *ai)
 				 * during re-size.
 				 */
 				ubi_move_aeb_to_list(av, aeb, &ai->erase);
-			vol->eba_tbl[aeb->lnum] = aeb->pnum;
+			else
+				vol->eba_tbl[aeb->lnum] = aeb->pnum;
 		}
 	}
 
-- 
2.1.0


WARNING: multiple messages have this Message-ID (diff)
From: Brian Norris <computersforpeace@gmail.com>
To: Richard Weinberger <richard@nod.at>,
	Artem Bityutskiy <dedekind1@gmail.com>
Cc: kernel-janitors@vger.kernel.org,
	Brian Norris <computersforpeace@gmail.com>,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/5] UBI: fix out of bounds write
Date: Sat, 28 Feb 2015 02:23:26 -0800	[thread overview]
Message-ID: <1425119009-28634-3-git-send-email-computersforpeace@gmail.com> (raw)
In-Reply-To: <1425119009-28634-1-git-send-email-computersforpeace@gmail.com>

If aeb->len >= vol->reserved_pebs, we should not be writing aeb into the
PEB->LEB mapping.

Caught by Coverity, CID #711212.

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
---
 drivers/mtd/ubi/eba.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/mtd/ubi/eba.c b/drivers/mtd/ubi/eba.c
index da4c79259f67..6442d3fbcb73 100644
--- a/drivers/mtd/ubi/eba.c
+++ b/drivers/mtd/ubi/eba.c
@@ -1418,7 +1418,8 @@ int ubi_eba_init(struct ubi_device *ubi, struct ubi_attach_info *ai)
 				 * during re-size.
 				 */
 				ubi_move_aeb_to_list(av, aeb, &ai->erase);
-			vol->eba_tbl[aeb->lnum] = aeb->pnum;
+			else
+				vol->eba_tbl[aeb->lnum] = aeb->pnum;
 		}
 	}
 
-- 
2.1.0

WARNING: multiple messages have this Message-ID (diff)
From: Brian Norris <computersforpeace@gmail.com>
To: Richard Weinberger <richard@nod.at>,
	Artem Bityutskiy <dedekind1@gmail.com>
Cc: Brian Norris <computersforpeace@gmail.com>,
	<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org
Subject: [PATCH 2/5] UBI: fix out of bounds write
Date: Sat, 28 Feb 2015 02:23:26 -0800	[thread overview]
Message-ID: <1425119009-28634-3-git-send-email-computersforpeace@gmail.com> (raw)
In-Reply-To: <1425119009-28634-1-git-send-email-computersforpeace@gmail.com>

If aeb->len >= vol->reserved_pebs, we should not be writing aeb into the
PEB->LEB mapping.

Caught by Coverity, CID #711212.

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
---
 drivers/mtd/ubi/eba.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/mtd/ubi/eba.c b/drivers/mtd/ubi/eba.c
index da4c79259f67..6442d3fbcb73 100644
--- a/drivers/mtd/ubi/eba.c
+++ b/drivers/mtd/ubi/eba.c
@@ -1418,7 +1418,8 @@ int ubi_eba_init(struct ubi_device *ubi, struct ubi_attach_info *ai)
 				 * during re-size.
 				 */
 				ubi_move_aeb_to_list(av, aeb, &ai->erase);
-			vol->eba_tbl[aeb->lnum] = aeb->pnum;
+			else
+				vol->eba_tbl[aeb->lnum] = aeb->pnum;
 		}
 	}
 
-- 
2.1.0


  parent reply	other threads:[~2015-02-28 10:23 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-28 10:23 [PATCH 0/5] UBI: Coverity-inspired fixes Brian Norris
2015-02-28 10:23 ` Brian Norris
2015-02-28 10:23 ` Brian Norris
2015-02-28 10:23 ` [PATCH 1/5] UBI: account for bitflips in both the VID header and data Brian Norris
2015-02-28 10:23   ` Brian Norris
2015-02-28 10:23   ` Brian Norris
2015-02-28 10:23 ` Brian Norris [this message]
2015-02-28 10:23   ` [PATCH 2/5] UBI: fix out of bounds write Brian Norris
2015-02-28 10:23   ` Brian Norris
2015-02-28 10:23 ` [PATCH 3/5] UBI: initialize LEB number variable Brian Norris
2015-02-28 10:23   ` Brian Norris
2015-02-28 10:23   ` Brian Norris
2015-02-28 10:23 ` [PATCH 4/5] UBI: fix check for "too many bytes" Brian Norris
2015-02-28 10:23   ` Brian Norris
2015-02-28 10:23   ` Brian Norris
2015-03-26  9:29   ` Richard Weinberger
2015-03-26  9:29     ` Richard Weinberger
2015-03-26  9:29     ` Richard Weinberger
2015-02-28 10:23 ` [PATCH 5/5] UBI: align comment for readability Brian Norris
2015-02-28 10:23   ` Brian Norris
2015-02-28 10:23   ` Brian Norris
2015-03-05 10:33 ` [PATCH 0/5] UBI: Coverity-inspired fixes Richard Weinberger
2015-03-05 10:33   ` Richard Weinberger
2015-03-05 10:33   ` Richard Weinberger
2015-03-06  2:04   ` Brian Norris
2015-03-06  2:04     ` Brian Norris
2015-03-06  2:04     ` Brian Norris
2015-03-26  9:11     ` Richard Weinberger
2015-03-26  9:11       ` Richard Weinberger
2015-03-26  9:11       ` Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1425119009-28634-3-git-send-email-computersforpeace@gmail.com \
    --to=computersforpeace@gmail.com \
    --cc=dedekind1@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.