All of lore.kernel.org
 help / color / mirror / Atom feed
From: pebolle@tiscali.nl (Paul Bolle)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/7] efuse: Move Tegra efuse driver
Date: Sat, 28 Feb 2015 16:51:30 +0100	[thread overview]
Message-ID: <1425138690.24292.49.camel@x220> (raw)
In-Reply-To: <1424864719-3390-5-git-send-email-ezequiel.garcia@imgtec.com>

On Wed, 2015-02-25 at 08:45 -0300, Ezequiel Garcia wrote:
> Now that the efuse subsystem has been introduced, move the Tegra efuse driver
> from drivers/soc/tegra/fuse/ to drivers/efuse/tegra. For now, there's no
> generic efuse API. However, by having the drivers in a unified location it is
> expected that such API will arise easier once support for more devices is added.
> 
> Cc: Stephen Warren <swarren@wwwdotorg.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Alexandre Courbot <gnurou@gmail.com>
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@imgtec.com>
> ---
>  drivers/efuse/Kconfig                                     | 7 +++++++
>  drivers/efuse/Makefile                                    | 1 +
>  drivers/{soc/tegra/fuse => efuse/tegra}/Makefile          | 0
>  drivers/{soc/tegra/fuse => efuse/tegra}/fuse-tegra.c      | 0
>  drivers/{soc/tegra/fuse => efuse/tegra}/fuse-tegra20.c    | 0
>  drivers/{soc/tegra/fuse => efuse/tegra}/fuse-tegra30.c    | 0
>  drivers/{soc/tegra/fuse => efuse/tegra}/fuse.h            | 0
>  drivers/{soc/tegra/fuse => efuse/tegra}/speedo-tegra114.c | 0
>  drivers/{soc/tegra/fuse => efuse/tegra}/speedo-tegra124.c | 0
>  drivers/{soc/tegra/fuse => efuse/tegra}/speedo-tegra20.c  | 0
>  drivers/{soc/tegra/fuse => efuse/tegra}/speedo-tegra30.c  | 0
>  drivers/{soc/tegra/fuse => efuse/tegra}/tegra-apbmisc.c   | 0
>  drivers/soc/tegra/Makefile                                | 2 --
>  13 files changed, 8 insertions(+), 2 deletions(-)
>  rename drivers/{soc/tegra/fuse => efuse/tegra}/Makefile (100%)
>  rename drivers/{soc/tegra/fuse => efuse/tegra}/fuse-tegra.c (100%)
>  rename drivers/{soc/tegra/fuse => efuse/tegra}/fuse-tegra20.c (100%)
>  rename drivers/{soc/tegra/fuse => efuse/tegra}/fuse-tegra30.c (100%)
>  rename drivers/{soc/tegra/fuse => efuse/tegra}/fuse.h (100%)
>  rename drivers/{soc/tegra/fuse => efuse/tegra}/speedo-tegra114.c (100%)
>  rename drivers/{soc/tegra/fuse => efuse/tegra}/speedo-tegra124.c (100%)
>  rename drivers/{soc/tegra/fuse => efuse/tegra}/speedo-tegra20.c (100%)
>  rename drivers/{soc/tegra/fuse => efuse/tegra}/speedo-tegra30.c (100%)
>  rename drivers/{soc/tegra/fuse => efuse/tegra}/tegra-apbmisc.c (100%)
> 
> diff --git a/drivers/efuse/Kconfig b/drivers/efuse/Kconfig
> index 617476f..b84e06b 100644
> --- a/drivers/efuse/Kconfig
> +++ b/drivers/efuse/Kconfig
> @@ -1,3 +1,10 @@
>  menu "eFuse drivers"
>  
> +config EFUSE_TEGRA
> +	bool
> +	depends on ARCH_TEGRA
> +	help
> +	  Support for the eFuses available on Tegra SoCs

This is a select only symbol. Patch 5/7 confirms this. So, as far as I
know, no one is ever going to see this help text when running make
*config. Is the help text needed?

> +
> +
>  endmenu


Paul Bolle

WARNING: multiple messages have this Message-ID (diff)
From: Paul Bolle <pebolle@tiscali.nl>
To: Ezequiel Garcia <ezequiel.garcia@imgtec.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Maxime Ripard <maxime.ripard@free-electrons.com>,
	Andrew Bresticker <abrestic@chromium.org>,
	James Hartley <james.hartley@imgtec.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Alexandre Courbot <gnurou@gmail.com>
Subject: Re: [PATCH 4/7] efuse: Move Tegra efuse driver
Date: Sat, 28 Feb 2015 16:51:30 +0100	[thread overview]
Message-ID: <1425138690.24292.49.camel@x220> (raw)
In-Reply-To: <1424864719-3390-5-git-send-email-ezequiel.garcia@imgtec.com>

On Wed, 2015-02-25 at 08:45 -0300, Ezequiel Garcia wrote:
> Now that the efuse subsystem has been introduced, move the Tegra efuse driver
> from drivers/soc/tegra/fuse/ to drivers/efuse/tegra. For now, there's no
> generic efuse API. However, by having the drivers in a unified location it is
> expected that such API will arise easier once support for more devices is added.
> 
> Cc: Stephen Warren <swarren@wwwdotorg.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Alexandre Courbot <gnurou@gmail.com>
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@imgtec.com>
> ---
>  drivers/efuse/Kconfig                                     | 7 +++++++
>  drivers/efuse/Makefile                                    | 1 +
>  drivers/{soc/tegra/fuse => efuse/tegra}/Makefile          | 0
>  drivers/{soc/tegra/fuse => efuse/tegra}/fuse-tegra.c      | 0
>  drivers/{soc/tegra/fuse => efuse/tegra}/fuse-tegra20.c    | 0
>  drivers/{soc/tegra/fuse => efuse/tegra}/fuse-tegra30.c    | 0
>  drivers/{soc/tegra/fuse => efuse/tegra}/fuse.h            | 0
>  drivers/{soc/tegra/fuse => efuse/tegra}/speedo-tegra114.c | 0
>  drivers/{soc/tegra/fuse => efuse/tegra}/speedo-tegra124.c | 0
>  drivers/{soc/tegra/fuse => efuse/tegra}/speedo-tegra20.c  | 0
>  drivers/{soc/tegra/fuse => efuse/tegra}/speedo-tegra30.c  | 0
>  drivers/{soc/tegra/fuse => efuse/tegra}/tegra-apbmisc.c   | 0
>  drivers/soc/tegra/Makefile                                | 2 --
>  13 files changed, 8 insertions(+), 2 deletions(-)
>  rename drivers/{soc/tegra/fuse => efuse/tegra}/Makefile (100%)
>  rename drivers/{soc/tegra/fuse => efuse/tegra}/fuse-tegra.c (100%)
>  rename drivers/{soc/tegra/fuse => efuse/tegra}/fuse-tegra20.c (100%)
>  rename drivers/{soc/tegra/fuse => efuse/tegra}/fuse-tegra30.c (100%)
>  rename drivers/{soc/tegra/fuse => efuse/tegra}/fuse.h (100%)
>  rename drivers/{soc/tegra/fuse => efuse/tegra}/speedo-tegra114.c (100%)
>  rename drivers/{soc/tegra/fuse => efuse/tegra}/speedo-tegra124.c (100%)
>  rename drivers/{soc/tegra/fuse => efuse/tegra}/speedo-tegra20.c (100%)
>  rename drivers/{soc/tegra/fuse => efuse/tegra}/speedo-tegra30.c (100%)
>  rename drivers/{soc/tegra/fuse => efuse/tegra}/tegra-apbmisc.c (100%)
> 
> diff --git a/drivers/efuse/Kconfig b/drivers/efuse/Kconfig
> index 617476f..b84e06b 100644
> --- a/drivers/efuse/Kconfig
> +++ b/drivers/efuse/Kconfig
> @@ -1,3 +1,10 @@
>  menu "eFuse drivers"
>  
> +config EFUSE_TEGRA
> +	bool
> +	depends on ARCH_TEGRA
> +	help
> +	  Support for the eFuses available on Tegra SoCs

This is a select only symbol. Patch 5/7 confirms this. So, as far as I
know, no one is ever going to see this help text when running make
*config. Is the help text needed?

> +
> +
>  endmenu


Paul Bolle


  reply	other threads:[~2015-02-28 15:51 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-25 11:45 [PATCH 0/7] New eFuse subsystem Ezequiel Garcia
2015-02-25 11:45 ` Ezequiel Garcia
2015-02-25 11:45 ` [PATCH 1/7] soc: tegra: Add missing include linux/types.h Ezequiel Garcia
2015-02-25 11:45   ` Ezequiel Garcia
2015-02-25 11:45 ` [PATCH 2/7] soc: tegra: Move the fuse header to a separate directory Ezequiel Garcia
2015-02-25 11:45   ` Ezequiel Garcia
2015-02-25 11:45 ` [PATCH 3/7] drivers: Introduce new eFuse subsystem stub Ezequiel Garcia
2015-02-25 11:45   ` Ezequiel Garcia
2015-02-25 12:29   ` Stefan Wahren
2015-02-25 12:29     ` Stefan Wahren
2015-02-25 12:29     ` Stefan Wahren
2015-02-28 15:45   ` Paul Bolle
2015-02-28 15:45     ` Paul Bolle
2015-02-25 11:45 ` [PATCH 4/7] efuse: Move Tegra efuse driver Ezequiel Garcia
2015-02-25 11:45   ` Ezequiel Garcia
2015-02-28 15:51   ` Paul Bolle [this message]
2015-02-28 15:51     ` Paul Bolle
2015-02-25 12:02 ` [PATCH 0/7] New eFuse subsystem Maxime Ripard
2015-02-25 12:02   ` Maxime Ripard
2015-02-25 12:30   ` Ezequiel Garcia
2015-02-25 12:30     ` Ezequiel Garcia
2015-02-25 13:12     ` James Hartley
2015-02-25 13:12       ` James Hartley
2015-02-25 15:15       ` Maxime Ripard
2015-02-25 15:15         ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1425138690.24292.49.camel@x220 \
    --to=pebolle@tiscali.nl \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.