From: Johannes Berg <johannes@sipsolutions.net>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH 2/3] ath10k: always save/restore pci config space
Date: Mon, 02 Mar 2015 10:16:25 +0100 [thread overview]
Message-ID: <1425287785.1906.0.camel@sipsolutions.net> (raw)
In-Reply-To: <1425287344-30594-2-git-send-email-michal.kazior@tieto.com> (sfid-20150302_101036_254852_C8CA7C94)
On Mon, 2015-03-02 at 10:09 +0100, Michal Kazior wrote:
> The check isn't really necessary and couldn't even
> work because becase pci_restore_state() restores
> only first 64 bytes of PCI configuration space.
>
> This is necessary for future WoWLAN support.
> + pci_save_state(pdev);
> + pci_disable_device(pdev);
I believe the whole thing isn't necessary at all since the kernel's PCIe
layer will take care of it.
johannes
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes@sipsolutions.net>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/3] ath10k: always save/restore pci config space
Date: Mon, 02 Mar 2015 10:16:25 +0100 [thread overview]
Message-ID: <1425287785.1906.0.camel@sipsolutions.net> (raw)
In-Reply-To: <1425287344-30594-2-git-send-email-michal.kazior@tieto.com> (sfid-20150302_101036_254852_C8CA7C94)
On Mon, 2015-03-02 at 10:09 +0100, Michal Kazior wrote:
> The check isn't really necessary and couldn't even
> work because becase pci_restore_state() restores
> only first 64 bytes of PCI configuration space.
>
> This is necessary for future WoWLAN support.
> + pci_save_state(pdev);
> + pci_disable_device(pdev);
I believe the whole thing isn't necessary at all since the kernel's PCIe
layer will take care of it.
johannes
next prev parent reply other threads:[~2015-03-02 9:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-02 9:09 [PATCH 1/3] ath10k: fix some pci wake/sleep issues Michal Kazior
2015-03-02 9:09 ` Michal Kazior
2015-03-02 9:09 ` [PATCH 2/3] ath10k: always save/restore pci config space Michal Kazior
2015-03-02 9:09 ` Michal Kazior
2015-03-02 9:16 ` Johannes Berg [this message]
2015-03-02 9:16 ` Johannes Berg
2015-03-02 9:23 ` Michal Kazior
2015-03-02 9:23 ` Michal Kazior
2015-03-02 9:25 ` Johannes Berg
2015-03-02 9:25 ` Johannes Berg
2015-03-02 10:17 ` Michal Kazior
2015-03-02 10:17 ` Michal Kazior
2015-03-02 9:09 ` [PATCH 3/3] ath10k: re-enable pci device upon resume Michal Kazior
2015-03-02 9:09 ` Michal Kazior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425287785.1906.0.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.