From: Ian Campbell <ian.campbell@citrix.com>
To: Mike Latimer <mlatimer@suse.com>
Cc: ian.jackson@eu.citrix.com,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
wei.liu2@citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH] libxl: remove freemem_slack
Date: Mon, 2 Mar 2015 14:49:37 +0000 [thread overview]
Message-ID: <1425307777.21151.68.camel@citrix.com> (raw)
In-Reply-To: <2004339.Emeu92soFG@mlatimer1.dnsdhcp.provo.novell.com>
On Wed, 2015-02-25 at 18:01 -0700, Mike Latimer wrote:
> On Wednesday, February 25, 2015 03:07:25 PM Stefano Stabellini wrote:
> > freemem_slack accounts for the amount of memory to be left free in the
> > system because empirical experiments seem to demonstrate that is needed
> > for "stability reasons".
> >
> > As we don't have any actual data on these stability issues, remove it.
> >
> > Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>
> I just finished tested this patch in conjunction with the LIBXL_MAXMEM_CONSTANT
> removal patch. The freemem_slack zone is no longer reserved, and that aspect
> of the ballooning issue appears fixed.
>
> There is still a problem with xl's freemem loop, but we can investigate that
> further with slack out of the picture.
>
> From my side:
>
> Acked-by: Mike Latimer <mlatimer@suse.com>
Me too. I think I'm right in saying that this patch isn't affected by
any of the other on going discussion, so I've applied it. Please let me
know if I was wrong!
prev parent reply other threads:[~2015-03-02 14:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 15:07 [PATCH] libxl: remove freemem_slack Stefano Stabellini
2015-02-26 1:01 ` Mike Latimer
2015-03-02 14:49 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425307777.21151.68.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=mlatimer@suse.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.