From: Johannes Berg <johannes@sipsolutions.net>
To: Joe Perches <joe@perches.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 13/14] wireless: Use eth_<foo>_addr instead of memset
Date: Tue, 03 Mar 2015 09:16:57 +0100 [thread overview]
Message-ID: <1425370617.2450.3.camel@sipsolutions.net> (raw)
In-Reply-To: <0c710456e4875ff00c1a9fcff9378ed15110dcd3.1425354528.git.joe@perches.com>
On Mon, 2015-03-02 at 19:54 -0800, Joe Perches wrote:
> Use the built-in function instead of memset.
Please don't use <foo> in the title, especially not if the patch only
introduces usage of eth_zero_addr(). It's easier to look for in the
commit log without it.
Other than that, I guess I'll apply this, but I really wish there was a
way to distinguish more easily which of these require alignment and
which don't.
eth_zero_addr() doesn,t but is_zero_ether_addr() does. So does
ether_addr_copy(). Frankly, it's getting a bit confusing, so I can't
really fault anyone for using memset()/memcpy().
johannes
next prev parent reply other threads:[~2015-03-03 8:17 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 3:54 [PATCH net-next 00/14] Use eth_<foo>_addr instead of memset Joe Perches
2015-03-03 3:54 ` Joe Perches
2015-03-03 3:54 ` Joe Perches
2015-03-03 3:54 ` [ath9k-devel] " Joe Perches
2015-03-03 3:54 ` Joe Perches
2015-03-03 3:54 ` [PATCH net-next 01/14] etherdevice: Add eth_<foo>_addr CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS code Joe Perches
2015-03-03 13:19 ` Eric Dumazet
2015-03-03 18:25 ` Joe Perches
2015-03-03 18:42 ` Eric Dumazet
2015-03-03 19:07 ` Joe Perches
2015-03-03 19:27 ` David Miller
2015-03-03 19:41 ` Joe Perches
2015-03-03 19:56 ` Eric Dumazet
2015-03-03 19:58 ` David Miller
2015-03-03 20:04 ` Joe Perches
2015-03-03 22:01 ` David Miller
2015-03-03 19:26 ` David Miller
2015-03-03 3:54 ` [PATCH net-next 02/14] ethernet: Use eth_<foo>_addr instead of memset Joe Perches
2015-03-03 3:54 ` Joe Perches
2015-03-03 4:09 ` Jeff Kirsher
2015-03-03 4:09 ` Jeff Kirsher
2015-03-05 5:39 ` Don Fry
2015-03-03 3:54 ` [PATCH net-next 03/14] net: usb: " Joe Perches
2015-03-03 3:54 ` [PATCH net-next 04/14] wireless: " Joe Perches
2015-03-03 3:54 ` Joe Perches
2015-03-03 3:54 ` Joe Perches
2015-03-03 3:54 ` Joe Perches
2015-03-03 3:54 ` [ath9k-devel] " Joe Perches
2015-03-03 3:54 ` [PATCH net-next 05/14] netconsole: " Joe Perches
2015-03-03 3:54 ` [PATCH net-next 06/14] xen: " Joe Perches
2015-03-03 10:05 ` Ian Campbell
2015-03-03 10:05 ` Ian Campbell
2015-03-03 10:13 ` Wei Liu
2015-03-03 10:13 ` Wei Liu
2015-03-03 3:54 ` [PATCH net-next 07/14] 8021q: " Joe Perches
2015-03-03 3:54 ` [PATCH net-next 08/14] appletalk: " Joe Perches
2015-03-03 3:54 ` [PATCH net-next 09/14] atm: " Joe Perches
2015-03-03 3:54 ` [PATCH net-next 10/14] bluetooth: " Joe Perches
2015-03-03 7:04 ` Marcel Holtmann
2015-03-03 3:54 ` [PATCH net-next 11/14] ethernet: " Joe Perches
2015-03-03 3:54 ` [PATCH net-next 12/14] mac80211: " Joe Perches
2015-03-03 3:54 ` [PATCH net-next 13/14] wireless: " Joe Perches
2015-03-03 8:16 ` Johannes Berg [this message]
2015-03-03 8:37 ` Joe Perches
2015-03-03 8:44 ` Johannes Berg
2015-03-03 8:52 ` Joe Perches
2015-03-03 9:00 ` Johannes Berg
2015-03-03 9:00 ` Johannes Berg
2015-03-03 10:29 ` Joe Perches
2015-03-03 10:34 ` Johannes Berg
2015-03-03 18:57 ` David Miller
2015-03-03 19:03 ` Joe Perches
2015-03-03 19:27 ` David Miller
2015-03-03 19:16 ` Johannes Berg
2015-03-03 3:54 ` [PATCH net-next 14/14] l2tp: " Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425370617.2450.3.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.