From: Joe Perches <joe@perches.com>
To: David Miller <davem@davemloft.net>
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 01/14] etherdevice: Add eth_<foo>_addr CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS code
Date: Tue, 03 Mar 2015 12:04:28 -0800 [thread overview]
Message-ID: <1425413068.17273.58.camel@perches.com> (raw)
In-Reply-To: <20150303.145815.1129211297511474723.davem@davemloft.net>
On Tue, 2015-03-03 at 14:58 -0500, David Miller wrote:
> From: Joe Perches <joe@perches.com>
> Date: Tue, 03 Mar 2015 11:41:09 -0800
>
> > Until such time as the linux crosstools compilers are updated,
> > (they seem stuck on 4.6.3 from 3 years ago)
> > https://www.kernel.org/pub/tools/crosstool/
> > I think the series is a trivial, small improvement.
>
> You are even admitting that even for your specific case you are
> using 3+ year old compiler technology.
That's what I said. How is it an "admission"?
Those are the kernel.org "recommended" cross-compilers.
> These are slow paths, so correctness is the most important aspect.
>
> Converting these locations to consistently use eth_*() is fine,
> but then "optimizing" a 6 by memset for configuration paths when
> the compiler should be more than capable of doing this just fine
> is not convincing at all to me.
Swell, then perhaps you could simply skip 1/14.
next prev parent reply other threads:[~2015-03-03 20:04 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 3:54 [PATCH net-next 00/14] Use eth_<foo>_addr instead of memset Joe Perches
2015-03-03 3:54 ` Joe Perches
2015-03-03 3:54 ` Joe Perches
2015-03-03 3:54 ` [ath9k-devel] " Joe Perches
2015-03-03 3:54 ` Joe Perches
2015-03-03 3:54 ` [PATCH net-next 01/14] etherdevice: Add eth_<foo>_addr CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS code Joe Perches
2015-03-03 13:19 ` Eric Dumazet
2015-03-03 18:25 ` Joe Perches
2015-03-03 18:42 ` Eric Dumazet
2015-03-03 19:07 ` Joe Perches
2015-03-03 19:27 ` David Miller
2015-03-03 19:41 ` Joe Perches
2015-03-03 19:56 ` Eric Dumazet
2015-03-03 19:58 ` David Miller
2015-03-03 20:04 ` Joe Perches [this message]
2015-03-03 22:01 ` David Miller
2015-03-03 19:26 ` David Miller
2015-03-03 3:54 ` [PATCH net-next 02/14] ethernet: Use eth_<foo>_addr instead of memset Joe Perches
2015-03-03 3:54 ` Joe Perches
2015-03-03 4:09 ` Jeff Kirsher
2015-03-03 4:09 ` Jeff Kirsher
2015-03-05 5:39 ` Don Fry
2015-03-03 3:54 ` [PATCH net-next 03/14] net: usb: " Joe Perches
2015-03-03 3:54 ` [PATCH net-next 04/14] wireless: " Joe Perches
2015-03-03 3:54 ` Joe Perches
2015-03-03 3:54 ` Joe Perches
2015-03-03 3:54 ` Joe Perches
2015-03-03 3:54 ` [ath9k-devel] " Joe Perches
2015-03-03 3:54 ` [PATCH net-next 05/14] netconsole: " Joe Perches
2015-03-03 3:54 ` [PATCH net-next 06/14] xen: " Joe Perches
2015-03-03 10:05 ` Ian Campbell
2015-03-03 10:05 ` Ian Campbell
2015-03-03 10:13 ` Wei Liu
2015-03-03 10:13 ` Wei Liu
2015-03-03 3:54 ` [PATCH net-next 07/14] 8021q: " Joe Perches
2015-03-03 3:54 ` [PATCH net-next 08/14] appletalk: " Joe Perches
2015-03-03 3:54 ` [PATCH net-next 09/14] atm: " Joe Perches
2015-03-03 3:54 ` [PATCH net-next 10/14] bluetooth: " Joe Perches
2015-03-03 7:04 ` Marcel Holtmann
2015-03-03 3:54 ` [PATCH net-next 11/14] ethernet: " Joe Perches
2015-03-03 3:54 ` [PATCH net-next 12/14] mac80211: " Joe Perches
2015-03-03 3:54 ` [PATCH net-next 13/14] wireless: " Joe Perches
2015-03-03 8:16 ` Johannes Berg
2015-03-03 8:37 ` Joe Perches
2015-03-03 8:44 ` Johannes Berg
2015-03-03 8:52 ` Joe Perches
2015-03-03 9:00 ` Johannes Berg
2015-03-03 9:00 ` Johannes Berg
2015-03-03 10:29 ` Joe Perches
2015-03-03 10:34 ` Johannes Berg
2015-03-03 18:57 ` David Miller
2015-03-03 19:03 ` Joe Perches
2015-03-03 19:27 ` David Miller
2015-03-03 19:16 ` Johannes Berg
2015-03-03 3:54 ` [PATCH net-next 14/14] l2tp: " Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425413068.17273.58.camel@perches.com \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.