From: Brian Gerst <brgerst@gmail.com>
To: x86@kernel.org
Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, hpa@zytor.com
Subject: [PATCH 3/5] x86: Remove sys32_vm86_warning
Date: Tue, 3 Mar 2015 22:31:34 -0500 [thread overview]
Message-ID: <1425439896-8322-4-git-send-email-brgerst@gmail.com> (raw)
In-Reply-To: <1425439896-8322-1-git-send-email-brgerst@gmail.com>
The check against lastcomm is racy, and the message it produces isn't
necessary. vm86 support can be disabled on a 32-bit kernel also, and
doesn't have this message. Switch to sys_ni_syscall instead.
Signed-off-by: Brian Gerst <brgerst@gmail.com>
---
arch/x86/ia32/sys_ia32.c | 14 --------------
arch/x86/syscalls/syscall_32.tbl | 4 ++--
2 files changed, 2 insertions(+), 16 deletions(-)
diff --git a/arch/x86/ia32/sys_ia32.c b/arch/x86/ia32/sys_ia32.c
index 8e0ceec..719cd70 100644
--- a/arch/x86/ia32/sys_ia32.c
+++ b/arch/x86/ia32/sys_ia32.c
@@ -201,20 +201,6 @@ long sys32_fadvise64_64(int fd, __u32 offset_low, __u32 offset_high,
advice);
}
-long sys32_vm86_warning(void)
-{
- struct task_struct *me = current;
- static char lastcomm[sizeof(me->comm)];
-
- if (strncmp(lastcomm, me->comm, sizeof(lastcomm))) {
- compat_printk(KERN_INFO
- "%s: vm86 mode not supported on 64 bit kernel\n",
- me->comm);
- strncpy(lastcomm, me->comm, sizeof(lastcomm));
- }
- return -ENOSYS;
-}
-
asmlinkage ssize_t sys32_readahead(int fd, unsigned off_lo, unsigned off_hi,
size_t count)
{
diff --git a/arch/x86/syscalls/syscall_32.tbl b/arch/x86/syscalls/syscall_32.tbl
index b3560ec..ef8187f 100644
--- a/arch/x86/syscalls/syscall_32.tbl
+++ b/arch/x86/syscalls/syscall_32.tbl
@@ -119,7 +119,7 @@
110 i386 iopl sys_iopl
111 i386 vhangup sys_vhangup
112 i386 idle
-113 i386 vm86old sys_vm86old sys32_vm86_warning
+113 i386 vm86old sys_vm86old sys_ni_syscall
114 i386 wait4 sys_wait4 compat_sys_wait4
115 i386 swapoff sys_swapoff
116 i386 sysinfo sys_sysinfo compat_sys_sysinfo
@@ -172,7 +172,7 @@
163 i386 mremap sys_mremap
164 i386 setresuid sys_setresuid16
165 i386 getresuid sys_getresuid16
-166 i386 vm86 sys_vm86 sys32_vm86_warning
+166 i386 vm86 sys_vm86 sys_ni_syscall
167 i386 query_module
168 i386 poll sys_poll
169 i386 nfsservctl
--
2.1.0
next prev parent reply other threads:[~2015-03-04 3:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 3:31 [PATCH 0/5] x86: IA32 emulation cleanups Brian Gerst
2015-03-04 3:31 ` [PATCH 1/5] x86: Remove compat_ni_syscall() Brian Gerst
2015-03-04 5:27 ` [tip:x86/asm] x86/compat: " tip-bot for Brian Gerst
2015-03-04 3:31 ` [PATCH 2/5] x86: Merge native and compat 32-bit syscall tables Brian Gerst
2015-03-04 5:27 ` [tip:x86/asm] x86/compat: " tip-bot for Brian Gerst
2015-03-04 3:31 ` Brian Gerst [this message]
2015-03-04 5:28 ` [tip:x86/asm] x86/compat: Remove sys32_vm86_warning tip-bot for Brian Gerst
2015-03-04 3:31 ` [PATCH 4/5] x86: Use generic compat audit code Brian Gerst
2015-03-04 5:14 ` Ingo Molnar
2015-03-04 6:39 ` Brian Gerst
2015-03-04 7:09 ` Ingo Molnar
2015-03-04 14:52 ` David Drysdale
2015-03-04 3:31 ` [PATCH 5/5] x86: Clean up ia32/Makefile Brian Gerst
2015-03-04 5:24 ` [PATCH 0/5] x86: IA32 emulation cleanups Ingo Molnar
2015-03-04 6:22 ` Brian Gerst
2015-03-05 22:38 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425439896-8322-4-git-send-email-brgerst@gmail.com \
--to=brgerst@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.