All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: samuel.thibault@ens-lyon.org, stefano.stabellini@eu.citrix.com,
	ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH v2 2/5] libxc: split off xc_minios_common.c
Date: Thu, 5 Mar 2015 17:39:24 +0000	[thread overview]
Message-ID: <1425577164.25940.302.camel@citrix.com> (raw)
In-Reply-To: <1425398241-20807-3-git-send-email-wei.liu2@citrix.com>

On Tue, 2015-03-03 at 15:57 +0000, Wei Liu wrote:
> Rump kernel is going to use some but not all of the machinery previously
> in xc_minios.c.  Split the privcmd and gnttab code into its own file.
> This part is pure code motion.
> 
> But we also have to:
> 
>  - Alter the Makefile to build and link xc_minios_common.c too.
> 
>  - Rename some of the minios_*_ops symbols to have proper namespaceing
>    and make them have external linkage, so that the init code (which
>    remains in xc_minios.c) can reference them.
> 
>  - Call these *_ops symbols xc_*_ops so that we can mix and match in
>    the future.  This does not impede the existing mechanisms for
>    run-time overriding.  (But leave a comment next to the new
>    declarations in xc_private.h saying not to use these.)
> 
>  - Change map_frames_ex to minios_map_frames_ex if compiling on rump
>    kernel.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> Acked-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

Acked-by: Ian Campbell <ian.campbell@citrix.com>

  reply	other threads:[~2015-03-05 17:39 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-03 15:57 [PATCH v2 0/5] Build libxc on rump kernel Wei Liu
2015-03-03 15:57 ` [PATCH v2 1/5] NetBSDRump: provide evtchn.h Wei Liu
2015-03-05 17:39   ` Ian Campbell
2015-03-03 15:57 ` [PATCH v2 2/5] libxc: split off xc_minios_common.c Wei Liu
2015-03-05 17:39   ` Ian Campbell [this message]
2015-03-03 15:57 ` [PATCH v2 3/5] libxc: split off xc_netbsd_evtchn.c Wei Liu
2015-03-05 17:40   ` Ian Campbell
2015-03-06 11:22     ` Wei Liu
2015-03-03 15:57 ` [PATCH v2 4/5] libxc: minios: introduce abstraction for files[] Wei Liu
2015-03-03 15:57 ` [PATCH v2 5/5] libxc: rumpxen: provide xc_osdep_info Wei Liu
2015-03-03 16:05   ` Samuel Thibault
2015-03-03 16:41     ` Wei Liu
2015-03-03 16:58       ` Wei Liu
2015-03-03 16:59         ` Samuel Thibault
2015-03-03 17:06           ` Ian Campbell
2015-03-03 17:25           ` Wei Liu
2015-03-03 16:58       ` Samuel Thibault

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1425577164.25940.302.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=samuel.thibault@ens-lyon.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.