From: Paul Bolle <pebolle@tiscali.nl>
To: yong.wu@mediatek.com
Cc: Rob Herring <robh+dt@kernel.org>, Joerg Roedel <joro@8bytes.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Robin Murphy <robin.murphy@arm.com>,
Will Deacon <will.deacon@arm.com>,
Daniel Kurtz <djkurtz@google.com>, Tomasz Figa <tfiga@google.com>,
Lucas Stach <l.stach@pengutronix.de>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
linux-mediatek@lists.infradead.org,
Sasha Hauer <kernel@pengutronix.de>,
srv_heupstream@mediatek.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
iommu@lists.linux-foundation.org
Subject: Re: [PATCH 1/5] soc: mediatek: Add SMI driver
Date: Fri, 06 Mar 2015 12:30:45 +0100 [thread overview]
Message-ID: <1425641445.24292.280.camel@x220> (raw)
In-Reply-To: <1425638900-24989-2-git-send-email-yong.wu@mediatek.com>
On Fri, 2015-03-06 at 18:48 +0800, yong.wu@mediatek.com wrote:
> --- a/drivers/soc/mediatek/Kconfig
> +++ b/drivers/soc/mediatek/Kconfig
> @@ -20,3 +20,10 @@ config MT8173_PMIC_WRAP
> PMIC wrapper is a proprietary hardware in MT8173 to make
> communication protocols to access PMIC device.
> This driver implement access protocols for MT8173.
> +
> +config MTK_SMI
> + bool
Nit: make this one tab instead of 8 spaces, please.
> + help
> + Smi help enable/disable iommu in mt8173 and control the
> + clock of each local arbiter.
> + It should be true while MTK_IOMMU enable.
I don't think anyone using the *config tools will ever see this text, as
there's no prompt. So you might as well make this a comment or drop it
altogether.
Is this selected by more than just MTK_IOMMU (see 2/5)? If not, I think
MTK_SMI will be set and unset in lockstep with MTK_IOMMU. In other
words, you could as well use one Kconfig symbol.
Thanks,
Paul Bolle
WARNING: multiple messages have this Message-ID (diff)
From: pebolle@tiscali.nl (Paul Bolle)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] soc: mediatek: Add SMI driver
Date: Fri, 06 Mar 2015 12:30:45 +0100 [thread overview]
Message-ID: <1425641445.24292.280.camel@x220> (raw)
In-Reply-To: <1425638900-24989-2-git-send-email-yong.wu@mediatek.com>
On Fri, 2015-03-06 at 18:48 +0800, yong.wu at mediatek.com wrote:
> --- a/drivers/soc/mediatek/Kconfig
> +++ b/drivers/soc/mediatek/Kconfig
> @@ -20,3 +20,10 @@ config MT8173_PMIC_WRAP
> PMIC wrapper is a proprietary hardware in MT8173 to make
> communication protocols to access PMIC device.
> This driver implement access protocols for MT8173.
> +
> +config MTK_SMI
> + bool
Nit: make this one tab instead of 8 spaces, please.
> + help
> + Smi help enable/disable iommu in mt8173 and control the
> + clock of each local arbiter.
> + It should be true while MTK_IOMMU enable.
I don't think anyone using the *config tools will ever see this text, as
there's no prompt. So you might as well make this a comment or drop it
altogether.
Is this selected by more than just MTK_IOMMU (see 2/5)? If not, I think
MTK_SMI will be set and unset in lockstep with MTK_IOMMU. In other
words, you could as well use one Kconfig symbol.
Thanks,
Paul Bolle
next prev parent reply other threads:[~2015-03-06 11:30 UTC|newest]
Thread overview: 162+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-06 10:48 [RFC PATCH 0/5] MT8173 IOMMU support yong.wu-NuS5LvNUpcJWk0Htik3J/w
2015-03-06 10:48 ` yong.wu
2015-03-06 10:48 ` yong.wu at mediatek.com
[not found] ` <1425638900-24989-1-git-send-email-yong.wu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-03-06 10:48 ` [PATCH 1/5] soc: mediatek: Add SMI driver yong.wu-NuS5LvNUpcJWk0Htik3J/w
2015-03-06 10:48 ` yong.wu
2015-03-06 10:48 ` yong.wu at mediatek.com
2015-03-06 11:30 ` Paul Bolle [this message]
2015-03-06 11:30 ` Paul Bolle
2015-03-09 11:57 ` Yong Wu
2015-03-09 11:57 ` Yong Wu
2015-03-09 11:57 ` Yong Wu
2015-03-09 17:59 ` Paul Bolle
2015-03-09 17:59 ` Paul Bolle
2015-03-09 17:59 ` Paul Bolle
[not found] ` <1425923977.2317.4.camel-IWqWACnzNjzz+pZb47iToQ@public.gmane.org>
2015-03-09 21:54 ` Arnd Bergmann
2015-03-09 21:54 ` Arnd Bergmann
2015-03-09 21:54 ` Arnd Bergmann
2015-03-10 6:17 ` Yingjoe Chen
2015-03-10 6:17 ` Yingjoe Chen
2015-03-10 6:17 ` Yingjoe Chen
2015-03-09 3:26 ` Yingjoe Chen
2015-03-09 3:26 ` Yingjoe Chen
2015-03-09 3:26 ` Yingjoe Chen
2015-03-09 21:56 ` Arnd Bergmann
2015-03-09 21:56 ` Arnd Bergmann
2015-03-09 21:56 ` Arnd Bergmann
2015-03-10 6:27 ` Yingjoe Chen
2015-03-10 6:27 ` Yingjoe Chen
2015-03-10 6:27 ` Yingjoe Chen
2015-03-10 9:05 ` Arnd Bergmann
2015-03-10 9:05 ` Arnd Bergmann
2015-03-10 9:05 ` Arnd Bergmann
2015-03-10 9:24 ` Lucas Stach
2015-03-10 9:24 ` Lucas Stach
2015-03-10 9:24 ` Lucas Stach
[not found] ` <1425638900-24989-2-git-send-email-yong.wu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-03-09 11:03 ` Sascha Hauer
2015-03-09 11:03 ` Sascha Hauer
2015-03-09 11:03 ` Sascha Hauer
2015-03-06 10:48 ` [PATCH 2/5] iommu/mediatek: Add mt8173 IOMMU driver yong.wu-NuS5LvNUpcJWk0Htik3J/w
2015-03-06 10:48 ` yong.wu
2015-03-06 10:48 ` yong.wu at mediatek.com
2015-03-08 4:12 ` Tomasz Figa
2015-03-08 4:12 ` Tomasz Figa
[not found] ` <CAAFQd5CWOjT6XU8PFT+PO6Q2mb-i+iMTtZPSo_RDNUzpOO6TvA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-12 14:16 ` Yong Wu
2015-03-12 14:16 ` Yong Wu
2015-03-12 14:16 ` Yong Wu
[not found] ` <1425638900-24989-3-git-send-email-yong.wu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-03-06 10:58 ` Will Deacon
2015-03-06 10:58 ` Will Deacon
2015-03-06 10:58 ` Will Deacon
[not found] ` <20150306105821.GE22377-5wv7dgnIgG8@public.gmane.org>
2015-03-09 12:11 ` Yong Wu
2015-03-09 12:11 ` Yong Wu
2015-03-09 12:11 ` Yong Wu
2015-03-17 15:14 ` Will Deacon
2015-03-17 15:14 ` Will Deacon
2015-03-17 15:14 ` Will Deacon
2015-03-06 17:15 ` Mitchel Humpherys
2015-03-06 17:15 ` Mitchel Humpherys
2015-03-06 17:15 ` Mitchel Humpherys
[not found] ` <vnkwwq2unj2y.fsf-Yf+dfxj6toJBVvN7MMdr1KRtKmQZhJ7pQQ4Iyu8u01E@public.gmane.org>
2015-03-09 12:16 ` Yong Wu
2015-03-09 12:16 ` Yong Wu
2015-03-09 12:16 ` Yong Wu
2015-03-09 16:57 ` Mitchel Humpherys
2015-03-09 16:57 ` Mitchel Humpherys
2015-03-09 8:24 ` Daniel Kurtz
2015-03-09 8:24 ` Daniel Kurtz
2015-03-09 8:24 ` Daniel Kurtz
2015-03-09 11:11 ` Tomasz Figa
2015-03-09 11:11 ` Tomasz Figa
2015-03-09 11:11 ` Tomasz Figa
[not found] ` <CAAFQd5AhTe=d9tXN8kaRah_GiZYYxG0cD0up=cbHkSfbBnXmvQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-09 14:46 ` Yingjoe Chen
2015-03-09 14:46 ` Yingjoe Chen
2015-03-09 14:46 ` Yingjoe Chen
2015-03-09 17:00 ` Tomasz Figa
2015-03-09 17:00 ` Tomasz Figa
2015-03-09 17:00 ` Tomasz Figa
[not found] ` <CAAFQd5DpXxyoNiTGC4YYnpXeKo43XXrC+my6KWOV1pGq1jw6Aw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-10 3:41 ` Yingjoe Chen
2015-03-10 3:41 ` Yingjoe Chen
2015-03-10 3:41 ` Yingjoe Chen
2015-03-10 4:06 ` Tomasz Figa
2015-03-10 4:06 ` Tomasz Figa
2015-03-10 4:06 ` Tomasz Figa
2015-03-11 10:53 ` Tomasz Figa
2015-03-11 10:53 ` Tomasz Figa
[not found] ` <CAAFQd5ASywTX7P9L8cogBbBTra0W1=oVxeWfK5=K7L+SR2xaFA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-18 11:22 ` Yong Wu
2015-03-18 11:22 ` Yong Wu
2015-03-18 11:22 ` Yong Wu
2015-03-20 19:14 ` Robin Murphy
2015-03-20 19:14 ` Robin Murphy
[not found] ` <550C71B3.1080708-5wv7dgnIgG8@public.gmane.org>
2015-04-14 6:50 ` Yong Wu
2015-04-14 6:50 ` Yong Wu
2015-04-14 6:50 ` Yong Wu
2015-03-27 9:41 ` Tomasz Figa
2015-03-27 9:41 ` Tomasz Figa
2015-03-27 9:41 ` Tomasz Figa
[not found] ` <CAAFQd5DOzFmfXki8GwUC75VQFEWzxBUNUgOtSuRtV6tc27kD2A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-04-14 6:31 ` Yong Wu
2015-04-14 6:31 ` Yong Wu
2015-04-14 6:31 ` Yong Wu
2015-04-15 2:20 ` Tomasz Figa
2015-04-15 2:20 ` Tomasz Figa
2015-04-15 2:20 ` Tomasz Figa
[not found] ` <CAAFQd5Db+DacQYa1pdr=w5JpU76AYa-Xhd20wHBF=F6m=Efokw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-04-15 7:06 ` Yong Wu
2015-04-15 7:06 ` Yong Wu
2015-04-15 7:06 ` Yong Wu
2015-04-15 7:41 ` Tomasz Figa
2015-04-15 7:41 ` Tomasz Figa
2015-04-15 7:41 ` Tomasz Figa
2015-04-29 6:23 ` Yong Wu
2015-04-29 6:23 ` Yong Wu
2015-04-29 6:23 ` Yong Wu
2015-03-06 10:48 ` [PATCH 3/5] dt-bindings: mediatek: Add smi dts binding yong.wu-NuS5LvNUpcJWk0Htik3J/w
2015-03-06 10:48 ` yong.wu
2015-03-06 10:48 ` yong.wu at mediatek.com
[not found] ` <1425638900-24989-4-git-send-email-yong.wu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-03-06 11:13 ` Mark Rutland
2015-03-06 11:13 ` Mark Rutland
2015-03-06 11:13 ` Mark Rutland
2015-03-09 12:55 ` Yong Wu
2015-03-09 12:55 ` Yong Wu
2015-03-09 12:55 ` Yong Wu
2015-04-14 9:07 ` Yong Wu
2015-04-14 9:07 ` Yong Wu
2015-04-14 9:07 ` Yong Wu
2015-04-14 10:06 ` Mark Rutland
2015-04-14 10:06 ` Mark Rutland
2015-04-14 10:06 ` Mark Rutland
2015-04-14 13:49 ` Yong Wu
2015-04-14 13:49 ` Yong Wu
2015-04-14 13:49 ` Yong Wu
2015-04-14 13:55 ` Yong Wu
2015-04-14 13:55 ` Yong Wu
2015-04-14 13:55 ` Yong Wu
2015-04-14 13:56 ` Mark Rutland
2015-04-14 13:56 ` Mark Rutland
2015-03-06 14:48 ` Sergei Shtylyov
2015-03-06 14:48 ` Sergei Shtylyov
2015-03-06 14:48 ` Sergei Shtylyov
2015-03-09 12:32 ` Yong Wu
2015-03-09 12:32 ` Yong Wu
2015-03-09 12:32 ` Yong Wu
2015-03-06 10:48 ` [PATCH 4/5] dt-bindings: iommu: Add binding for mediatek IOMMU yong.wu-NuS5LvNUpcJWk0Htik3J/w
2015-03-06 10:48 ` yong.wu
2015-03-06 10:48 ` yong.wu at mediatek.com
[not found] ` <1425638900-24989-5-git-send-email-yong.wu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-03-06 11:21 ` Mark Rutland
2015-03-06 11:21 ` Mark Rutland
2015-03-06 11:21 ` Mark Rutland
2015-03-09 11:30 ` Yong Wu
2015-03-09 11:30 ` Yong Wu
2015-03-09 11:30 ` Yong Wu
2015-03-06 10:48 ` [PATCH 5/5] dts: mt8173: Add iommu/smi nodes for mt8173 yong.wu-NuS5LvNUpcJWk0Htik3J/w
2015-03-06 10:48 ` yong.wu
2015-03-06 10:48 ` yong.wu at mediatek.com
[not found] ` <1425638900-24989-6-git-send-email-yong.wu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-03-07 15:20 ` Daniel Kurtz
2015-03-07 15:20 ` Daniel Kurtz
2015-03-07 15:20 ` Daniel Kurtz
[not found] ` <CAGS+omDotK45t5a4FKpU9z2Bg=e9aWDpXt+mCX92CM-2ZMQGNg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-09 12:18 ` Yong Wu
2015-03-09 12:18 ` Yong Wu
2015-03-09 12:18 ` Yong Wu
-- strict thread matches above, loose matches on Subject: below --
2015-03-06 10:37 [RFC PATCH 0/5] MT8173 IOMMU support yong.wu
[not found] ` <1425638270-24903-1-git-send-email-yong.wu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-03-06 10:37 ` [PATCH 1/5] soc: mediatek: Add SMI driver yong.wu-NuS5LvNUpcJWk0Htik3J/w
2015-03-06 10:37 ` yong.wu
2015-03-06 10:37 ` yong.wu at mediatek.com
[not found] ` <1425638270-24903-2-git-send-email-yong.wu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-03-09 7:51 ` Daniel Kurtz
2015-03-09 7:51 ` Daniel Kurtz
2015-03-09 7:51 ` Daniel Kurtz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425641445.24292.280.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=djkurtz@google.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@google.com \
--cc=will.deacon@arm.com \
--cc=yong.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.