All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Yakir Yang <ykk@rock-chips.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
	mmind00@googlemail.com, marcheu@chromium.org,
	linux-kernel@vger.kernel.org, dianders@chromium.org,
	linux-rockchip@lists.infradead.org,
	dri-devel@lists.freedesktop.org,
	Andy Yan <andy.yan@rock-chips.com>,
	Russell King <rmk+kernel@arm.linux.org.uk>
Subject: Re: [PATCH v2 1/3] drm: bridge/dw_hdmi: fixed codec style
Date: Sun, 08 Mar 2015 23:48:01 -0700	[thread overview]
Message-ID: <1425883681.5428.1.camel@perches.com> (raw)
In-Reply-To: <1425876496.2745.21.camel@perches.com>

On Sun, 2015-03-08 at 21:48 -0700, Joe Perches wrote:

> Shouldn't all of these be static?

Don't mind me.  These shouldn't be static.

I was a bit mislead by the commit message.

I think it'd be better not to put patch-like
+ and - lines in the commit description.

cheers, Joe

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Yakir Yang <ykk@rock-chips.com>
Cc: David Airlie <airlied@linux.ie>,
	Russell King <rmk+kernel@arm.linux.org.uk>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	djkurtz@chromium.org, Fabio Estevam <fabio.estevam@freescale.com>,
	Shawn Guo <shawn.guo@linaro.org>, Rob Clark <robdclark@gmail.com>,
	Mark Yao <mark.yao@rock-chips.com>,
	Daniel Vetter <daniel@ffwll.ch>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Andy Yan <andy.yan@rock-chips.com>,
	mmind00@googlemail.com, dianders@chromium.org,
	marcheu@chromium.org, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v2 1/3] drm: bridge/dw_hdmi: fixed codec style
Date: Sun, 08 Mar 2015 23:48:01 -0700	[thread overview]
Message-ID: <1425883681.5428.1.camel@perches.com> (raw)
In-Reply-To: <1425876496.2745.21.camel@perches.com>

On Sun, 2015-03-08 at 21:48 -0700, Joe Perches wrote:

> Shouldn't all of these be static?

Don't mind me.  These shouldn't be static.

I was a bit mislead by the commit message.

I think it'd be better not to put patch-like
+ and - lines in the commit description.

cheers, Joe


  reply	other threads:[~2015-03-09  6:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <425876114-22392-1-git-send-email-ykk@rock-chips.com>
2015-03-09  4:42 ` [PATCH v2 1/3] drm: bridge/dw_hdmi: fixed codec style Yakir Yang
2015-03-09  4:48   ` Joe Perches
2015-03-09  6:48     ` Joe Perches [this message]
2015-03-09  6:48       ` Joe Perches
2015-03-09  7:23       ` yakir
2015-03-09  7:05   ` Daniel Kurtz
2015-03-09  7:05     ` Daniel Kurtz
2015-03-09  7:25     ` yakir
2015-03-09  4:42 ` [PATCH v2 2/3] drm: bridge/dw_hdmi_rockchip: improve hdmi eye-diagram test Yakir Yang
2015-03-09  4:42 ` [PATCH v2 3/3] drm: bridge/dw_hdmi: improve hdmi single-end test Yakir Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1425883681.5428.1.camel@perches.com \
    --to=joe@perches.com \
    --cc=andy.yan@rock-chips.com \
    --cc=dianders@chromium.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fabio.estevam@freescale.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=marcheu@chromium.org \
    --cc=mmind00@googlemail.com \
    --cc=rmk+kernel@arm.linux.org.uk \
    --cc=ykk@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.