From: Joe Perches <joe@perches.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Thomas Petazzoni" <thomas.petazzoni@free-electrons.com>,
"Noralf Trønnes" <noralf@tronnes.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: fbtft: Do not use binary constants
Date: Tue, 10 Mar 2015 14:50:41 -0700 [thread overview]
Message-ID: <1426024241.18060.53.camel@perches.com> (raw)
In-Reply-To: <1426023283-27561-1-git-send-email-geert@linux-m68k.org>
On Tue, 2015-03-10 at 22:34 +0100, Geert Uytterhoeven wrote:
> Gcc < 4.3 doesn't understand binary constants (0b*):
trivia:
> diff --git a/drivers/staging/fbtft/fb_hx8340bn.c b/drivers/staging/fbtft/fb_hx8340bn.c
[]
> @@ -156,10 +156,10 @@ static int set_var(struct fbtft_par *par)
> static int set_gamma(struct fbtft_par *par, unsigned long *curves)
> {
> unsigned long mask[] = {
static const
> - 0b1111, 0b1111, 0b11111, 0b1111, 0b1111, 0b1111, 0b11111,
> - 0b111, 0b111, 0b111, 0b111, 0b111, 0b111, 0b11, 0b11,
> - 0b1111, 0b1111, 0b11111, 0b1111, 0b1111, 0b1111, 0b11111,
> - 0b111, 0b111, 0b111, 0b111, 0b111, 0b111, 0b0, 0b0 };
> + 0x0f, 0x0f, 0x1f, 0x0f, 0x0f, 0x0f, 0x1f, 0x07, 0x07, 0x07,
> + 0x07, 0x07, 0x07, 0x03, 0x03, 0x0f, 0x0f, 0x1f, 0x0f, 0x0f,
> + 0x0f, 0x1f, 0x07, 0x07, 0x07, 0x07, 0x07, 0x07, 0x00, 0x00,
> + };
[]
> diff --git a/drivers/staging/fbtft/fb_hx8347d.c b/drivers/staging/fbtft/fb_hx8347d.c
[]
> @@ -115,10 +115,9 @@ static void set_addr_win(struct fbtft_par *par, int xs, int ys, int xe, int ye)
> static int set_gamma(struct fbtft_par *par, unsigned long *curves)
> {
> unsigned long mask[] = {
etc...
next prev parent reply other threads:[~2015-03-10 21:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 21:34 [PATCH] staging: fbtft: Do not use binary constants Geert Uytterhoeven
2015-03-10 21:50 ` Joe Perches [this message]
2015-03-10 21:53 ` Geert Uytterhoeven
2015-03-20 12:54 ` Greg Kroah-Hartman
2015-03-20 15:19 ` Geert Uytterhoeven
2015-03-24 22:07 ` Greg Kroah-Hartman
-- strict thread matches above, loose matches on Subject: below --
2015-03-20 15:21 Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426024241.18060.53.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noralf@tronnes.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.