Re: [PATCH] staging: fbtft: Do not use binary constants

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Fri, Mar 20, 2015 at 04:19:36PM +0100, Geert Uytterhoeven wrote:
> Hi Greg,
> 
> On Fri, Mar 20, 2015 at 1:54 PM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > On Tue, Mar 10, 2015 at 10:34:43PM +0100, Geert Uytterhoeven wrote:
> >> Gcc < 4.3 doesn't understand binary constants (0b*):
> >>
> >> drivers/staging/fbtft/fbtft-sysfs.c:156:19: error: invalid suffix "b111" on integer constant
> >> drivers/staging/fbtft/fb_hx8340bn.c:159:3: error: invalid suffix "b1111" on integer constant
> >> drivers/staging/fbtft/fb_hx8340bn.c:159:11: error: invalid suffix "b1111" on integer constant
> >> drivers/staging/fbtft/fb_hx8340bn.c:159:19: error: invalid suffix "b11111" on integer constant
> >> drivers/staging/fbtft/fb_hx8340bn.c:159:28: error: invalid suffix "b1111" on integer constant
> >> drivers/staging/fbtft/fb_hx8340bn.c:159:36: error: invalid suffix "b1111" on integer constant
> >> drivers/staging/fbtft/fb_hx8340bn.c:159:44: error: invalid suffix "b1111" on integer constant
> >> drivers/staging/fbtft/fb_hx8340bn.c:159:52: error: invalid suffix "b11111" on integer constant
> >> drivers/staging/fbtft/fb_hx8340bn.c:160:3: error: invalid suffix "b111" on integer constant
> >> ...
> >>
> >> Hence use hexadecimal constants (0x*) instead.
> >>
> >> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> >> ---
> >> This is against v4.0-rc3. In next-20150310 there are two whitespace
> >> differences.
> >
> > Can you make it against -next?  I can't get this to apply as-is, sorry.
> 
> Sure, will do. I was wondering if you wanted to sent this fix to Linus for v4.0,
> as the build is broken for gcc < 4.3, and keep the changes in -next for v4.1.

Nah, it's just staging code, it's ok to be broken on old compilers :)

thanks,

greg k-h