From: Ian Campbell <ian.campbell@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>,
svenvan.van@gmail.com, Wei Liu <wei.liu2@citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH] libxc: use xc_dom_panic when decompressor is not supported
Date: Wed, 11 Mar 2015 12:29:39 +0000 [thread overview]
Message-ID: <1426076979.21353.228.camel@citrix.com> (raw)
In-Reply-To: <54F9A0E1.7050409@citrix.com>
On Fri, 2015-03-06 at 12:43 +0000, Andrew Cooper wrote:
> On 06/03/2015 11:33, Wei Liu wrote:
> > State explicitly that specific decompressor is not supported by libxc.
> > Without this change, libxc error message only says the provided kernel
> > is invalid, which is misleading.
> >
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > Cc: Ian Campbell <ian.campbell@citrix.com>
> > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > Cc: svenvan.van@gmail.com
>
> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked + applied.
> I did the triage of this issue when reported on #xen. `xl -vvv
> create...` does eventually reveal the issue, where `xl create` gives an
> incorrect error message.
>
> (although s/__FUNCTION__/__func__/ to be more C99 if you have cause to
> resubmit)
FWIW this whole file uses __FUNCTION__, probably would be better to do
xc_dom_* in a big sweep instead of piecemeal. In any case I haven't
waited for a resubmit.
prev parent reply other threads:[~2015-03-11 12:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-06 11:33 [PATCH] libxc: use xc_dom_panic when decompressor is not supported Wei Liu
2015-03-06 12:43 ` Andrew Cooper
2015-03-11 12:29 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426076979.21353.228.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=svenvan.van@gmail.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.