All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: anthony.perard@citrix.com, ian.jackson@eu.citrix.com,
	xen-devel@lists.xen.org
Subject: Re: [PATCH 1/2] tools: OVMF parallel build
Date: Wed, 11 Mar 2015 16:41:32 +0000	[thread overview]
Message-ID: <1426092092.21353.322.camel@citrix.com> (raw)
In-Reply-To: <1425305938.21151.48.camel@citrix.com>

On Mon, 2015-03-02 at 14:18 +0000, Ian Campbell wrote:
> On Mon, 2015-03-02 at 10:52 +0000, Wei Liu wrote:
> > Though it doesn't work with make's "-j" option, the build system of OVMF
> > has an option to specify parallel threads used to run the build.
> > 
> > Using 4 threads to build OVMF looks like a sensible default.
> 
> It's a bit arbitrary, but it'll do, I suppose.
> 
> It's worth noting that this won't interact with gnu makes token handling
> which is used to make sure there are only N processes across the
> recursive build. So this will consume 1 token but launch 4 threads. So
> if -j4 is used you'll actually get 7 things happening.
> 
> I think we can live with that.
> 
> So I'm happy with the patch, but I'd like to give others a chance to
> disagree before applying.

They had their chance...
> 
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > Cc: Anthony Perard <anthony.perard@citrix.com>
> 
> Acked-by: Ian Campbell <ian.campbell@citrix.com>

... applied.

Did the distclean issue which the second patch was addressing get fixed
another way or is there a patch outstanding somewhere?

  parent reply	other threads:[~2015-03-11 16:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-02 10:52 [PATCH 0/2] Two patches for OVMF build system Wei Liu
2015-03-02 10:52 ` [PATCH 1/2] tools: OVMF parallel build Wei Liu
2015-03-02 14:18   ` Ian Campbell
2015-03-02 15:17     ` Wei Liu
2015-03-11 16:41     ` Ian Campbell [this message]
2015-03-11 16:47       ` Wei Liu
2015-03-02 10:52 ` [PATCH 2/2] tools: provide distclean target for OVMF Wei Liu
2015-03-02 14:20   ` Ian Campbell
2015-03-02 14:31     ` Wei Liu
2015-03-02 14:35       ` Ian Campbell
2015-03-02 14:45         ` Wei Liu
2015-03-02 14:54           ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1426092092.21353.322.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=anthony.perard@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.