From: Johannes Berg <johannes@sipsolutions.net>
To: Nicholas Mc Guire <hofrat@osadl.org>
Cc: Jeff Haran <Jeff.Haran@citrix.com>,
Valdis.Kletnieks@vt.edu, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
ath10k@lists.infradead.org, Kalle Valo <kvalo@qca.qualcomm.com>,
Pat Erley <pat-lkml@erley.org>, Bj??rn Mork <bjorn@mork.no>
Subject: Re: [PATCH RFC v2] ath10k: move code from parameter list into a function
Date: Wed, 11 Mar 2015 20:10:10 +0100 [thread overview]
Message-ID: <1426101010.1904.9.camel@sipsolutions.net> (raw)
In-Reply-To: <1426100519-20636-1-git-send-email-hofrat@osadl.org> (sfid-20150311_200723_379167_2BC79246)
On Wed, 2015-03-11 at 15:01 -0400, Nicholas Mc Guire wrote:
> Putting code into the parameter list of wait_event_timeout() might be
> legal C-code but not really readable - the "inline" code is simply
> moved into a function and that passed to wait_event_timeout() as the
> condition.
Arguably, that's even more unreadable since if you don't know this macro
well you might assume the function is called only once, which is clearly
not true...
Don't get me wrong, I'm not opposed to this change, but if you ask me
it's not completely clear that this makes it more readable.
johannes
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes@sipsolutions.net>
To: Nicholas Mc Guire <hofrat@osadl.org>
Cc: Kalle Valo <kvalo@qca.qualcomm.com>,
Valdis.Kletnieks@vt.edu, Bj??rn Mork <bjorn@mork.no>,
Jeff Haran <Jeff.Haran@citrix.com>,
Pat Erley <pat-lkml@erley.org>,
ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC v2] ath10k: move code from parameter list into a function
Date: Wed, 11 Mar 2015 20:10:10 +0100 [thread overview]
Message-ID: <1426101010.1904.9.camel@sipsolutions.net> (raw)
In-Reply-To: <1426100519-20636-1-git-send-email-hofrat@osadl.org> (sfid-20150311_200723_379167_2BC79246)
On Wed, 2015-03-11 at 15:01 -0400, Nicholas Mc Guire wrote:
> Putting code into the parameter list of wait_event_timeout() might be
> legal C-code but not really readable - the "inline" code is simply
> moved into a function and that passed to wait_event_timeout() as the
> condition.
Arguably, that's even more unreadable since if you don't know this macro
well you might assume the function is called only once, which is clearly
not true...
Don't get me wrong, I'm not opposed to this change, but if you ask me
it's not completely clear that this makes it more readable.
johannes
next prev parent reply other threads:[~2015-03-11 19:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 19:01 [PATCH RFC v2] ath10k: move code from parameter list into a function Nicholas Mc Guire
2015-03-11 19:01 ` Nicholas Mc Guire
2015-03-11 19:10 ` Johannes Berg [this message]
2015-03-11 19:10 ` Johannes Berg
2015-03-11 19:15 ` Nicholas Mc Guire
2015-03-11 19:15 ` Nicholas Mc Guire
2015-03-11 19:22 ` Johannes Berg
2015-03-11 19:22 ` Johannes Berg
2015-03-11 20:29 ` Sergei Shtylyov
2015-03-11 20:29 ` Sergei Shtylyov
2015-03-12 7:32 ` Nicholas Mc Guire
2015-03-12 7:32 ` Nicholas Mc Guire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426101010.1904.9.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Jeff.Haran@citrix.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=ath10k@lists.infradead.org \
--cc=bjorn@mork.no \
--cc=hofrat@osadl.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pat-lkml@erley.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.