Re: [PATCH] xen: avoid updating node affinity twice when removing a CPU from a cpupool

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1139 bytes --]

On Thu, 2015-03-12 at 14:52 +0000, George Dunlap wrote:
> On 03/12/2015 01:45 PM, Dario Faggioli wrote:

> > Patch below, and attached. However, I think the correct thing to do
> > would be to just revert 93be8285 "update domU's node-affinity on the
> > cpupool_unassign_cpu() path", wouldn't it?
> 
> Funny you should mention that... 
>
Being the author of this mess... I'm more sorry than amused, but yes I
can imagine it's funny to see. :-)

> one of the things I was thinking of
> suggesting was trying to move the domain_update_node_affinity() out of
> cpupool.c and into schedule.c, somewhere on the path that brings up a
> cpu or assigns it to a pool, specifically so that the lack of symmetry
> didn't trip anybody up.  
>
That would be good, indeed.

> Now that I find out it already *has* tripped someone up, I think we had
> definitely better do something about it. :-)
>
:-)

> Let me take a look and see what seems sensible...
> 
Ok, let me know what you discover. If you're too busy and you want me to
have a look, just say it (I'll do my best to get it right this
time! ;-P)

Regards,
Dario

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel