From: Axel Lin <axel.lin@ingics.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
Hongzhou Yang <hongzhou.yang@mediatek.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: [PATCH RFT] pinctrl: mediatek: mtk-common: Fix a typo in mtk_eint_set_type
Date: Sat, 14 Mar 2015 15:15:18 +0800 [thread overview]
Message-ID: <1426317318.15425.1.camel@phoenix> (raw)
Fix a typo when checking level trigger irq type.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
Hi Hongzhou,
This looks like a typo, but I don't have the datasheet so please confirm if
this patch is correct or not.
drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
index 493294c..cc27929 100644
--- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
+++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
@@ -934,7 +934,7 @@ static int mtk_eint_set_type(struct irq_data *d,
else
pctl->eint_dual_edges[d->hwirq] = 0;
- if (type & (IRQ_TYPE_LEVEL_LOW | IRQ_TYPE_EDGE_FALLING)) {
+ if (type & (IRQ_TYPE_LEVEL_LOW | IRQ_TYPE_LEVEL_HIGH)) {
reg = mtk_eint_get_offset(pctl, d->hwirq,
eint_offsets->pol_clr);
writel(mask, reg);
--
1.9.1
next reply other threads:[~2015-03-14 7:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-14 7:15 Axel Lin [this message]
2015-03-14 7:33 ` [PATCH RFT] pinctrl: mediatek: mtk-common: Fix a typo in mtk_eint_set_type Axel Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426317318.15425.1.camel@phoenix \
--to=axel.lin@ingics.com \
--cc=hongzhou.yang@mediatek.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.