* [PATCH RFT] pinctrl: mediatek: mtk-common: Fix a typo in mtk_eint_set_type
@ 2015-03-14 7:15 Axel Lin
2015-03-14 7:33 ` Axel Lin
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2015-03-14 7:15 UTC (permalink / raw)
To: Linus Walleij; +Cc: Matthias Brugger, Hongzhou Yang, linux-gpio@vger.kernel.org
Fix a typo when checking level trigger irq type.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
Hi Hongzhou,
This looks like a typo, but I don't have the datasheet so please confirm if
this patch is correct or not.
drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
index 493294c..cc27929 100644
--- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
+++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
@@ -934,7 +934,7 @@ static int mtk_eint_set_type(struct irq_data *d,
else
pctl->eint_dual_edges[d->hwirq] = 0;
- if (type & (IRQ_TYPE_LEVEL_LOW | IRQ_TYPE_EDGE_FALLING)) {
+ if (type & (IRQ_TYPE_LEVEL_LOW | IRQ_TYPE_LEVEL_HIGH)) {
reg = mtk_eint_get_offset(pctl, d->hwirq,
eint_offsets->pol_clr);
writel(mask, reg);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH RFT] pinctrl: mediatek: mtk-common: Fix a typo in mtk_eint_set_type
2015-03-14 7:15 [PATCH RFT] pinctrl: mediatek: mtk-common: Fix a typo in mtk_eint_set_type Axel Lin
@ 2015-03-14 7:33 ` Axel Lin
0 siblings, 0 replies; 2+ messages in thread
From: Axel Lin @ 2015-03-14 7:33 UTC (permalink / raw)
To: Linus Walleij; +Cc: Matthias Brugger, Hongzhou Yang, linux-gpio@vger.kernel.org
2015-03-14 15:15 GMT+08:00 Axel Lin <axel.lin@ingics.com>:
> Fix a typo when checking level trigger irq type.
Sorry. I take it back, current code should be correct.
Regards,
Axel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-14 7:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-14 7:15 [PATCH RFT] pinctrl: mediatek: mtk-common: Fix a typo in mtk_eint_set_type Axel Lin
2015-03-14 7:33 ` Axel Lin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.