Re: [Outreachy kernel] [PATCH 3/6] Staging: iio: Prefer using the BIT macro

[Cristina Opriceana <cristina.opriceana@gmail.com>]

> e.g:
> 
> 2 << 14 = BIT(15) | BIT(14)
> 7 << 13 = BIT(15) | BIT(14) | BIT(13)
> 
> You could also search for the datasheet to see the correct bit
> definitions.
> 
That's a very nice idea, thank you! 

> >>  /* Command Control Bits */
> >>
> >> -#define AD9834_B28           (1 << 13)
> >> -#define AD9834_HLB           (1 << 12)
> >> -#define AD9834_FSEL          (1 << 11)
> >> -#define AD9834_PSEL          (1 << 10)
> >> -#define AD9834_PIN_SW                (1 << 9)
> >> -#define AD9834_RESET         (1 << 8)
> >> -#define AD9834_SLEEP1                (1 << 7)
> >> -#define AD9834_SLEEP12               (1 << 6)
> >> -#define AD9834_OPBITEN               (1 << 5)
> >> -#define AD9834_SIGN_PIB              (1 << 4)
> >> -#define AD9834_DIV2          (1 << 3)
> >> -#define AD9834_MODE          (1 << 1)
> >> +#define AD9834_B28           BIT(13)
> >> +#define AD9834_HLB           BIT(12)
> >> +#define AD9834_FSEL          BIT(11)
> >> +#define AD9834_PSEL          BIT(10)
> >> +#define AD9834_PIN_SW                BIT(9)
> >
> > You could clean up the indentation at the same time.
> >
> > julia

I did check the indentation, cause it seemed to be inappropriate for me
too, but they are aligned in my sources. I don't know why git diff
messes with the indentation so badly. I thought it might be the
mix of tabs and spaces, but this is not the case, since they are aligned
at 2 tabs.
I'll try to modify them by hand, without the script, to see if this
problem still persists.

Thanks,
Cristina