All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cristina Opriceana <cristina.opriceana@gmail.com>
To: Daniel Baluta <daniel.baluta@intel.com>
Cc: outreachy-kernel@googlegroups.com, Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [Outreachy kernel] [PATCH 5/6] Staging: iio: Alignment should match open parenthesis
Date: Sat, 14 Mar 2015 14:58:38 +0200	[thread overview]
Message-ID: <1426337918.6721.4.camel@Inspiron> (raw)
In-Reply-To: <CAEnQRZAMAj7OquWzwAutp7NVoHs15bkcgUE3wSoO49YcpEKFuA@mail.gmail.com>


> There are still few places to be fixed:
> * ad9834_show_out0_wavetype_available
> * ad9834_show_out1_wavetype_available
> 
> thanks,
> Daniel.

I had doubts about fixing these because I had the following options:
1. Aligning them would go beyond the limit of 80 characters for the
second line.
2. Put static on top and make the function definition inconsistent with
the others.

static 
ssize_t ad9834_show_out0_wavetype_available(...)



  reply	other threads:[~2015-03-14 12:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-14  1:33 [PATCH 0/6] Staging: iio/frequency: Fix style issues Cristina Opriceana
2015-03-14  1:35 ` [PATCH 1/6] Staging: iio: Remove space after type cast Cristina Opriceana
2015-03-14  1:36 ` [PATCH 2/6] Staging: iio: Remove explicit comparison to NULL Cristina Opriceana
2015-03-14  1:37 ` [PATCH 3/6] Staging: iio: Prefer using the BIT macro Cristina Opriceana
2015-03-14  6:36   ` [Outreachy kernel] " Julia Lawall
2015-03-14  7:41     ` Daniel Baluta
2015-03-14 12:40       ` Cristina Opriceana
2015-03-14  1:38 ` [PATCH 4/6] Staging: iio: Do not use multiple blank lines Cristina Opriceana
2015-03-14  1:39 ` [PATCH 5/6] Staging: iio: Alignment should match open parenthesis Cristina Opriceana
2015-03-14  6:34   ` [Outreachy kernel] " Julia Lawall
2015-03-14  7:50     ` Daniel Baluta
2015-03-14 12:58       ` Cristina Opriceana [this message]
2015-03-14 14:17         ` Julia Lawall
2015-03-14  1:40 ` [PATCH 6/6] Staging: iio: Use braces on all arms of if statement Cristina Opriceana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1426337918.6721.4.camel@Inspiron \
    --to=cristina.opriceana@gmail.com \
    --cc=daniel.baluta@intel.com \
    --cc=julia.lawall@lip6.fr \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.