Problem about usleep function in tools/hotplug/Linux/xendomains.in

Problem about usleep function in tools/hotplug/Linux/xendomains.in

[Fabio Fantoni]

If usleep binary is missed in dom0 xendomains script use its function 
instead but as it is done now always rounds down to the nearest integer 
number, and in case it is less than 1 becomes 0.
So for example in dom0 like those I use (debian) withoutusleep binaryall 
small usleep in the script are null.

A solution can be to replace:
>   usleep()
>   {
>     if [ -n "$1" ]
>     then
>       sleep $(( $1 / 1000000 ))
>     fi
>   }
with:
>   usleep()
>   {
>     if [ -n "$1" ]
>     then
>       sleep $(printf %f "$1e-6")
>     fi
>   }

This case is ok with sleep from gnu coreutils but if there are other 
cases with different sleep command only integer and also without usleep 
that I don't know will be not working.

Can This solution be better that the actual and I must do a patch or 
someone have a better solution?

Thanks for any reply and sorry for my bad english.

Re: Problem about usleep function in tools/hotplug/Linux/xendomains.in

[Ian Campbell]

On Mon, 2015-03-16 at 12:00 +0100, Fabio Fantoni wrote:
> If usleep binary is missed in dom0 xendomains script use its function 
> instead but as it is done now always rounds down to the nearest integer 
> number, and in case it is less than 1 becomes 0.
> So for example in dom0 like those I use (debian) withoutusleep binaryall 
> small usleep in the script are null.
> 
> A solution can be to replace:
> >   usleep()
> >   {
> >     if [ -n "$1" ]
> >     then
> >       sleep $(( $1 / 1000000 ))
> >     fi
> >   }
> with:
> >   usleep()
> >   {
> >     if [ -n "$1" ]
> >     then
> >       sleep $(printf %f "$1e-6")
> >     fi
> >   }
> 
> This case is ok with sleep from gnu coreutils but if there are other 
> cases with different sleep command only integer and also without usleep 
> that I don't know will be not working.
> 
> Can This solution be better that the actual and I must do a patch or 
> someone have a better solution?

sleep $(( ( ($1 + 999999) / 1000000 ))

Should do the right thing (i.e. round up), I think.

Ian.

> 
> Thanks for any reply and sorry for my bad english.