From: Dario Faggioli <dario.faggioli@citrix.com>
To: "xumengpanda@gmail.com" <xumengpanda@gmail.com>
Cc: "Keir (Xen.org)" <keir@xen.org>,
George Dunlap <George.Dunlap@citrix.com>,
"JBeulich@suse.com" <JBeulich@suse.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH 2/7] xen: sched_rt: implement the .free_pdata hook
Date: Tue, 17 Mar 2015 13:00:14 +0000 [thread overview]
Message-ID: <1426597213.32500.75.camel@citrix.com> (raw)
In-Reply-To: <CAENZ-+=q9q9jUG5DgVzFp7pwKNMLTwgBADbgtdR6BKXEvGf-pg@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1244 bytes --]
On Mon, 2015-03-16 at 14:23 -0400, Meng Xu wrote:
> 2015-03-16 13:10 GMT-04:00 Dario Faggioli <dario.faggioli@citrix.com>:
> > We discussed about this issue before, here:
> > http://lists.xen.org/archives/html/xen-devel/2014-09/msg02765.html
> >
> > But, as far as it looks, the code we ended up merging still had the
> > issue (i.e., it did not have the hook implemented)!
> >
> > I was working a bit on/off (for family reasons) in that period, so I
> > can't really tell how that happened. :-/
> > Not a big deal... this code is marked as experimental for a reason, but
> > it probably make sense to double check that anything else similar
> > happened, can you do that?
>
> Sure! I will review that problem, do the double check and let you know
> the result!
>
I've re-tested that scenario myself, and verified it's working before
sending this series. :-)
What I was suggesting was for you to double check that everything that
you have in your local dev repo(s)/branch(es) (either from that time or
more recent ones) is actually upstream.
In fact, looking at the referenced thread, it looks like this issue
shouldn't have been present in the code we have checked-in, and yet,
there it was.
Regards,
Dario
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2015-03-17 13:00 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 17:04 [PATCH 0/7] Improving dumping of scheduler related info Dario Faggioli
2015-03-16 17:04 ` [PATCH 1/7] xen: sched_rt: avoid ASSERT()ing on runq dump if there are no domains Dario Faggioli
2015-03-16 18:18 ` George Dunlap
2015-03-16 20:31 ` Meng Xu
2015-03-17 10:41 ` Jan Beulich
2015-03-17 11:00 ` Dario Faggioli
2015-03-16 17:04 ` [PATCH 2/7] xen: sched_rt: implement the .free_pdata hook Dario Faggioli
2015-03-16 17:10 ` Dario Faggioli
2015-03-16 18:23 ` Meng Xu
2015-03-17 13:00 ` Dario Faggioli [this message]
2015-03-16 18:17 ` Meng Xu
2015-03-16 18:21 ` George Dunlap
2015-03-16 17:05 ` [PATCH 3/7] xen: rework locking for dump of scheduler info (debug-key r) Dario Faggioli
2015-03-16 18:41 ` George Dunlap
2015-03-16 20:04 ` Meng Xu
2015-03-17 10:54 ` Jan Beulich
2015-03-17 11:05 ` George Dunlap
2015-03-17 11:18 ` Dario Faggioli
2015-03-17 11:25 ` Jan Beulich
2015-03-17 11:32 ` George Dunlap
2015-03-17 11:43 ` Jan Beulich
2015-03-17 12:01 ` George Dunlap
2015-03-17 11:14 ` Dario Faggioli
2015-03-17 11:31 ` Jan Beulich
2015-03-16 17:05 ` [PATCH 4/7] xen: print online pCPUs and free pCPUs when dumping scheduler info Dario Faggioli
2015-03-16 18:37 ` Juergen Gross
2015-03-16 18:46 ` George Dunlap
2015-03-17 10:59 ` Jan Beulich
2015-03-16 17:05 ` [PATCH 5/7] xen: make dumping vcpu info look better Dario Faggioli
2015-03-16 18:48 ` George Dunlap
2015-03-16 20:06 ` Meng Xu
2015-03-16 17:05 ` [PATCH 6/7] xen: sched_credit2: more info when dumping Dario Faggioli
2015-03-16 18:50 ` George Dunlap
2015-03-16 17:05 ` [PATCH 7/7] xen: sched_rt: print useful affinity " Dario Faggioli
2015-03-16 19:05 ` George Dunlap
2015-03-17 13:51 ` Dario Faggioli
2015-03-16 20:30 ` Meng Xu
2015-03-17 11:10 ` George Dunlap
2015-03-17 11:28 ` Jan Beulich
2015-03-18 1:05 ` Meng Xu
2015-03-17 14:12 ` Dario Faggioli
2015-03-18 1:07 ` Meng Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426597213.32500.75.camel@citrix.com \
--to=dario.faggioli@citrix.com \
--cc=George.Dunlap@citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xen.org \
--cc=xumengpanda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.