From: Paul Bolle <pebolle-IWqWACnzNjzz+pZb47iToQ@public.gmane.org>
To: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
Cc: Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Bin Liu <binmlist-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Brian Hutchinson
<b.hutchman-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>,
Matthijs van Duin
<matthijsvanduin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Rusty Russell <rusty-8n+1lVoiYb80n/F98K4Iww@public.gmane.org>
Subject: Re: [PATCH v2] phy: Add a driver for dm816x USB PHY
Date: Wed, 18 Mar 2015 12:13:31 +0100 [thread overview]
Message-ID: <1426677211.15575.27.camel@x220> (raw)
In-Reply-To: <1426637554-27178-1-git-send-email-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
Two trivialities I failed the spot the first time.
On Tue, 2015-03-17 at 17:12 -0700, Tony Lindgren wrote:
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index 2962de2..c858c2b 100644
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> +config PHY_DM816X_USB
> + tristate "TI dm816x USB PHY driver"
> + depends on ARCH_OMAP2PLUS
> + select GENERIC_PHY
> + help
> + Enable this for dm81xx USB to work."
> +
A trailing double quote.
> --- /dev/null
> +++ b/drivers/phy/phy-dm816x-usb.c
> +MODULE_ALIAS("platform: dm816x_usb");
That space looks odd. Will it be removed by scripts/mod/file2alias.c? Or
will it end up in the mdule, in modules.alias, and presumably break
something (I'm not sure what, actually)?
There are currently six other instances MODULE_ALIAS() that have a space
there. That would mean they're all broken, somehow, which would be
unlikely, so I guess it's just a stylistic nit.
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Paul Bolle <pebolle@tiscali.nl>
To: Tony Lindgren <tony@atomide.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
linux-omap@vger.kernel.org, Bin Liu <binmlist@gmail.com>,
Brian Hutchinson <b.hutchman@gmail.com>,
Felipe Balbi <balbi@ti.com>,
Matthijs van Duin <matthijsvanduin@gmail.com>,
Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH v2] phy: Add a driver for dm816x USB PHY
Date: Wed, 18 Mar 2015 12:13:31 +0100 [thread overview]
Message-ID: <1426677211.15575.27.camel@x220> (raw)
In-Reply-To: <1426637554-27178-1-git-send-email-tony@atomide.com>
Two trivialities I failed the spot the first time.
On Tue, 2015-03-17 at 17:12 -0700, Tony Lindgren wrote:
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index 2962de2..c858c2b 100644
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> +config PHY_DM816X_USB
> + tristate "TI dm816x USB PHY driver"
> + depends on ARCH_OMAP2PLUS
> + select GENERIC_PHY
> + help
> + Enable this for dm81xx USB to work."
> +
A trailing double quote.
> --- /dev/null
> +++ b/drivers/phy/phy-dm816x-usb.c
> +MODULE_ALIAS("platform: dm816x_usb");
That space looks odd. Will it be removed by scripts/mod/file2alias.c? Or
will it end up in the mdule, in modules.alias, and presumably break
something (I'm not sure what, actually)?
There are currently six other instances MODULE_ALIAS() that have a space
there. That would mean they're all broken, somehow, which would be
unlikely, so I guess it's just a stylistic nit.
Paul Bolle
next prev parent reply other threads:[~2015-03-18 11:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 0:12 [PATCH v2] phy: Add a driver for dm816x USB PHY Tony Lindgren
[not found] ` <1426637554-27178-1-git-send-email-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2015-03-18 11:13 ` Paul Bolle [this message]
2015-03-18 11:13 ` Paul Bolle
2015-03-18 14:56 ` Tony Lindgren
2015-03-18 14:56 ` Tony Lindgren
2015-03-18 15:07 ` Kishon Vijay Abraham I
2015-03-18 15:07 ` Kishon Vijay Abraham I
2015-03-18 15:26 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426677211.15575.27.camel@x220 \
--to=pebolle-iwqwacnznjzz+pzb47itoq@public.gmane.org \
--cc=b.hutchman-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=balbi-l0cyMroinI0@public.gmane.org \
--cc=binmlist-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=kishon-l0cyMroinI0@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matthijsvanduin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=rusty-8n+1lVoiYb80n/F98K4Iww@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.