From: Ian Campbell <ian.campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Jim Fehlig <jfehlig@suse.com>,
Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH 2/3] libxl: Domain destroy: unlock userdata earlier
Date: Wed, 18 Mar 2015 12:20:18 +0000 [thread overview]
Message-ID: <1426681218.18247.354.camel@citrix.com> (raw)
In-Reply-To: <20150317173423.GC23662@zion.uk.xensource.com>
On Tue, 2015-03-17 at 17:34 +0000, Wei Liu wrote:
> On Tue, Mar 17, 2015 at 09:30:58AM -0600, Jim Fehlig wrote:
> > From: Ian Jackson <ian.jackson@eu.citrix.com>
> >
> > Unlock the userdata before we actually call xc_domain_destroy. This
> > leaves open the possibility that other libxl callers will see the
> > half-destroyed domain (with no devices, paused), but this is fine.
> >
> > Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
> > CC: Wei Liu <wei.liu2@citrix.com>
> > Reviewed-by: Jim Fehlig <jfehlig@suse.com>
> > Tested-by: Jim Fehlig <jfehlig@suse.com>
>
> Acked-by: Wei Liu <wei.liu2@citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
I'm not sure if this is safe/sensible to apply without the preceding
patch which I had a comment on.
Ian.
next prev parent reply other threads:[~2015-03-18 12:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-17 15:30 [PATCH 0/3] libxl: Fixes from Ian Jackson Jim Fehlig
2015-03-17 15:30 ` [PATCH 1/3] libxl: In domain death search, start search at first domid we want Jim Fehlig
2015-03-17 17:34 ` Wei Liu
2015-03-18 12:19 ` Ian Campbell
2015-03-18 17:47 ` Jim Fehlig
2015-03-19 10:22 ` Ian Campbell
2015-03-17 15:30 ` [PATCH 2/3] libxl: Domain destroy: unlock userdata earlier Jim Fehlig
2015-03-17 17:34 ` Wei Liu
2015-03-18 12:20 ` Ian Campbell [this message]
2015-03-18 17:52 ` Jim Fehlig
2015-03-20 11:58 ` Ian Campbell
2015-03-17 15:30 ` [PATCH 3/3] libxl: Domain destroy: fork Jim Fehlig
2015-03-17 18:04 ` Wei Liu
2015-03-18 12:28 ` Ian Campbell
2015-03-18 12:27 ` Ian Campbell
2015-03-20 15:14 ` Jim Fehlig
2015-03-20 16:03 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426681218.18247.354.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=jfehlig@suse.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.