From: Ian Campbell <ian.campbell@citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: xen-devel@lists.xenproject.org, ian.jackson@eu.citrix.com,
wei.liu2@citrix.com, stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH v2 4/5] libxl: vcpuset: Remove useless limit on max_vcpus.
Date: Wed, 18 Mar 2015 13:13:48 +0000 [thread overview]
Message-ID: <1426684428.14291.19.camel@citrix.com> (raw)
In-Reply-To: <1426278403-12959-5-git-send-email-konrad.wilk@oracle.com>
On Fri, 2015-03-13 at 16:26 -0400, Konrad Rzeszutek Wilk wrote:
> The check is superflous. If the 'max_vcpus' (argument
> value) is greater than pCPU and --ignore-host has not
> been supplied we would print an warning and return
> and not call this code.
>
> If the --ignore-host parameter had been used we would
> never end up in this condition and enforce 'max_vcpus'.
>
> The only time it would be invoked is if max_vcpus < host_cpu
> in which case it would set max_vcpus to max_vcpus.
>
> In short - it is dead code.
>
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
next prev parent reply other threads:[~2015-03-18 13:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 20:26 [PATCH v2] Fix xl vcpu-set to decrease amount of vCPUS without warnining Konrad Rzeszutek Wilk
2015-03-13 20:26 ` [PATCH v2 1/5] libxl: Add ERROR_NOTFOUND for libxl_domain_info when it cannot find the domain Konrad Rzeszutek Wilk
2015-03-18 13:03 ` Ian Campbell
2015-03-13 20:26 ` [PATCH v2 2/5] libxl: vcpuset: Return error values Konrad Rzeszutek Wilk
2015-03-18 13:06 ` Ian Campbell
2015-03-18 13:08 ` Ian Campbell
2015-03-18 14:09 ` Dario Faggioli
2015-03-18 14:15 ` Konrad Rzeszutek Wilk
2015-03-18 13:37 ` Konrad Rzeszutek Wilk
2015-03-13 20:26 ` [PATCH v2 3/5] libxl: vcpuset: Check max_vcpus argument against the maximum number of vCPUs the guest has set Konrad Rzeszutek Wilk
2015-03-18 13:11 ` Ian Campbell
2015-03-13 20:26 ` [PATCH v2 4/5] libxl: vcpuset: Remove useless limit on max_vcpus Konrad Rzeszutek Wilk
2015-03-18 13:13 ` Ian Campbell [this message]
2015-03-13 20:26 ` [PATCH v2 5/5] libxl: vcpu-set - allow to decrease vcpu count on overcommitted guests (v3) Konrad Rzeszutek Wilk
2015-03-18 13:15 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426684428.14291.19.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.