[PATCH] runqemu-internal: Add cpio support for qemux86 so that we can boot poky-tiny images

[PATCH] runqemu-internal: Add cpio support for qemux86 so that we can boot poky-tiny images

[Richard Purdie]

poky-tiny generates cpio.gz images, add support for these so we can boot
them using runqemu.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

diff --git a/scripts/runqemu-internal b/scripts/runqemu-internal
index 6594dc3..2db5566 100755
--- a/scripts/runqemu-internal
+++ b/scripts/runqemu-internal
@@ -408,6 +408,11 @@ if [ "$MACHINE" = "qemux86" ]; then
         KERNCMDLINE="vga=0 uvesafb.mode_option=640x480-32 root=$DROOT rw mem=$QEMU_MEMORY $KERNEL_NETWORK_CMD"
         QEMUOPTIONS="$QEMU_NETWORK_CMD -cpu $CPU_SUBTYPE $ROOTFS_OPTIONS $QEMU_UI_OPTIONS"
     fi
+    if [ "${FSTYPE:0:4}" = "cpio" ]; then
+        KERNCMDLINE="vga=0 uvesafb.mode_option=640x480-32 root=/dev/ram0 rw mem=$QEMU_MEMORY $KERNEL_NETWORK_CMD"
+        QEMUOPTIONS="$QEMU_NETWORK_CMD -cpu $CPU_SUBTYPE -initrd $ROOTFS $QEMU_UI_OPTIONS"
+    fi
+
     if [ "$FSTYPE" = "nfs" ]; then
         if [ "$NFS_SERVER" = "192.168.7.1" -a ! -d "$NFS_DIR" ]; then
             echo "Error: NFS mount point $ROOTFS doesn't exist."

Re: [PATCH] runqemu-internal: Add cpio support for qemux86 so that we can boot poky-tiny images

[Bernhard Reutner-Fischer]

On March 19, 2015 12:33:30 PM GMT+01:00, Richard Purdie <richard.purdie@linuxfoundation.org> wrote:
>poky-tiny generates cpio.gz images, add support for these so we can
>boot
>them using runqemu.
>
>Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
>
>diff --git a/scripts/runqemu-internal b/scripts/runqemu-internal
>index 6594dc3..2db5566 100755
>--- a/scripts/runqemu-internal
>+++ b/scripts/runqemu-internal
>@@ -408,6 +408,11 @@ if [ "$MACHINE" = "qemux86" ]; then
>KERNCMDLINE="vga=0 uvesafb.mode_option=640x480-32 root=$DROOT rw
>mem=$QEMU_MEMORY $KERNEL_NETWORK_CMD"
>QEMUOPTIONS="$QEMU_NETWORK_CMD -cpu $CPU_SUBTYPE $ROOTFS_OPTIONS
>$QEMU_UI_OPTIONS"
>     fi
>+    if [ "${FSTYPE:0:4}" = "cpio" ]; then

Is that positional handling mandated by the POSIX-1003.1 2008 shell?

Otherwise case $FSTYPE in ..
Would cleanup the rest if the mess below..

With that clarified it changed
Acked-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>

Thanks,

>+        KERNCMDLINE="vga=0 uvesafb.mode_option=640x480-32
>root=/dev/ram0 rw mem=$QEMU_MEMORY $KERNEL_NETWORK_CMD"
>+        QEMUOPTIONS="$QEMU_NETWORK_CMD -cpu $CPU_SUBTYPE -initrd
>$ROOTFS $QEMU_UI_OPTIONS"
>+    fi
>+
>     if [ "$FSTYPE" = "nfs" ]; then
>         if [ "$NFS_SERVER" = "192.168.7.1" -a ! -d "$NFS_DIR" ]; then
>             echo "Error: NFS mount point $ROOTFS doesn't exist."

Re: [PATCH] runqemu-internal: Add cpio support for qemux86 so that we can boot poky-tiny images

[Bernhard Reutner-Fischer]

On March 19, 2015 5:39:12 PM GMT+01:00, Bernhard Reutner-Fischer <rep.dot.nop@gmail.com> wrote:
>On March 19, 2015 12:33:30 PM GMT+01:00, Richard Purdie
><richard.purdie@linuxfoundation.org> wrote:
>>poky-tiny generates cpio.gz images, add support for these so we can
>>boot
>>them using runqemu.
>>
>>Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
>>
>>diff --git a/scripts/runqemu-internal b/scripts/runqemu-internal
>>index 6594dc3..2db5566 100755
>>--- a/scripts/runqemu-internal
>>+++ b/scripts/runqemu-internal
>>@@ -408,6 +408,11 @@ if [ "$MACHINE" = "qemux86" ]; then
>>KERNCMDLINE="vga=0 uvesafb.mode_option=640x480-32 root=$DROOT rw
>>mem=$QEMU_MEMORY $KERNEL_NETWORK_CMD"
>>QEMUOPTIONS="$QEMU_NETWORK_CMD -cpu $CPU_SUBTYPE $ROOTFS_OPTIONS
>>$QEMU_UI_OPTIONS"
>>     fi
>>+    if [ "${FSTYPE:0:4}" = "cpio" ]; then
>
>Is that positional handling mandated by the POSIX-1003.1 2008 shell?
>
>Otherwise case $FSTYPE in ..
>Would cleanup the rest if the mess below..

of the if, even ;)

I didn't see :n:m ranges in http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_06_02

but maybe I didn't look at the right spot?

Thanks,
>
>With that clarified it changed
>Acked-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
>
>Thanks,

Re: [PATCH] runqemu-internal: Add cpio support for qemux86 so that we can boot poky-tiny images

[Richard Purdie]

On Thu, 2015-03-19 at 17:39 +0100, Bernhard Reutner-Fischer wrote:
> On March 19, 2015 12:33:30 PM GMT+01:00, Richard Purdie <richard.purdie@linuxfoundation.org> wrote:
> >poky-tiny generates cpio.gz images, add support for these so we can
> >boot
> >them using runqemu.
> >
> >Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> >
> >diff --git a/scripts/runqemu-internal b/scripts/runqemu-internal
> >index 6594dc3..2db5566 100755
> >--- a/scripts/runqemu-internal
> >+++ b/scripts/runqemu-internal
> >@@ -408,6 +408,11 @@ if [ "$MACHINE" = "qemux86" ]; then
> >KERNCMDLINE="vga=0 uvesafb.mode_option=640x480-32 root=$DROOT rw
> >mem=$QEMU_MEMORY $KERNEL_NETWORK_CMD"
> >QEMUOPTIONS="$QEMU_NETWORK_CMD -cpu $CPU_SUBTYPE $ROOTFS_OPTIONS
> >$QEMU_UI_OPTIONS"
> >     fi
> >+    if [ "${FSTYPE:0:4}" = "cpio" ]; then
> 
> Is that positional handling mandated by the POSIX-1003.1 2008 shell?
> 
> Otherwise case $FSTYPE in ..
> Would cleanup the rest if the mess below..

Its a bash script so it doesn't need to be mandated by POSIX and I was
trying to be minimally invasive given the point we're at in the release
cycle, the rest of the file uses that syntax.

I would like to change some other things but it isn't really the time...

Cheers,

Richard