From: Pawel Moll <pawel.moll@arm.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: "virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH] virtio_mmio: generation support
Date: Mon, 23 Mar 2015 11:50:22 +0000 [thread overview]
Message-ID: <1427111422.3726.23.camel@arm.com> (raw)
In-Reply-To: <87y4n3vuh6.fsf@rustcorp.com.au>
On Thu, 2015-03-12 at 02:07 +0000, Rusty Russell wrote:
> "Michael S. Tsirkin" <mst@redhat.com> writes:
> > virtio_mmio currently lacks generation support which
> > makes multi-byte field access racy.
> > Fix by getting the value at offset 0xfc for version 2
> > devices. Nothing we can do for version 1, so return
> > generation id 0.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> >
> > Pawel, you mentioned you have a working virtio 1.0
> > hypervisor, can you pls confirm this works correctly?
Again, belated
Acked-by: Pawel Moll <pawel.moll@arm.com>
although not yet tested-by...
Paweł
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
WARNING: multiple messages have this Message-ID (diff)
From: Pawel Moll <pawel.moll@arm.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH] virtio_mmio: generation support
Date: Mon, 23 Mar 2015 11:50:22 +0000 [thread overview]
Message-ID: <1427111422.3726.23.camel@arm.com> (raw)
In-Reply-To: <87y4n3vuh6.fsf@rustcorp.com.au>
On Thu, 2015-03-12 at 02:07 +0000, Rusty Russell wrote:
> "Michael S. Tsirkin" <mst@redhat.com> writes:
> > virtio_mmio currently lacks generation support which
> > makes multi-byte field access racy.
> > Fix by getting the value at offset 0xfc for version 2
> > devices. Nothing we can do for version 1, so return
> > generation id 0.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> >
> > Pawel, you mentioned you have a working virtio 1.0
> > hypervisor, can you pls confirm this works correctly?
Again, belated
Acked-by: Pawel Moll <pawel.moll@arm.com>
although not yet tested-by...
Paweł
next prev parent reply other threads:[~2015-03-23 11:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-05 22:09 [PATCH] virtio_mmio: generation support Michael S. Tsirkin
2015-03-09 8:40 ` Michael S. Tsirkin
2015-03-09 8:40 ` Michael S. Tsirkin
2015-03-12 2:07 ` Rusty Russell
2015-03-12 2:07 ` Rusty Russell
2015-03-23 11:50 ` Pawel Moll [this message]
2015-03-23 11:50 ` Pawel Moll
-- strict thread matches above, loose matches on Subject: below --
2015-03-05 22:09 Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427111422.3726.23.camel@arm.com \
--to=pawel.moll@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.