From: Ian Campbell <ian.campbell@citrix.com>
To: "Hu, Robert" <robert.hu@intel.com>
Cc: "wei.liu2@citrix.com" <wei.liu2@citrix.com>,
"Pang, LongtaoX" <longtaox.pang@intel.com>,
"Ian.Jackson@eu.citrix.com" <Ian.Jackson@eu.citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [OSSTEST Nested PATCH 2/6] Add and expose some testsupport APIs
Date: Tue, 24 Mar 2015 09:45:19 +0000 [thread overview]
Message-ID: <1427190319.21742.314.camel@citrix.com> (raw)
In-Reply-To: <9E79D1C9A97CFD4097BCE431828FDD31B6F924@SHSMSX103.ccr.corp.intel.com>
On Tue, 2015-03-24 at 03:34 +0000, Hu, Robert wrote:
> > Make it an option to the function which creates the configuration in the
> > first place. Quoting myself from earlier in this very thread:
> Then we still need to designate to use e1000 device somewhere; say, in
> ts-nested-setup, we store this designation in runvar.
> Then when creating the config, according to your proposal, we plumbing
> such designation through $xopts, since we see it in runvar. Are you OK
> with such implementation?
I'm not sure if this should be a runvar or just something which
ts-nested-setup knows. That's one for Ian J to decide.
> But if like above, I would prefer to altering/manipulating guest configation
> directly in ts-nested-setup after normal guest is setup. Since this is more
> simple and constrained to nested case only.
IMHO, this should be properly integrated into the configuration
creation, not fixed up later as an adhoc step.
Ian.
next prev parent reply other threads:[~2015-03-24 9:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 12:09 [OSSTEST Nested PATCH 2/6] Add and expose some testsupport APIs Pang, LongtaoX
2015-03-20 12:20 ` Ian Campbell
2015-03-20 12:59 ` Pang, LongtaoX
2015-03-20 13:37 ` Ian Campbell
2015-03-23 6:31 ` Hu, Robert
2015-03-23 9:49 ` Ian Campbell
2015-03-24 3:25 ` Hu, Robert
2015-03-24 9:43 ` Ian Campbell
2015-03-24 3:34 ` Hu, Robert
2015-03-24 9:45 ` Ian Campbell [this message]
2015-03-24 11:41 ` Ian Jackson
2015-03-23 16:20 ` Pang, LongtaoX
2015-03-23 16:45 ` Ian Campbell
2015-03-23 17:29 ` Wei Liu
2015-03-23 17:36 ` Ian Campbell
2015-03-24 5:13 ` Pang, LongtaoX
2015-03-24 8:50 ` Wei Liu
2015-03-24 9:36 ` Ian Campbell
2015-03-23 17:19 ` Wei Liu
2015-03-23 17:32 ` Ian Campbell
-- strict thread matches above, loose matches on Subject: below --
2015-03-17 18:16 [OSSTEST Nested PATCH 0/6] Introduction of netsted HVM test job longtao.pang
2015-03-17 18:16 ` [OSSTEST Nested PATCH 2/6] Add and expose some testsupport APIs longtao.pang
2015-03-19 16:27 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427190319.21742.314.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=longtaox.pang@intel.com \
--cc=robert.hu@intel.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.