From: Ian Campbell <ian.campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: xen-devel@lists.xenproject.org, ian.jackson@eu.citrix.com
Subject: Re: [PATCH OSSTEST 1/2] uboot: use "readlink -f"
Date: Tue, 24 Mar 2015 12:23:22 +0000 [thread overview]
Message-ID: <1427199802.21742.384.camel@citrix.com> (raw)
In-Reply-To: <1427197552-29042-2-git-send-email-wei.liu2@citrix.com>
On Tue, 2015-03-24 at 11:45 +0000, Wei Liu wrote:
> If the path is not a symlink, readlink by default returns empty string.
> Use "-f" to always return canonical path. This fixes the problem that
> xenpolicy file not getting loaded (because it is not a symlink).
>
> Also change another spot that calls readlink to get xen binary path in
> case in the future we decide to not use symlink.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
next prev parent reply other threads:[~2015-03-24 12:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 11:45 [PATCH OSSTEST 0/2] Uboot patches for XSM test case Wei Liu
2015-03-24 11:45 ` [PATCH OSSTEST 1/2] uboot: use "readlink -f" Wei Liu
2015-03-24 12:23 ` Ian Campbell [this message]
2015-03-27 9:28 ` Ian Campbell
2015-03-27 10:46 ` [PATCH OSSTEST v2 1/2] uboot: do not use readlink on xsm policy Ian Campbell
2015-03-31 12:27 ` Ian Jackson
2015-03-27 10:46 ` [PATCH OSSTEST v2 2/2] uboot: make flask loading address host property Ian Campbell
2015-03-27 16:31 ` [PATCH OSSTEST 1/2] uboot: use "readlink -f" Atom2
2015-03-27 17:06 ` Ian Campbell
2015-03-24 11:45 ` [PATCH OSSTEST 2/2] uboot: make flask loading address host property Wei Liu
2015-03-24 12:23 ` Ian Campbell
2015-03-25 10:18 ` Ian Campbell
2015-03-27 14:54 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427199802.21742.384.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.