From: Ian Campbell <ian.campbell@citrix.com>
To: Julien Grall <julien.grall@linaro.org>
Cc: Keir Fraser <keir@xen.org>,
Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
Julien Grall <julien.grall@citrix.com>,
Jan Beulich <JBeulich@suse.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 1/2] introduce gprintk()
Date: Tue, 24 Mar 2015 15:42:23 +0000 [thread overview]
Message-ID: <1427211743.21742.445.camel@citrix.com> (raw)
In-Reply-To: <55117ED0.30509@linaro.org>
On Tue, 2015-03-24 at 15:12 +0000, Julien Grall wrote:
> Hi Ian,
>
> On 24/03/2015 14:20, Ian Campbell wrote:
> > @@ -1709,7 +1707,6 @@ static void do_cp15_64(struct cpu_user_regs *regs,
> > break;
> > default:
> > {
> > -#ifndef NDEBUG
> > struct hsr_cp64 cp64 = hsr.cp64;
> >
> > gdprintk(XENLOG_ERR,
> > @@ -1718,7 +1715,6 @@ static void do_cp15_64(struct cpu_user_regs *regs,
> > cp64.op1, cp64.reg1, cp64.reg2, cp64.crm, regs->pc);
> > gdprintk(XENLOG_ERR, "unhandled 64-bit CP15 access %#x\n",
> > hsr.bits & HSR_CP64_REGS_MASK);
> > -#endif
>
> Did you try to build with debug=n ? I suspect that GCC will warn about
> the unused cp64.
I did, and it didn't.
Ian.
next prev parent reply other threads:[~2015-03-24 15:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 15:04 [PATCH 0/2] printk adjustments Jan Beulich
2015-03-20 15:12 ` [PATCH 1/2] introduce gprintk() Jan Beulich
2015-03-24 14:20 ` Ian Campbell
2015-03-24 15:12 ` Julien Grall
2015-03-24 15:31 ` Jan Beulich
2015-03-24 15:36 ` Julien Grall
2015-03-24 15:42 ` Ian Campbell [this message]
2015-03-20 15:13 ` [PATCH 2/2] make {,g}dprintk() a no‑op in non‑debug builds Jan Beulich
2015-03-24 14:19 ` Ian Campbell
2015-03-25 17:26 ` [PATCH 0/2] printk adjustments Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427211743.21742.445.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=julien.grall@citrix.com \
--cc=julien.grall@linaro.org \
--cc=keir@xen.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.