Re: Ian vs Ian, round 0 Was:Re: [PATCH v3 7/7] libxl/vcpu-set - allow to decrease vcpu count on overcommitted guests (v3)

[Ian Campbell <ian.campbell@citrix.com>]

On Tue, 2015-03-24 at 11:56 -0400, Konrad Rzeszutek Wilk wrote:
> > More generally all of these rc == ERROR_DOMAIN_NOTFOUND check and prints
> > are going to get rather tiresome, especially if/when there are other
> > interesting error codes. Perhaps we could arrange for something further
> > down the stack on libxl to log this sort of thing, such that xl can rely
> > on it already having been mentioned?
> > 
> > e.g. libxl_domain_info could do it perhaps?
> 
> That would be the easiest way. Should I drop
> 
> libxl: Add ERROR_DOMAIN_NOTFOUND for libxl_domain_info when it cannot find the domain
> 
> and just add an LIBXL__LOG_ERRNO and keep on returning the old error value
> (ERROR_INVAL)?

No.

I was suggesting that it should log *and* return DOMAIN_NOTFOUND, not
that the return code wasn't a good thing.

> Ian J recommended to add this new ERROR_DOMAIN_NOTFOUND in libxl_domain_info
> so I think I will let you two fight it out! (changing the title to catch
> Ian J's attention)

I haven't contradicted this.

Ian,