From: Scott Wood <scottwood@freescale.com>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: linuxppc-dev@lists.ozlabs.org, Paul Mackerras <paulus@samba.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] powerpc32: put csum_tcpudp_magic inline
Date: Tue, 24 Mar 2015 21:10:04 -0500 [thread overview]
Message-ID: <1427249404.22867.86.camel@freescale.com> (raw)
In-Reply-To: <20150203113927.52DA41A5F13@localhost.localdomain>
On Tue, 2015-02-03 at 12:39 +0100, Christophe Leroy wrote:
> csum_tcpudp_magic() is only a few instructions, and does not modifies any other
> register than the returned result. So it is not worth having it as a separate
> function and suffer function branching and saving of volatile registers.
> This patch makes it inline by use of the already existing csum_tcpudp_nofold()
> function.
>
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
>
> ---
> v2: no change
>
> arch/powerpc/include/asm/checksum.h | 15 +++++++++++++++
> arch/powerpc/lib/checksum_32.S | 16 ----------------
> 2 files changed, 15 insertions(+), 16 deletions(-)
The 64-bit version is pretty similar to the 32-bit -- why only use
csum_tcpudp_nofold() on 32-bit?
-Scott
WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>, <linux-kernel@vger.kernel.org>,
<linuxppc-dev@lists.ozlabs.org>,
Joakim Tjernlund <joakim.tjernlund@transmode.se>
Subject: Re: [PATCH v2 1/2] powerpc32: put csum_tcpudp_magic inline
Date: Tue, 24 Mar 2015 21:10:04 -0500 [thread overview]
Message-ID: <1427249404.22867.86.camel@freescale.com> (raw)
In-Reply-To: <20150203113927.52DA41A5F13@localhost.localdomain>
On Tue, 2015-02-03 at 12:39 +0100, Christophe Leroy wrote:
> csum_tcpudp_magic() is only a few instructions, and does not modifies any other
> register than the returned result. So it is not worth having it as a separate
> function and suffer function branching and saving of volatile registers.
> This patch makes it inline by use of the already existing csum_tcpudp_nofold()
> function.
>
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
>
> ---
> v2: no change
>
> arch/powerpc/include/asm/checksum.h | 15 +++++++++++++++
> arch/powerpc/lib/checksum_32.S | 16 ----------------
> 2 files changed, 15 insertions(+), 16 deletions(-)
The 64-bit version is pretty similar to the 32-bit -- why only use
csum_tcpudp_nofold() on 32-bit?
-Scott
next prev parent reply other threads:[~2015-03-25 2:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-03 11:39 [PATCH v2 1/2] powerpc32: put csum_tcpudp_magic inline Christophe Leroy
2015-02-03 11:39 ` Christophe Leroy
2015-03-25 2:10 ` Scott Wood [this message]
2015-03-25 2:10 ` Scott Wood
2015-04-28 19:08 ` christophe leroy
2015-04-28 19:08 ` christophe leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427249404.22867.86.camel@freescale.com \
--to=scottwood@freescale.com \
--cc=christophe.leroy@c-s.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.