All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomasz Figa <t.figa@samsung.com>
To: Praveen Paneri <p.paneri@samsung.com>
Cc: linux-usb@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com,
	balbi@ti.com, gregkh@linuxfoundation.org,
	thomas.abraham@linaro.org, ben-linux@fluff.org,
	broonie@opensource.wolfsonmicro.com, l.majewski@samsung.com,
	kyungmin.park@samsung.com, grant.likely@secretlab.ca,
	heiko@sntech.de, gautam.vivek@samsung.com
Subject: Re: [RESEND PATCH v9 0/2] usb: phy: samsung: Introducing usb phy driver for samsung SoCs
Date: Mon, 21 Jan 2013 15:23:23 +0100	[thread overview]
Message-ID: <1427513.LyTIEL8olI@amdc1227> (raw)
In-Reply-To: <1358499623-13901-1-git-send-email-p.paneri@samsung.com>

On Friday 18 of January 2013 14:30:21 Praveen Paneri wrote:
> Changes from v8:
> Resending this patch series after rebasing to the latest usb-next
> branch. Rewording inline comments for better readability.
> Removed IS_ENABLED(CONFIG_OF) as pdev->dev.of_node is enough to check
> for dt support. Using of_match_ptr to add of_match_table to
> platform_driver structure. Removed unnecessary variables.
> 
> Changes from v7:
> Rebased to the latest usb-next branch.
> Separating arch patches from these driver patches.
> 
> Changes from v6:
> Modified register definitions according to the existing ones.
> Changed default PHY clk selection for SoCs.
> Improved binding text and rebased to the latest usb-next.
> 
> Changes from v5:
> Moved clk_get() to driver's probe function. Now reference clock
> frequency selection value is stored in samsung_usbphy structure for
> later use. Used IS_ENABLED() instead of #ifdef in
> samsung_usbphy_get_driver_data().
> 
> Changes from v4:
> Moved header file contents to driver's source file
> Removed unnecessary print message from driver's probe function
> Dropped the Free Software Foundation address from the header
> 
> Changes from v3:
> Replaced susbsys_initcall()/module_exit() by module_platform_driver().
> Accordingly in the hsotg driver returned -EPROBE_DEFER until phy driver
> is registered
> Removed unnecessary devm_usb_put_phy() call from the hsotg driver
> remove.
> 
> Changes from v2:
> Changed the driver filenames to samsung-usbphy
> Rectified coding style related errors
> 
> Changes from v1:
> Rebased patches to latest usb-next branch
> Changed the name 'sec_usbphy' to 'samsung_usbphy'
> 
> This patch set introduces a phy driver for samsung SoCs. It uses the
> existing transceiver infrastructure to provide phy control functions.
> Use of this driver can be extended for usb host phy as well. Over the
> period of time all the phy related code for most of the samsung SoCs
> can be integrated here. Removing the existing phy code from
> mach-s3c64xx. Same can be done for other SoCs when they start
> supporting this phy driver.
> This driver is tested with smdk6410 and Exynos4210(with DT).
> 
> Praveen Paneri (2):
>   usb: phy: samsung: Introducing usb phy driver for hsotg
>   usb: s3c-hsotg: Adding phy driver support
> 
>  .../devicetree/bindings/usb/samsung-usbphy.txt     |   11 +
>  drivers/usb/gadget/s3c-hsotg.c                     |   37 ++-
>  drivers/usb/phy/Kconfig                            |    8 +
>  drivers/usb/phy/Makefile                           |    1 +
>  drivers/usb/phy/samsung-usbphy.c                   |  354
> ++++++++++++++++++++ include/linux/platform_data/samsung-usbphy.h      
> |   27 ++
>  6 files changed, 428 insertions(+), 10 deletions(-)
>  create mode 100644
> Documentation/devicetree/bindings/usb/samsung-usbphy.txt create mode
> 100644 drivers/usb/phy/samsung-usbphy.c
>  create mode 100644 include/linux/platform_data/samsung-usbphy.h
> 
> --
> To unsubscribe from this list: send the line "unsubscribe
> linux-samsung-soc" in the body of a message to
> majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Tested on Exynos4210-Trats.

Tested-by: Tomasz Figa <t.figa@samsung.com>

I also have patches for Exynos 4x12, which I will send once this series 
and generic PMU isolation setting patches get merged.

Best regards,
-- 
Tomasz Figa
Samsung Poland R&D Center
SW Solution Development, Linux Platform

WARNING: multiple messages have this Message-ID (diff)
From: t.figa@samsung.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH v9 0/2] usb: phy: samsung: Introducing usb phy driver for samsung SoCs
Date: Mon, 21 Jan 2013 15:23:23 +0100	[thread overview]
Message-ID: <1427513.LyTIEL8olI@amdc1227> (raw)
In-Reply-To: <1358499623-13901-1-git-send-email-p.paneri@samsung.com>

On Friday 18 of January 2013 14:30:21 Praveen Paneri wrote:
> Changes from v8:
> Resending this patch series after rebasing to the latest usb-next
> branch. Rewording inline comments for better readability.
> Removed IS_ENABLED(CONFIG_OF) as pdev->dev.of_node is enough to check
> for dt support. Using of_match_ptr to add of_match_table to
> platform_driver structure. Removed unnecessary variables.
> 
> Changes from v7:
> Rebased to the latest usb-next branch.
> Separating arch patches from these driver patches.
> 
> Changes from v6:
> Modified register definitions according to the existing ones.
> Changed default PHY clk selection for SoCs.
> Improved binding text and rebased to the latest usb-next.
> 
> Changes from v5:
> Moved clk_get() to driver's probe function. Now reference clock
> frequency selection value is stored in samsung_usbphy structure for
> later use. Used IS_ENABLED() instead of #ifdef in
> samsung_usbphy_get_driver_data().
> 
> Changes from v4:
> Moved header file contents to driver's source file
> Removed unnecessary print message from driver's probe function
> Dropped the Free Software Foundation address from the header
> 
> Changes from v3:
> Replaced susbsys_initcall()/module_exit() by module_platform_driver().
> Accordingly in the hsotg driver returned -EPROBE_DEFER until phy driver
> is registered
> Removed unnecessary devm_usb_put_phy() call from the hsotg driver
> remove.
> 
> Changes from v2:
> Changed the driver filenames to samsung-usbphy
> Rectified coding style related errors
> 
> Changes from v1:
> Rebased patches to latest usb-next branch
> Changed the name 'sec_usbphy' to 'samsung_usbphy'
> 
> This patch set introduces a phy driver for samsung SoCs. It uses the
> existing transceiver infrastructure to provide phy control functions.
> Use of this driver can be extended for usb host phy as well. Over the
> period of time all the phy related code for most of the samsung SoCs
> can be integrated here. Removing the existing phy code from
> mach-s3c64xx. Same can be done for other SoCs when they start
> supporting this phy driver.
> This driver is tested with smdk6410 and Exynos4210(with DT).
> 
> Praveen Paneri (2):
>   usb: phy: samsung: Introducing usb phy driver for hsotg
>   usb: s3c-hsotg: Adding phy driver support
> 
>  .../devicetree/bindings/usb/samsung-usbphy.txt     |   11 +
>  drivers/usb/gadget/s3c-hsotg.c                     |   37 ++-
>  drivers/usb/phy/Kconfig                            |    8 +
>  drivers/usb/phy/Makefile                           |    1 +
>  drivers/usb/phy/samsung-usbphy.c                   |  354
> ++++++++++++++++++++ include/linux/platform_data/samsung-usbphy.h      
> |   27 ++
>  6 files changed, 428 insertions(+), 10 deletions(-)
>  create mode 100644
> Documentation/devicetree/bindings/usb/samsung-usbphy.txt create mode
> 100644 drivers/usb/phy/samsung-usbphy.c
>  create mode 100644 include/linux/platform_data/samsung-usbphy.h
> 
> --
> To unsubscribe from this list: send the line "unsubscribe
> linux-samsung-soc" in the body of a message to
> majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Tested on Exynos4210-Trats.

Tested-by: Tomasz Figa <t.figa@samsung.com>

I also have patches for Exynos 4x12, which I will send once this series 
and generic PMU isolation setting patches get merged.

Best regards,
-- 
Tomasz Figa
Samsung Poland R&D Center
SW Solution Development, Linux Platform

  parent reply	other threads:[~2013-01-21 14:23 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-18  9:00 [RESEND PATCH v9 0/2] usb: phy: samsung: Introducing usb phy driver for samsung SoCs Praveen Paneri
2013-01-18  9:00 ` Praveen Paneri
2013-01-18  9:00 ` [RESEND PATCH v9 2/2] usb: s3c-hsotg: Adding phy driver support Praveen Paneri
2013-01-18  9:00   ` Praveen Paneri
2013-01-21 14:23 ` Tomasz Figa [this message]
2013-01-21 14:23   ` [RESEND PATCH v9 0/2] usb: phy: samsung: Introducing usb phy driver for samsung SoCs Tomasz Figa
     [not found] ` <1358499623-13901-1-git-send-email-p.paneri-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-01-18  9:00   ` [RESEND PATCH v9 1/2] usb: phy: samsung: Introducing usb phy driver for hsotg Praveen Paneri
2013-01-18  9:00     ` Praveen Paneri
2013-01-18 18:46   ` [RESEND PATCH v9 0/2] usb: phy: samsung: Introducing usb phy driver for samsung SoCs Felipe Balbi
2013-01-18 18:46     ` Felipe Balbi
2013-01-21  6:43     ` Praveen Paneri
2013-01-21  6:43       ` Praveen Paneri
2013-02-27  8:15   ` Felipe Balbi
2013-02-27  8:15     ` Felipe Balbi
2013-02-27  8:30     ` Vivek Gautam
2013-02-27  8:30       ` Vivek Gautam
     [not found]       ` <CAFp+6iGx1z9BcE3nLTVvOMG6VWVuYhDuKm5wu3DtbL8M1pfUtg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-02-27  8:33         ` Felipe Balbi
2013-02-27  8:33           ` Felipe Balbi
2013-02-27  8:38       ` Tomasz Figa
2013-02-27  8:38         ` Tomasz Figa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1427513.LyTIEL8olI@amdc1227 \
    --to=t.figa@samsung.com \
    --cc=balbi@ti.com \
    --cc=ben-linux@fluff.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=gautam.vivek@samsung.com \
    --cc=grant.likely@secretlab.ca \
    --cc=gregkh@linuxfoundation.org \
    --cc=heiko@sntech.de \
    --cc=kgene.kim@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=l.majewski@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=p.paneri@samsung.com \
    --cc=thomas.abraham@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.