From: Joe Perches <joe@perches.com>
To: Richard Weinberger <richard@nod.at>
Cc: "Shirish Gajera" <gshirishfree@gmail.com>,
w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca,
samuel.thibault@ens-lyon.org,
"Greg KH" <gregkh@linuxfoundation.org>,
"Domagoj Tršan" <domagoj.trsan@gmail.com>,
mahfouz.saif.elyazal@gmail.com,
"Ben Hutchings" <ben@decadent.org.uk>,
roxanagabriela10@gmail.com,
"Robin Schroer" <sulamiification@gmail.com>,
dilekuzulmez@gmail.com, "DaeSeok Youn" <daeseok.youn@gmail.com>,
"Ayşe Melike Yurtoğlu" <aysemelikeyurtoglu@gmail.com>,
"Rusty Russell" <rusty@rustcorp.com.au>,
tapaswenipathak@gmail.com, vthakkar1994@gmail.com,
speakup@linux-speakup.org,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: speakup: Fix warning of line over 80 characters.
Date: Sat, 28 Mar 2015 14:35:19 -0700 [thread overview]
Message-ID: <1427578519.2715.13.camel@perches.com> (raw)
In-Reply-To: <55171BAF.9050405@nod.at>
On Sat, 2015-03-28 at 22:22 +0100, Richard Weinberger wrote:
> Am 28.03.2015 um 22:18 schrieb Joe Perches:
> > On Sat, 2015-03-28 at 21:40 +0100, Richard Weinberger wrote:
> >> On Sat, Mar 28, 2015 at 9:21 PM, Shirish Gajera <gshirishfree@gmail.com> wrote:
> >>> This patch fixes the checkpatch.pl warning:
[]
> >> Instead of blindly adding newlines to silence checkpatch.pl, what
> >> about reworking the code?
> >> printf("%s\n", ..) cries for a puts().
> >
> > There is no synth_puts
>
> So what?
> Fix it! :-)
Not sure that'd make the code better... ;-p
> the whole code is horrible and lines other 80 chars are the *least*
> problem.
Dunno about how horrible it is, my guess is it works.
> Submitting a patch just for the sake of silencing checkpatch.pl is a waste of time.
> After applying this patch the driver 0 better than before.
Agree with that.
And truly, checkpatch is only a guide.
Making the code better instead of merely style conforming
should be the primary goal of patches.
next prev parent reply other threads:[~2015-03-28 21:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-28 20:21 [PATCH] staging: speakup: Fix warning of line over 80 characters Shirish Gajera
2015-03-28 20:40 ` Richard Weinberger
2015-03-28 21:18 ` Joe Perches
2015-03-28 21:22 ` Richard Weinberger
2015-03-28 21:35 ` Joe Perches [this message]
2015-03-28 23:44 ` Shirish Gajera
2015-03-28 23:54 ` Richard Weinberger
2015-03-29 0:26 ` Shirish Gajera
2015-03-29 9:28 ` Richard Weinberger
2015-03-30 6:17 ` Sudip Mukherjee
2015-03-30 7:23 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2015-01-18 7:57 Shirish Gajera
2015-01-18 8:29 ` Robin Schroer
2015-01-19 12:19 ` Dan Carpenter
2015-01-18 9:55 ` Ben Hutchings
2015-01-19 12:25 ` Dan Carpenter
[not found] ` <CAG77vrrbEmw7OR8N7bcmKEkDwXonsfmJeE6-epYxSMLT5uQpMw@mail.gmail.com>
2015-01-19 20:26 ` Dan Carpenter
2015-01-19 12:23 ` Dan Carpenter
2015-01-25 11:37 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427578519.2715.13.camel@perches.com \
--to=joe@perches.com \
--cc=aysemelikeyurtoglu@gmail.com \
--cc=ben@decadent.org.uk \
--cc=chris@the-brannons.com \
--cc=daeseok.youn@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=dilekuzulmez@gmail.com \
--cc=domagoj.trsan@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gshirishfree@gmail.com \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=mahfouz.saif.elyazal@gmail.com \
--cc=richard@nod.at \
--cc=roxanagabriela10@gmail.com \
--cc=rusty@rustcorp.com.au \
--cc=samuel.thibault@ens-lyon.org \
--cc=speakup@linux-speakup.org \
--cc=sulamiification@gmail.com \
--cc=tapaswenipathak@gmail.com \
--cc=vthakkar1994@gmail.com \
--cc=w.d.hubbs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.