From: Dan Carpenter <dan.carpenter@oracle.com>
To: shirish gajera <gajerashirish@gmail.com>
Cc: "Ben Hutchings" <ben@decadent.org.uk>,
kirk@reisers.ca, "Rusty Russell" <rusty@rustcorp.com.au>,
"Greg KH" <gregkh@linuxfoundation.org>,
"DaeSeok Youn" <daeseok.youn@gmail.com>,
"Robin Schroer" <sulamiification@gmail.com>,
speakup@linux-speakup.org,
"Ayşe Melike Yurtoğlu" <aysemelikeyurtoglu@gmail.com>,
linux-kernel@vger.kernel.org,
"Domagoj Tršan" <domagoj.trsan@gmail.com>,
"Roxana Blaj" <roxanagabriela10@gmail.com>,
tapaswenipathak@gmail.com,
"Samuel Thibault" <samuel.thibault@ens-lyon.org>,
"Dilek Üzülmez" <dilekuzulmez@gmail.com>,
sasha.levin@oracle.com,
"Christopher Brannon" <chris@the-brannons.com>
Subject: Re: [PATCH] staging: speakup: Fix warning of line over 80 characters.
Date: Mon, 19 Jan 2015 23:26:38 +0300 [thread overview]
Message-ID: <20150119202638.GC6507@mwanda> (raw)
In-Reply-To: <CAG77vrrbEmw7OR8N7bcmKEkDwXonsfmJeE6-epYxSMLT5uQpMw@mail.gmail.com>
On Mon, Jan 19, 2015 at 12:00:34PM -0800, shirish gajera wrote:
> I am confuse whether to wait till the patch got accepted or submit new
> patch set.
Just wait for Greg to get to the patch. We pretty much always apply
long line fixes so just assume it's going to merged.
>
> Also, how to identify whether the corresponding warning is real or not ?
It's all a matter of personal taste. The end code should look better
than the original code. I thought your changes looked pretty good...
regards,
dan carpenter
next prev parent reply other threads:[~2015-01-19 20:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-18 7:57 [PATCH] staging: speakup: Fix warning of line over 80 characters Shirish Gajera
2015-01-18 8:29 ` Robin Schroer
2015-01-19 12:19 ` Dan Carpenter
2015-01-18 9:55 ` Ben Hutchings
2015-01-19 12:25 ` Dan Carpenter
[not found] ` <CAG77vrrbEmw7OR8N7bcmKEkDwXonsfmJeE6-epYxSMLT5uQpMw@mail.gmail.com>
2015-01-19 20:26 ` Dan Carpenter [this message]
2015-01-19 12:23 ` Dan Carpenter
2015-01-25 11:37 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2015-03-28 20:21 Shirish Gajera
2015-03-28 20:40 ` Richard Weinberger
2015-03-28 21:18 ` Joe Perches
2015-03-28 21:22 ` Richard Weinberger
2015-03-28 21:35 ` Joe Perches
2015-03-28 23:44 ` Shirish Gajera
2015-03-28 23:54 ` Richard Weinberger
2015-03-29 0:26 ` Shirish Gajera
2015-03-29 9:28 ` Richard Weinberger
2015-03-30 6:17 ` Sudip Mukherjee
2015-03-30 7:23 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150119202638.GC6507@mwanda \
--to=dan.carpenter@oracle.com \
--cc=aysemelikeyurtoglu@gmail.com \
--cc=ben@decadent.org.uk \
--cc=chris@the-brannons.com \
--cc=daeseok.youn@gmail.com \
--cc=dilekuzulmez@gmail.com \
--cc=domagoj.trsan@gmail.com \
--cc=gajerashirish@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=roxanagabriela10@gmail.com \
--cc=rusty@rustcorp.com.au \
--cc=samuel.thibault@ens-lyon.org \
--cc=sasha.levin@oracle.com \
--cc=speakup@linux-speakup.org \
--cc=sulamiification@gmail.com \
--cc=tapaswenipathak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.